You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/13 04:34:41 UTC

[jira] [Commented] (NIFI-3702) Upgrade AWS SDK on 0.x branch, to remove json.org cat-x license concerns

    [ https://issues.apache.org/jira/browse/NIFI-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967109#comment-15967109 ] 

ASF GitHub Bot commented on NIFI-3702:
--------------------------------------

GitHub user jvwing opened a pull request:

    https://github.com/apache/nifi/pull/1670

    NIFI-3702 AWS SDK Update:

    * Updated the AWS SDK dependency version to 1.11.8
    * Removed GetDynamoDBTest references to JsonObject class dropped from AWS SDK
    * Fixed integration test ITPutSNS.testPublish() - exception from not evaluating expressions
    * Ignored integration test ITPutS3Object.testS3MultipartAgeoff() - did not work before or after SDK update
    ----
    
    **Reviewers**: In [NIFI-2062](https://issues.apache.org/jira/browse/NIFI-2062) we upgraded the master branch from AWS SDK 1.10.32 to 1.11.8.  The change included some adjustments to unit tests to account for Amazon's JSON changes.  We probably should have merged this to 0.x last year, but didn't.  So I recycled commit [a7c5b88](https://github.com/apache/nifi/commit/a7c5b88a470d832e1690faede9a5b2f606196342), changed the names to protect the innocent, and present it fresh for 0.x.
    
    ---
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jvwing/nifi NIFI-3702-aws-sdk-0x-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1670
    
----
commit d1f9d05d750a87ad52a0229b6b3979e60d974c55
Author: James Wing <jv...@gmail.com>
Date:   2016-06-21T20:06:02Z

    NIFI-3702 AWS SDK Update:
    
    * Updated the AWS SDK dependency version to 1.11.8
    * Removed GetDynamoDBTest references to JsonObject class dropped from AWS SDK
    * Fixed integration test ITPutSNS.testPublish() - exception from not evaluating expressions
    * Ignored integration test ITPutS3Object.testS3MultipartAgeoff() - did not work before or after SDK update

----


> Upgrade AWS SDK on 0.x branch, to remove json.org cat-x license concerns
> ------------------------------------------------------------------------
>
>                 Key: NIFI-3702
>                 URL: https://issues.apache.org/jira/browse/NIFI-3702
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Extensions
>    Affects Versions: 0.5.1, 0.6.1, 0.7.1
>            Reporter: Michael Moser
>            Priority: Blocker
>             Fix For: 0.8.0
>
>
> AWS-JAVA-SDK version 1.10.32 is currently used on 0.x branch, which includes JSON.org code.  JSON.org code has Category X license concerns, so we cannot use it anymore (see NIFI-2991).
> Upgrade AWS-JAVA-SDK to at least version 1.11.
> Update the nifi-aws-nar NOTICE file and nifi-assembly NOTICE file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)