You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/04/05 04:53:17 UTC
Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1595
https://issues.apache.org/jira/browse/AURORA-1595
Repository: aurora
Description
-------
Remove AddInstancesConfig parameter from addInstances RPC.
Diffs
-----
RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf
api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
src/test/python/apache/aurora/client/api/test_api.py c066ae7a05fbabaf7800d12459a743772366cbaa
src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
Diff: https://reviews.apache.org/r/45725/diff/
Testing
-------
end-to-end tests are green
Thanks,
Bill Farner
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127018
-----------------------------------------------------------
Ship it!
Master (f729fd4) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 5, 2016, 2:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 2:53 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
> src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
> src/test/python/apache/aurora/client/api/test_api.py c066ae7a05fbabaf7800d12459a743772366cbaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127163
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 4, 2016, 7:53 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 7:53 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
> src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
> src/test/python/apache/aurora/client/api/test_api.py c066ae7a05fbabaf7800d12459a743772366cbaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127031
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 5, 2016, 2:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 2:53 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
> src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
> src/test/python/apache/aurora/client/api/test_api.py c066ae7a05fbabaf7800d12459a743772366cbaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127386
-----------------------------------------------------------
Master (ddbb965) is red with this patch.
./build-support/jenkins/build.sh
thrift.addInstances(null, INSTANCE_KEY, 1);
^
required: InstanceKey,int
found: <null>,InstanceKey,int
reason: actual and formal argument lists differ in length
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java:1352: error: method addInstances in interface Iface cannot be applied to given types;
assertResponse(LOCK_ERROR, thrift.addInstances(null, INSTANCE_KEY, 1));
^
required: InstanceKey,int
found: <null>,InstanceKey,int
reason: actual and formal argument lists differ in length
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java:1371: error: method addInstances in interface Iface cannot be applied to given types;
assertResponse(INVALID_REQUEST, thrift.addInstances(null, INSTANCE_KEY, 1));
^
required: InstanceKey,int
found: <null>,InstanceKey,int
reason: actual and formal argument lists differ in length
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java:1387: error: method addInstances in interface Iface cannot be applied to given types;
assertResponse(INVALID_REQUEST, thrift.addInstances(null, INSTANCE_KEY, 1));
^
required: InstanceKey,int
found: <null>,InstanceKey,int
reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
7 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 3 mins 46.437 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2016, 5:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:49 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e
> src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127516
-----------------------------------------------------------
Master (9a93955) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
[1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7fa233bf00d0>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7fa233bf0510>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7fa233bf0510>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7fa233bf0510>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7fa233bf0510>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7fa233bf0510>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7fa233bf0510>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7fa233bf0510>] Time now: 1.502
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 664 passed, 5 skipped, 1 warnings in 276.99 seconds [0m
FAILURE
[32m
Waiting for background workers to finish.[0m
23:47:57 05:57 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2016, 10:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 10:31 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
> src/main/python/apache/aurora/client/api/__init__.py 294c5909b5d67c1694f38c2fa95d034c940fc056
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
> src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
> src/test/python/apache/aurora/client/api/test_api.py 0dd4b4105e78a797aedb9b888c476cefbc67d662
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127495
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On April 6, 2016, 3:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 3:31 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
> src/main/python/apache/aurora/client/api/__init__.py 294c5909b5d67c1694f38c2fa95d034c940fc056
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
> src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
> src/test/python/apache/aurora/client/api/test_api.py 0dd4b4105e78a797aedb9b888c476cefbc67d662
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127517
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On April 6, 2016, 3:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 3:31 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
> src/main/python/apache/aurora/client/api/__init__.py 294c5909b5d67c1694f38c2fa95d034c940fc056
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
> src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
> src/test/python/apache/aurora/client/api/test_api.py 0dd4b4105e78a797aedb9b888c476cefbc67d662
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127519
-----------------------------------------------------------
Ship it!
Master (9a93955) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2016, 10:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 10:31 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
> src/main/python/apache/aurora/client/api/__init__.py 294c5909b5d67c1694f38c2fa95d034c940fc056
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
> src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
> src/test/python/apache/aurora/client/api/test_api.py 0dd4b4105e78a797aedb9b888c476cefbc67d662
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127486
-----------------------------------------------------------
Master (103dae6) is red with this patch.
./build-support/jenkins/build.sh
[1m def __call__(_mock_self, *args, **kwargs):[0m
[1m # can't use self in-case a function / method we are mocking uses self[0m
[1m # in the signature[0m
[1m> _mock_self._mock_check_sig(*args, **kwargs)[0m
[1m[31mE TypeError: <lambda>() takes exactly 3 arguments (4 given)[0m
.pants.d/python-setup/chroots/bc4a46874d4da8d0b94b1bebc6185924b57d17bc/.deps/mock-1.0.1-py2-none-any.whl/mock.py:954: TypeError
-------------- Captured stderr call --------------
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
INFO] Adding 10 instances to foo/role/env/name using the task config of instance 1
I0406 22:52:46.341378 5168 __init__.py:103] Adding 10 instances to foo/role/env/name using the task config of instance 1
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 664 passed, 5 skipped, 1 warnings in 270.51 seconds [0m
FAILURE
[32m
Waiting for background workers to finish.[0m
22:52:50 05:51 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2016, 10:31 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 10:31 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
> src/main/python/apache/aurora/client/api/__init__.py 294c5909b5d67c1694f38c2fa95d034c940fc056
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
> src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
> src/test/python/apache/aurora/client/api/test_api.py 0dd4b4105e78a797aedb9b888c476cefbc67d662
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/
-----------------------------------------------------------
(Updated April 6, 2016, 3:31 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
fix api usage after rebase
Bugs: AURORA-1595
https://issues.apache.org/jira/browse/AURORA-1595
Repository: aurora
Description
-------
Remove AddInstancesConfig parameter from addInstances RPC.
Diffs (updated)
-----
RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
src/main/python/apache/aurora/client/api/__init__.py 294c5909b5d67c1694f38c2fa95d034c940fc056
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
src/test/python/apache/aurora/client/api/test_api.py 0dd4b4105e78a797aedb9b888c476cefbc67d662
src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
Diff: https://reviews.apache.org/r/45725/diff/
Testing
-------
end-to-end tests are green
Thanks,
Bill Farner
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/
-----------------------------------------------------------
(Updated April 6, 2016, 3:27 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
re-rebase
Bugs: AURORA-1595
https://issues.apache.org/jira/browse/AURORA-1595
Repository: aurora
Description
-------
Remove AddInstancesConfig parameter from addInstances RPC.
Diffs (updated)
-----
RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
Diff: https://reviews.apache.org/r/45725/diff/
Testing
-------
end-to-end tests are green
Thanks,
Bill Farner
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127419
-----------------------------------------------------------
This patch does not apply cleanly against master (ddbb965), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2016, 7:05 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 7:05 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
> src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/
-----------------------------------------------------------
(Updated April 6, 2016, 12:05 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
rebase
Bugs: AURORA-1595
https://issues.apache.org/jira/browse/AURORA-1595
Repository: aurora
Description
-------
Remove AddInstancesConfig parameter from addInstances RPC.
Diffs (updated)
-----
RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift 47ab500dffb0cec208edf9eff4c8298b1e717e8d
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java b078ef0d77f6f85976483147040a1fbbc33a7f6e
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 86088d98deace63b21b4de66ca317634b18e66d1
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 73a71287fb62395c57afb9daa5ffd0c750ec5e73
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3facb13ade29b9d2cbb1b0e48484845d4fb51b54
src/test/python/apache/aurora/api_util.py 4fde4bafbb035d78dbadacc65b4dc1ce6b3dd08c
src/test/python/apache/aurora/client/api/test_scheduler_client.py bd7c834873386b966dc919a9c18abeffc32c4c69
Diff: https://reviews.apache.org/r/45725/diff/
Testing
-------
end-to-end tests are green
Thanks,
Bill Farner
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/
-----------------------------------------------------------
(Updated April 6, 2016, 11:06 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
git-add file missed in rebase
Bugs: AURORA-1595
https://issues.apache.org/jira/browse/AURORA-1595
Repository: aurora
Description
-------
Remove AddInstancesConfig parameter from addInstances RPC.
Diffs (updated)
-----
RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e
src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d
src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71
Diff: https://reviews.apache.org/r/45725/diff/
Testing
-------
end-to-end tests are green
Thanks,
Bill Farner
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/
-----------------------------------------------------------
(Updated April 6, 2016, 10:49 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
rebase
Bugs: AURORA-1595
https://issues.apache.org/jira/browse/AURORA-1595
Repository: aurora
Description
-------
Remove AddInstancesConfig parameter from addInstances RPC.
Diffs (updated)
-----
RELEASE-NOTES.md 0e2e04be03195b9034ea17f05fb59519bc6aa1fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift 2412490b40f4836ac9e1d01aeb91f0e1e8c17028
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e6ea3c7b6d25e1c2c32a499246612fb2ca8a34b
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2959921d77ba4c1407a19fe7c752116cea47e26
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b557e2c20127e86114f8277ae5b2954d6c4bc2e
src/test/python/apache/aurora/api_util.py 1497332d266d00e5ae3b56dbde67539aadcf990d
src/test/python/apache/aurora/client/api/test_scheduler_client.py 0b14b09c8da5053501917e6b4b502714abc80b71
Diff: https://reviews.apache.org/r/45725/diff/
Testing
-------
end-to-end tests are green
Thanks,
Bill Farner
Re: Review Request 45725: Remove AddInstancesConfig parameter from
addInstances RPC.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45725/#review127094
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On April 5, 2016, 4:53 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45725/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 4:53 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1595
> https://issues.apache.org/jira/browse/AURORA-1595
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove AddInstancesConfig parameter from addInstances RPC.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 1df0345fac6ec6da92be15eb246c6957dea066bf
> api/src/main/thrift/org/apache/aurora/gen/api.thrift d4b8904031e6671a8083cac9b82d934377797fe2
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java d9039c935bb11f218558924609906b4b178711ec
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7eda474622388eb41695b65a4b349f416409a467
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f2f69f9d7c34bbd24aaa7cb90455f32ebf9aa2cd
> src/main/python/apache/aurora/client/api/__init__.py c5469bd89e57465e75a7c20c897a0bf9ce23c6f7
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f
> src/test/python/apache/aurora/api_util.py 4bb306fe577864c8611b6a34466b2189d903f103
> src/test/python/apache/aurora/client/api/test_api.py c066ae7a05fbabaf7800d12459a743772366cbaa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2
>
> Diff: https://reviews.apache.org/r/45725/diff/
>
>
> Testing
> -------
>
> end-to-end tests are green
>
>
> Thanks,
>
> Bill Farner
>
>