You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/04/14 12:22:53 UTC
Review Request 20316: CLOUDSTACK-1466: Adding "Domain Limits" and "Resize
Volume" test suits for Primary Storage Limits
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Domain Limits
2)Resize volume
Diffs
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding "Domain Limits" and
"Resize Volume" test suits for Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 82
> > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line82>
> >
> > Please call teardown in case of exception.
I didn't call in this case because there will be nothing to cleanup in case of exception. We are adding only service offering to cleanup list and if there is exception, it means the service offering is not created and we don't have to do any cleanup.
> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 106
> > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line106>
> >
> > Not calling teardown in case of exception.
self.fail will execute tearDown and tearDownClass.
> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 269
> > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line269>
> >
> > We didnt added it to clean up. Is that ok?
VM will be cleaned up as part of account cleanup. No need to add it explicitly to cleanup list.
> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 357
> > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line357>
> >
> > We are not adding it to cleanup?
Are you pointing to VM? As above explained, no need to add it to cleanup.
> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 559
> > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line559>
> >
> > Does clean up is not required here?
it is cleaned up as part of Account/project cleanup. Here we are cleaning up the account, so nned to add volume expicitly to cleanup list. Same applies for VM.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review40563
-----------------------------------------------------------
On April 14, 2014, 3:52 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 3:52 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Domain Limits
> 2)Resize volume
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding "Domain Limits" and
"Resize Volume" test suits for Primary Storage Limits
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review40563
-----------------------------------------------------------
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73594>
where is this func defined? I couldnt see it in current common mod?
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73595>
I believe codes and common module changes r missing
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73585>
Please call teardown in case of exception.
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73588>
Just check whether create is successful by verifying not None case and then add to clean up.
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73584>
Not calling teardown in case of exception.
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73589>
Its always 10, so may be we can remove this debug.
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73590>
We didnt added it to clean up. Is that ok?
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73591>
We are not adding it to cleanup?
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73583>
I believe the tag is selfservice, not simulator.
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73593>
Does clean up is not required here?
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment73592>
We can remove typecasting to int here.
test/integration/component/test_ps_resize_volume.py
<https://reviews.apache.org/r/20316/#comment73586>
Its not an issue though, just add one line of assert instead of if and fail, it may reduce few lines of code.
- Santhosh Edukulla
On April 14, 2014, 10:22 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 10:22 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Domain Limits
> 2)Resize volume
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review46043
-----------------------------------------------------------
Commit a0f19d4bd5d7bec6613aa8130b3da9ecffc71d0b in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a0f19d4 ]
CLOUDSTACK-1466: Automation - Priamary Storage Limits
- ASF Subversion and Git Services
On June 18, 2014, 4:06 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 4:06 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py ef49c0c
> tools/marvin/marvin/lib/base.py 8b89087
> tools/marvin/marvin/lib/common.py 7753385
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review46049
-----------------------------------------------------------
Commit e7fe391be4076309a9dc9a0f9bf8ea58181dfa12 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e7fe391 ]
CLOUDSTACK-1466: Automatiion - Primary Storage Limits test cases
- ASF Subversion and Git Services
On June 18, 2014, 7:42 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 7:42 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py ef49c0c
> tools/marvin/marvin/lib/base.py 8b89087
> tools/marvin/marvin/lib/common.py 7753385
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> File Attachments
> ----------------
>
> Rebased patch for master
> https://reviews.apache.org/media/uploaded/files/2014/06/18/fa7c2219-3cd8-49af-a8eb-2c8c7125ef34__0001-CLOUDSTACK-1466-Automatiion-Primary-Storage-Limits-t.patch
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated June 18, 2014, 1:12 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/base.py 8b89087
tools/marvin/marvin/lib/common.py 7753385
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
File Attachments (updated)
----------------
Rebased patch for master
https://reviews.apache.org/media/uploaded/files/2014/06/18/fa7c2219-3cd8-49af-a8eb-2c8c7125ef34__0001-CLOUDSTACK-1466-Automatiion-Primary-Storage-Limits-t.patch
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated June 18, 2014, 1:10 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Adding Rebased patch for master.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/base.py 8b89087
tools/marvin/marvin/lib/common.py 7753385
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
File Attachments (updated)
----------------
Patch for master branch
https://reviews.apache.org/media/uploaded/files/2014/06/18/5fc8afc6-212b-49dd-a83f-20dc56008c39__0001-CLOUDSTACK-1466-Automatiion-Primary-Storage-Limits-t.patch
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated June 18, 2014, 9:36 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Last patch would not apply cleanly.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs (updated)
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/base.py 8b89087
tools/marvin/marvin/lib/common.py 7753385
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated June 18, 2014, 8:53 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Rebased patch.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs (updated)
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/base.py 8b89087
tools/marvin/marvin/lib/common.py 7753385
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review45925
-----------------------------------------------------------
Ship it!
Ship It!
- Girish Shilamkar
On June 6, 2014, 9:40 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:40 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py ef49c0c
> tools/marvin/marvin/lib/base.py 2681724
> tools/marvin/marvin/lib/common.py 91fe053
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review45730
-----------------------------------------------------------
Gentle Reminder.
- Gaurav Aradhye
On June 6, 2014, 3:10 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 3:10 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py ef49c0c
> tools/marvin/marvin/lib/base.py 2681724
> tools/marvin/marvin/lib/common.py 91fe053
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review45731
-----------------------------------------------------------
Gentle Reminder.
- Gaurav Aradhye
On June 6, 2014, 3:10 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 3:10 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py ef49c0c
> tools/marvin/marvin/lib/base.py 2681724
> tools/marvin/marvin/lib/common.py 91fe053
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated June 6, 2014, 3:10 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs (updated)
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/base.py 2681724
tools/marvin/marvin/lib/common.py 91fe053
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated June 6, 2014, 2:15 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review changes.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs (updated)
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/base.py 2681724
tools/marvin/marvin/lib/common.py 91fe053
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated June 5, 2014, 7:03 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review changes.
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs (updated)
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py ef49c0c
tools/marvin/marvin/lib/base.py 2681724
tools/marvin/marvin/lib/common.py 91fe053
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
Thanks,
Gaurav Aradhye
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review42387
-----------------------------------------------------------
Gentle Reminder
- Gaurav Aradhye
On April 24, 2014, 11:01 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 11:01 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py 4d44c58
> tools/marvin/marvin/lib/base.py d753098
> tools/marvin/marvin/lib/common.py 8868d2d
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On May 8, 2014, 5:06 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/lib/common.py, line 1103
> > <https://reviews.apache.org/r/20316/diff/2/?file=567838#file567838line1103>
> >
> > Please dont add asserts to lib functions, just check the output in test code and take it accordingly.
Assert is inside try catch block, so exception won't be raised directly from library. We are returning FAIL in case of exception, along with the exception message.
> On May 8, 2014, 5:06 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/lib/common.py, line 1122
> > <https://reviews.apache.org/r/20316/diff/2/?file=567838#file567838line1122>
> >
> > Please remove asserts from libs.
It is inside try catch block.
> On May 8, 2014, 5:06 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/lib/common.py, line 1203
> > <https://reviews.apache.org/r/20316/diff/2/?file=567838#file567838line1203>
> >
> > This as well can be added to base.py. Maintaining too much common functions dependent upon base.py libraries is current overhead, VirtualMachine_obj.getState(args) can give us is expunged or stopped or started etc.
When VM is expunged, we do not get its state as "Expunged". List API throws exception in this case as it does not find the VM id. Hence this case is not a candidate for getState function in base.py
> On May 8, 2014, 5:06 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/lib/common.py, line 1185
> > <https://reviews.apache.org/r/20316/diff/2/?file=567838#file567838line1185>
> >
> > Can we move this function inside Snapshot class only?
Moved inside snapshot class
> On May 8, 2014, 5:06 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 51
> > <https://reviews.apache.org/r/20316/diff/2/?file=567831#file567831line51>
> >
> > Also, we can do a quick code walkthrough to understand the flow. It will help to do it more thoroughly. We can do a gtm.
Sure
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review42477
-----------------------------------------------------------
On April 24, 2014, 11:01 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 11:01 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py 4d44c58
> tools/marvin/marvin/lib/base.py d753098
> tools/marvin/marvin/lib/common.py 8868d2d
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review42477
-----------------------------------------------------------
test/integration/component/test_ps_domain_limits.py
<https://reviews.apache.org/r/20316/#comment76285>
Also, we can do a quick code walkthrough to understand the flow. It will help to do it more thoroughly. We can do a gtm.
tools/marvin/marvin/lib/common.py
<https://reviews.apache.org/r/20316/#comment76280>
Please dont add asserts to lib functions, just check the output in test code and take it accordingly.
tools/marvin/marvin/lib/common.py
<https://reviews.apache.org/r/20316/#comment76283>
Please remove asserts from libs.
tools/marvin/marvin/lib/common.py
<https://reviews.apache.org/r/20316/#comment76284>
This function is not required, its like a library on top of one more. We can directly check in test code only. Already, the function getUserApiClient, does returns the success\fail status.
tools/marvin/marvin/lib/common.py
<https://reviews.apache.org/r/20316/#comment76281>
Can we move this function inside Snapshot class only?
tools/marvin/marvin/lib/common.py
<https://reviews.apache.org/r/20316/#comment76282>
This as well can be added to base.py. Maintaining too much common functions dependent upon base.py libraries is current overhead, VirtualMachine_obj.getState(args) can give us is expunged or stopped or started etc.
- Santhosh Edukulla
On April 24, 2014, 5:31 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 5:31 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding test suits in Primary Storage Limits test cases.
> 1)Root/Domain admin limits
> 2)Domain Limits
> 3)Resize volume
> 4)Project Limits
> 5)Maximum Limits
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py PRE-CREATION
> test/integration/component/test_ps_limits.py PRE-CREATION
> test/integration/component/test_ps_max_limits.py PRE-CREATION
> test/integration/component/test_ps_project_limits.py PRE-CREATION
> test/integration/component/test_ps_resize_volume.py PRE-CREATION
> tools/marvin/marvin/codes.py 4d44c58
> tools/marvin/marvin/lib/base.py d753098
> tools/marvin/marvin/lib/common.py 8868d2d
>
> Diff: https://reviews.apache.org/r/20316/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for
Primary Storage Limits
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
-----------------------------------------------------------
(Updated April 24, 2014, 11:01 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review changes with inclusion of 3 more test suites.
Summary (updated)
-----------------
CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits
Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466
Repository: cloudstack-git
Description (updated)
-------
Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits
Diffs (updated)
-----
test/integration/component/test_ps_domain_limits.py PRE-CREATION
test/integration/component/test_ps_limits.py PRE-CREATION
test/integration/component/test_ps_max_limits.py PRE-CREATION
test/integration/component/test_ps_project_limits.py PRE-CREATION
test/integration/component/test_ps_resize_volume.py PRE-CREATION
tools/marvin/marvin/codes.py 4d44c58
tools/marvin/marvin/lib/base.py d753098
tools/marvin/marvin/lib/common.py 8868d2d
Diff: https://reviews.apache.org/r/20316/diff/
Testing
-------
Yes
Thanks,
Gaurav Aradhye