You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Gia Thuan Lam <du...@gmail.com> on 2018/05/03 00:41:03 UTC
Contribution on TUMBLE Implementation! I have implemented it and I
wonder if I can contribute it
Dear Calcite Administrators,
my name is Lam Gia Thuan, a CS student in Germany. I recently got to
work with Calcite for embedding SQL into Java and I realized that many
of Calcite examples were not working at all. Among them is TUMBLE, the
function I need but unfortunately, not working since there is no
implementation.
I have written a mail to ask about it but never got a reply, so I have
decided that i should implement it myself. At the moment, I already
implemented it, so I wonder if it is possible for me to submit this
contribution. I want to commit it so that if a new version of Calcite
is released, I will not need to change the implementation anymore.
If it is possible, could you please tell me how I should do it.
Thank you for creating Calcite. I am looking forward to hearing from you.
LAM GIA THUAN
Informatikstudent an der FH Frankfurt
Re: Contribution on TUMBLE Implementation! I have implemented it and
I wonder if I can contribute it
Posted by Francis Chuang <fr...@apache.org>.
Hi Gia,
Thank you so much for contributing! Calcite is an open-source project
and we accept all contributions (subject to review).
To get your contribution reviewed, please do the following:
1. Open an account on JIRA and create an issue:
https://issues.apache.org/jira/projects/CALCITE/issues
2. Fork Calcite (https://github.com/apache/calcite) on Github.
3. Push your changes into a new branch on your fork.
4. Open a Pull Request in the Calcite repository
(https://github.com/apache/calcite) so that we can review your changes.
When opening the pull request, please include the JIRA case number in
the title, for example [CALCITE-1234] Implement TUMBLE ...
Best,
Francis
On 3/05/2018 10:41 AM, Gia Thuan Lam wrote:
> Dear Calcite Administrators,
>
> my name is Lam Gia Thuan, a CS student in Germany. I recently got to
> work with Calcite for embedding SQL into Java and I realized that many
> of Calcite examples were not working at all. Among them is TUMBLE, the
> function I need but unfortunately, not working since there is no
> implementation.
>
> I have written a mail to ask about it but never got a reply, so I have
> decided that i should implement it myself. At the moment, I already
> implemented it, so I wonder if it is possible for me to submit this
> contribution. I want to commit it so that if a new version of Calcite
> is released, I will not need to change the implementation anymore.
>
> If it is possible, could you please tell me how I should do it.
>
> Thank you for creating Calcite. I am looking forward to hearing from you.
> LAM GIA THUAN
> Informatikstudent an der FH Frankfurt
Re: Contribution on TUMBLE Implementation! I have implemented it and
I wonder if I can contribute it
Posted by Rong Rong <wa...@gmail.com>.
Just to add to @shuyi's point and fyi: TUMBLE is implemented in
CALCITE-1603[1].
[1]: https://issues.apache.org/jira/browse/CALCITE-1603
On Wed, May 2, 2018 at 6:17 PM, Shuyi Chen <su...@gmail.com> wrote:
> Just curious, can you explain what the TUMBLE function is? There is already
> a TUMBLE function in Calcite for streaming queries (
> https://calcite.apache.org/docs/stream.html#tumbling-windows).
>
> On Wed, May 2, 2018 at 5:53 PM, Francis Chuang <fr...@apache.org>
> wrote:
>
> > I forgot to mention in my last message, but please also include the JIRA
> > case number in the commit message. For example [CALCITE-1234] Implement
> > TUMBLE ...
> >
> > Best,
> > Francis
> >
> > On 3/05/2018 10:41 AM, Gia Thuan Lam wrote:
> >
> >> Dear Calcite Administrators,
> >>
> >> my name is Lam Gia Thuan, a CS student in Germany. I recently got to
> >> work with Calcite for embedding SQL into Java and I realized that many
> >> of Calcite examples were not working at all. Among them is TUMBLE, the
> >> function I need but unfortunately, not working since there is no
> >> implementation.
> >>
> >> I have written a mail to ask about it but never got a reply, so I have
> >> decided that i should implement it myself. At the moment, I already
> >> implemented it, so I wonder if it is possible for me to submit this
> >> contribution. I want to commit it so that if a new version of Calcite
> >> is released, I will not need to change the implementation anymore.
> >>
> >> If it is possible, could you please tell me how I should do it.
> >>
> >> Thank you for creating Calcite. I am looking forward to hearing from
> you.
> >> LAM GIA THUAN
> >> Informatikstudent an der FH Frankfurt
> >>
> >
> >
> >
>
>
> --
> "So you have to trust that the dots will somehow connect in your future."
>
Re: Contribution on TUMBLE Implementation! I have implemented it and
I wonder if I can contribute it
Posted by Shuyi Chen <su...@gmail.com>.
Just curious, can you explain what the TUMBLE function is? There is already
a TUMBLE function in Calcite for streaming queries (
https://calcite.apache.org/docs/stream.html#tumbling-windows).
On Wed, May 2, 2018 at 5:53 PM, Francis Chuang <fr...@apache.org>
wrote:
> I forgot to mention in my last message, but please also include the JIRA
> case number in the commit message. For example [CALCITE-1234] Implement
> TUMBLE ...
>
> Best,
> Francis
>
> On 3/05/2018 10:41 AM, Gia Thuan Lam wrote:
>
>> Dear Calcite Administrators,
>>
>> my name is Lam Gia Thuan, a CS student in Germany. I recently got to
>> work with Calcite for embedding SQL into Java and I realized that many
>> of Calcite examples were not working at all. Among them is TUMBLE, the
>> function I need but unfortunately, not working since there is no
>> implementation.
>>
>> I have written a mail to ask about it but never got a reply, so I have
>> decided that i should implement it myself. At the moment, I already
>> implemented it, so I wonder if it is possible for me to submit this
>> contribution. I want to commit it so that if a new version of Calcite
>> is released, I will not need to change the implementation anymore.
>>
>> If it is possible, could you please tell me how I should do it.
>>
>> Thank you for creating Calcite. I am looking forward to hearing from you.
>> LAM GIA THUAN
>> Informatikstudent an der FH Frankfurt
>>
>
>
>
--
"So you have to trust that the dots will somehow connect in your future."
Re: Contribution on TUMBLE Implementation! I have implemented it and
I wonder if I can contribute it
Posted by Francis Chuang <fr...@apache.org>.
I forgot to mention in my last message, but please also include the JIRA
case number in the commit message. For example [CALCITE-1234] Implement
TUMBLE ...
Best,
Francis
On 3/05/2018 10:41 AM, Gia Thuan Lam wrote:
> Dear Calcite Administrators,
>
> my name is Lam Gia Thuan, a CS student in Germany. I recently got to
> work with Calcite for embedding SQL into Java and I realized that many
> of Calcite examples were not working at all. Among them is TUMBLE, the
> function I need but unfortunately, not working since there is no
> implementation.
>
> I have written a mail to ask about it but never got a reply, so I have
> decided that i should implement it myself. At the moment, I already
> implemented it, so I wonder if it is possible for me to submit this
> contribution. I want to commit it so that if a new version of Calcite
> is released, I will not need to change the implementation anymore.
>
> If it is possible, could you please tell me how I should do it.
>
> Thank you for creating Calcite. I am looking forward to hearing from you.
> LAM GIA THUAN
> Informatikstudent an der FH Frankfurt