You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4net-dev@logging.apache.org by Stefan Bodewig <bo...@apache.org> on 2016/09/07 04:30:33 UTC

Re: String Equality Comparison, Broken Tests and .NET-1.x

Hi Jonas

On 2016-08-23, <Jo...@rohde-schwarz.com> wrote:

> Stefan Bodewig <bo...@apache.org> wrote on 23.08.2016 06:14:32:

>> On 2016-08-22, <Jo...@rohde-schwarz.com> wrote:

>>> Should we create some helper in SystemInfo that provides null-aware,
>>> ordinal, casing-agnostic string equality comparison, with some #if's
>>> .NET-1.x?

>> +1

> Here you go. The attached patch introduces a `
> SystemInfo.EqualsIgnoringCase(string, string)`, some unit tests, and fixes
> `NewLinePatternConverter.ActivateOptions` so that the test suite passes
> again.

Thanks a lot. I finally managed to apply it. I had to modify it slightly
(a missing using statement and semicolon in the netstandard branch).

Tests should all pass now.

Stefan