You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/18 23:49:49 UTC
[GitHub] srowen commented on issue #23833: [SPARK-26917][SQL] Cache lock
recache by condition
srowen commented on issue #23833: [SPARK-26917][SQL] Cache lock recache by condition
URL: https://github.com/apache/spark/pull/23833#issuecomment-464924383
I don't know this code well, but the change looks reasonable. The question of course is somehow whether the decision to uncache something could change between where it happens before and after. It doesn't seem so, as the intent here seems to be to evaluate what is to be uncached, release the lock, then do it. Maybe CC @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org