You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Julian Foad <ju...@btopenworld.com> on 2013/01/23 16:19:39 UTC
Merge the new apr_hash_this_{key,key_len,val} to 1.5
Dear APR devs,
Please can we merge the these functions from trunk [1,2] to the next version to be released, which I assume would mean the 1.5 branch, before it's released, as originally discussed at [3]?
const char * apr_hash_this_key(apr_hash_index_t *);
apr_ssize_t apr_hash_this_key_len(apr_hash_index_t *);
void * apr_hash_this_val(apr_hash_index_t *);
The Apache Subversion code base already implements and extensively uses an equivalent API [4], and I anticipate Subversion would switch to using these new APR functions soon after they become available (using fallbacks when linking to older APR versions).
Note: Just before sending this, I sent a patch to simplify and constify these functions. It would be best to apply that patch before merging to 1.5 if that patch is accepted.
Let me know if I can help with this. I can commit the merge myself, for example, if you approve me to do so. (Likewise, the commit of the other patch.)
- Julian
[1] tracked as: <https://issues.apache.org/bugzilla/show_bug.cgi?id=49065>
[2] committed as: <http://svn.apache.org/viewvc?view=revision&revision=931973>
[3] discussed at: <http://mail-archives.apache.org/mod_mbox/apr-dev/201003.mbox/%3C4B96A8EF.8030401%40rowe-clan.net%3E> in the thread found at <http://mail-archives.apache.org/mod_mbox/apr-dev/201003.mbox/browser>; search for "[PATCH] apr_hash_this_{key,klen,val}".
[4] The equivalent API in Subversion uses longer names for the functions and an implementation that simply wraps apr_hash_this(). The code can be seen at e.g. <http://svn.apache.org/viewvc/subversion/tags/1.7.8/subversion/include/svn_types.h?annotate=1387206#l164> and <http://svn.apache.org/viewvc/subversion/tags/1.7.8/subversion/libsvn_subr/iter.c?annotate=1387206#l185>.
--
Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
Re: Merge the new apr_hash_this_{key,key_len,val} to 1.5
Posted by Rainer Jung <ra...@kippdata.de>.
On 29.03.2013 13:21, Rainer Jung wrote:
> Unfortunately the APR versioning rules do not allow addition of new
> functions to APU 1.5.x. We can put it into 1.6, but there's not yet a
> 1.6 release branch or plan.
Sorry, I got confused. Your proposal was meant for APR not APU.
Merged to APR 1.5 in r1462461. Again: no release plans currently.
Regards,
Rainer
Re: Merge the new apr_hash_this_{key,key_len,val} to 1.5
Posted by Rainer Jung <ra...@kippdata.de>.
On 23.01.2013 16:19, Julian Foad wrote:
> Dear APR devs,
>
> Please can we merge the these functions from trunk [1,2] to the next version to be released, which I assume would mean the 1.5 branch, before it's released, as originally discussed at [3]?
>
> const char * apr_hash_this_key(apr_hash_index_t *);
> apr_ssize_t apr_hash_this_key_len(apr_hash_index_t *);
> void * apr_hash_this_val(apr_hash_index_t *);
>
>
> The Apache Subversion code base already implements and extensively uses an equivalent API [4], and I anticipate Subversion would switch to using these new APR functions soon after they become available (using fallbacks when linking to older APR versions).
>
> Note: Just before sending this, I sent a patch to simplify and constify these functions. It would be best to apply that patch before merging to 1.5 if that patch is accepted.
>
> Let me know if I can help with this. I can commit the merge myself, for example, if you approve me to do so. (Likewise, the commit of the other patch.)
>
> - Julian
>
>
> [1] tracked as: <https://issues.apache.org/bugzilla/show_bug.cgi?id=49065>
>
> [2] committed as: <http://svn.apache.org/viewvc?view=revision&revision=931973>
>
> [3] discussed at: <http://mail-archives.apache.org/mod_mbox/apr-dev/201003.mbox/%3C4B96A8EF.8030401%40rowe-clan.net%3E> in the thread found at <http://mail-archives.apache.org/mod_mbox/apr-dev/201003.mbox/browser>; search for "[PATCH] apr_hash_this_{key,klen,val}".
>
> [4] The equivalent API in Subversion uses longer names for the functions and an implementation that simply wraps apr_hash_this(). The code can be seen at e.g. <http://svn.apache.org/viewvc/subversion/tags/1.7.8/subversion/include/svn_types.h?annotate=1387206#l164> and <http://svn.apache.org/viewvc/subversion/tags/1.7.8/subversion/libsvn_subr/iter.c?annotate=1387206#l185>.
Unfortunately the APR versioning rules do not allow addition of new
functions to APU 1.5.x. We can put it into 1.6, but there's not yet a
1.6 release branch or plan.
Regards,
Rainer