You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Bernd Fondermann (JIRA)" <se...@james.apache.org> on 2008/07/01 17:42:45 UTC
[jira] Commented: (JAMES-842) Inconsistencies in spring integration
[ https://issues.apache.org/jira/browse/JAMES-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609623#action_12609623 ]
Bernd Fondermann commented on JAMES-842:
----------------------------------------
Great work, Stefano! Thanks for taking care (also for 841 & 840).
> Inconsistencies in spring integration
> -------------------------------------
>
> Key: JAMES-842
> URL: https://issues.apache.org/jira/browse/JAMES-842
> Project: James
> Issue Type: Bug
> Affects Versions: 3.0
> Reporter: David Jencks
> Assignee: Stefano Bagnara
> Fix For: 3.0
>
> Attachments: JAMES-842.patch
>
>
> I've found a couple inconsistencies in the spring integration:
> in AvalonConfigurationFileProvider InputSource is supplied a systemId for the james config files whereas in AvalonBeanDefinitionReader it is not. In my scenario this means that the entities in james-config.xml don't work because for AvalonConfigurationFileProvider the entities are resolved relative to the james-config.xml file location whereas for AvalonBeanDefinitionReader they are resolved relative to some base directory.
> There's a FileSystem bean supplied to spring to locate stuff in the file system but it is not used in AvalonConfigurationFileProvider; AFAICT this means that configuration files must be in the classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: avalon-spring-library (Was: [jira] Commented: (JAMES-842) Inconsistencies in spring integration)
Posted by Bernd Fondermann <be...@googlemail.com>.
On Thu, Jul 3, 2008 at 10:59 AM, Stefano Bagnara <ap...@bago.org> wrote:
> Bernd Fondermann ha scritto:
>>
>> On Wed, Jul 2, 2008 at 10:57 AM, Stefano Bagnara <ap...@bago.org> wrote:
>>>
>>> Bernd Fondermann (JIRA) ha scritto:
>>>>
>>>> [
>>>>
>>>> https://issues.apache.org/jira/browse/JAMES-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609623#action_12609623
>>>> ]
>>>> Bernd Fondermann commented on JAMES-842:
>>>> ----------------------------------------
>>>>
>>>> Great work, Stefano! Thanks for taking care (also for 841 & 840).
>>>
>>> Thank you :-)
>>>
>>> Should we move the "non-james-specific" spring-avalon bridge to an
>>> "avalon-spring-library" and just keep the FileSystemBridge+configurations
>>> in
>>> the spring-deployment module?
>>
>> I see the motivation for this and think its very worthwhile from an
>> architectural POV.
>
> I just realized that I didn't explain well what I meant.
No, rereading this you did, but reading it for the first time I must
have mixed your past remarks in where you said that this spring-avalon
adapter might of interest for other projects than James.
> I was proposing only to create a james server submodule (like the
> core-library module) to host the non-james-specific code. This way the code
> would be part of the main james tree (we would have 1 more module, of
> course) but it would be cleaner what is the bridge and would be easier to
> allow people to just get the bridge and build it (with m2 is already
> possible to build a module without the whole project checked out).
Well, if _you_ propose to add yet another module, there must be
something to it ;-))
<snip/>
> And if people agree it is a positive change I would offer myself for the
> task (not a big issue, if I don't miss something).
+1
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: avalon-spring-library (Was: [jira] Commented: (JAMES-842)
Inconsistencies in spring integration)
Posted by Norman Maurer <no...@apache.org>.
Am Donnerstag, den 03.07.2008, 13:27 +0100 schrieb Robert Burrell
Donkin:
> On Thu, Jul 3, 2008 at 9:59 AM, Stefano Bagnara <ap...@bago.org> wrote:
> > Bernd Fondermann ha scritto:
> >>
> >> On Wed, Jul 2, 2008 at 10:57 AM, Stefano Bagnara <ap...@bago.org> wrote:
> >>>
> >>> Bernd Fondermann (JIRA) ha scritto:
> >>>>
> >>>> [
> >>>>
> >>>> https://issues.apache.org/jira/browse/JAMES-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609623#action_12609623
> >>>> ]
> >>>> Bernd Fondermann commented on JAMES-842:
> >>>> ----------------------------------------
> >>>>
> >>>> Great work, Stefano! Thanks for taking care (also for 841 & 840).
> >>>
> >>> Thank you :-)
> >>>
> >>> Should we move the "non-james-specific" spring-avalon bridge to an
> >>> "avalon-spring-library" and just keep the FileSystemBridge+configurations
> >>> in
> >>> the spring-deployment module?
> >>
> >> I see the motivation for this and think its very worthwhile from an
> >> architectural POV.
> >
> > I just realized that I didn't explain well what I meant.
> >
> > I was proposing only to create a james server submodule (like the
> > core-library module) to host the non-james-specific code. This way the code
> > would be part of the main james tree (we would have 1 more module, of
> > course) but it would be cleaner what is the bridge and would be easier to
> > allow people to just get the bridge and build it (with m2 is already
> > possible to build a module without the whole project checked out).
> >
> >> And I'd support it, if I'd have the time for it. But I haven't. :-/
> >> Maybe people from springframework.org want to adopt it and develop it
> >> independent from James.
> >
> > *IF* people will have interests in that code or we find that we need to
> > release it indipendently then (and only then) we could move it outside from
> > the james tree (as its own james product or in excalibur, or in
> > springframework..).
> >
> > And if people agree it is a positive change I would offer myself for the
> > task (not a big issue, if I don't miss something).
>
> sounds like a good change to me
>
> - robert
go, Stefano go ;-)
bye
Norman
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: avalon-spring-library (Was: [jira] Commented: (JAMES-842) Inconsistencies in spring integration)
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Thu, Jul 3, 2008 at 9:59 AM, Stefano Bagnara <ap...@bago.org> wrote:
> Bernd Fondermann ha scritto:
>>
>> On Wed, Jul 2, 2008 at 10:57 AM, Stefano Bagnara <ap...@bago.org> wrote:
>>>
>>> Bernd Fondermann (JIRA) ha scritto:
>>>>
>>>> [
>>>>
>>>> https://issues.apache.org/jira/browse/JAMES-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609623#action_12609623
>>>> ]
>>>> Bernd Fondermann commented on JAMES-842:
>>>> ----------------------------------------
>>>>
>>>> Great work, Stefano! Thanks for taking care (also for 841 & 840).
>>>
>>> Thank you :-)
>>>
>>> Should we move the "non-james-specific" spring-avalon bridge to an
>>> "avalon-spring-library" and just keep the FileSystemBridge+configurations
>>> in
>>> the spring-deployment module?
>>
>> I see the motivation for this and think its very worthwhile from an
>> architectural POV.
>
> I just realized that I didn't explain well what I meant.
>
> I was proposing only to create a james server submodule (like the
> core-library module) to host the non-james-specific code. This way the code
> would be part of the main james tree (we would have 1 more module, of
> course) but it would be cleaner what is the bridge and would be easier to
> allow people to just get the bridge and build it (with m2 is already
> possible to build a module without the whole project checked out).
>
>> And I'd support it, if I'd have the time for it. But I haven't. :-/
>> Maybe people from springframework.org want to adopt it and develop it
>> independent from James.
>
> *IF* people will have interests in that code or we find that we need to
> release it indipendently then (and only then) we could move it outside from
> the james tree (as its own james product or in excalibur, or in
> springframework..).
>
> And if people agree it is a positive change I would offer myself for the
> task (not a big issue, if I don't miss something).
sounds like a good change to me
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: avalon-spring-library (Was: [jira] Commented: (JAMES-842) Inconsistencies
in spring integration)
Posted by Stefano Bagnara <ap...@bago.org>.
Bernd Fondermann ha scritto:
> On Wed, Jul 2, 2008 at 10:57 AM, Stefano Bagnara <ap...@bago.org> wrote:
>> Bernd Fondermann (JIRA) ha scritto:
>>> [
>>> https://issues.apache.org/jira/browse/JAMES-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609623#action_12609623
>>> ]
>>> Bernd Fondermann commented on JAMES-842:
>>> ----------------------------------------
>>>
>>> Great work, Stefano! Thanks for taking care (also for 841 & 840).
>> Thank you :-)
>>
>> Should we move the "non-james-specific" spring-avalon bridge to an
>> "avalon-spring-library" and just keep the FileSystemBridge+configurations in
>> the spring-deployment module?
>
> I see the motivation for this and think its very worthwhile from an
> architectural POV.
I just realized that I didn't explain well what I meant.
I was proposing only to create a james server submodule (like the
core-library module) to host the non-james-specific code. This way the
code would be part of the main james tree (we would have 1 more module,
of course) but it would be cleaner what is the bridge and would be
easier to allow people to just get the bridge and build it (with m2 is
already possible to build a module without the whole project checked out).
> And I'd support it, if I'd have the time for it. But I haven't. :-/
> Maybe people from springframework.org want to adopt it and develop it
> independent from James.
*IF* people will have interests in that code or we find that we need to
release it indipendently then (and only then) we could move it outside
from the james tree (as its own james product or in excalibur, or in
springframework..).
And if people agree it is a positive change I would offer myself for the
task (not a big issue, if I don't miss something).
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: avalon-spring-library (Was: [jira] Commented: (JAMES-842) Inconsistencies in spring integration)
Posted by Bernd Fondermann <be...@googlemail.com>.
On Wed, Jul 2, 2008 at 10:57 AM, Stefano Bagnara <ap...@bago.org> wrote:
> Bernd Fondermann (JIRA) ha scritto:
>>
>> [
>> https://issues.apache.org/jira/browse/JAMES-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609623#action_12609623
>> ]
>> Bernd Fondermann commented on JAMES-842:
>> ----------------------------------------
>>
>> Great work, Stefano! Thanks for taking care (also for 841 & 840).
>
> Thank you :-)
>
> Should we move the "non-james-specific" spring-avalon bridge to an
> "avalon-spring-library" and just keep the FileSystemBridge+configurations in
> the spring-deployment module?
I see the motivation for this and think its very worthwhile from an
architectural POV.
And I'd support it, if I'd have the time for it. But I haven't. :-/
Maybe people from springframework.org want to adopt it and develop it
independent from James.
Right now I'd say that we - in this project - should concentrate on
making James better.
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
avalon-spring-library (Was: [jira] Commented: (JAMES-842) Inconsistencies
in spring integration)
Posted by Stefano Bagnara <ap...@bago.org>.
Bernd Fondermann (JIRA) ha scritto:
> [ https://issues.apache.org/jira/browse/JAMES-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609623#action_12609623 ]
>
> Bernd Fondermann commented on JAMES-842:
> ----------------------------------------
>
> Great work, Stefano! Thanks for taking care (also for 841 & 840).
Thank you :-)
Should we move the "non-james-specific" spring-avalon bridge to an
"avalon-spring-library" and just keep the
FileSystemBridge+configurations in the spring-deployment module?
Stefano
>> Inconsistencies in spring integration
>> -------------------------------------
>>
>> Key: JAMES-842
>> URL: https://issues.apache.org/jira/browse/JAMES-842
>> Project: James
>> Issue Type: Bug
>> Affects Versions: 3.0
>> Reporter: David Jencks
>> Assignee: Stefano Bagnara
>> Fix For: 3.0
>>
>> Attachments: JAMES-842.patch
>>
>>
>> I've found a couple inconsistencies in the spring integration:
>> in AvalonConfigurationFileProvider InputSource is supplied a systemId for the james config files whereas in AvalonBeanDefinitionReader it is not. In my scenario this means that the entities in james-config.xml don't work because for AvalonConfigurationFileProvider the entities are resolved relative to the james-config.xml file location whereas for AvalonBeanDefinitionReader they are resolved relative to some base directory.
>> There's a FileSystem bean supplied to spring to locate stuff in the file system but it is not used in AvalonConfigurationFileProvider; AFAICT this means that configuration files must be in the classpath.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org