Re: [PR] HIVE-28425: Document CAST FORMAT function in the wiki [hive-site]

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on PR #69:
URL: https://github.com/apache/hive-site/pull/69#issuecomment-3479582801

   Hey @makinyemi , thanks for submitting the pull-request. Unfortunately the documentation change is incorrect. HIVE-28425 is about adding documentation about the `CAST( <expr> AS <type> FORMAT <pattern>)` function that is not the same as `CAST(<expr> AS <type>)`. The two functions have different implementations so adding simply a link to `GenericUDFCastFormat` is misleading. Please raise another PR if you see a way to fix this otherwise I feel that it would be better to revert https://github.com/apache/hive-site/commit/4d9a300e0ee3cf67165dc401cba02773184af2b1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org