You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 23:30:19 UTC
[GitHub] [helix] pkuwm opened a new issue #1591: ZkClient async callback waitForSuccess() is stuck if session mismatched
pkuwm opened a new issue #1591:
URL: https://github.com/apache/helix/issues/1591
### Describe the bug
ZkClient `asyncCreate()` has a mechanism to retry the operation if the KeeperException code is retryable. But during the retry operation, if ZkSessionMismatchedException is thrown, the async callback is not being retried or cancelled, so the caller keeps waiting for the operation to complete. This issue blocks following pipeline running.
### To Reproduce
```
try {
zkClient.asyncCreate(path, record, CreateMode.PERSISTENT, createCallback);
Assert.fail("Invalid session should not create znode");
} catch (ZkSessionMismatchedException expected) {
Assert.assertEquals(expected.getMessage(),
"Failed to get expected zookeeper instance! There is a session id mismatch. Expected: "
+ "ExpectedSession. Actual: " + sessionId);
}
System.out.println("waiting");
Assert.assertTrue(createCallback.waitForSuccess());
System.out.println("after waiting");
[INFO] Running org.apache.helix.zookeeper.impl.client.TestRawZkClient
Starting ZK server at localhost:2127
waiting // stuck.........
```
### Expected behavior
Once an exception is thrown during the retry run, the callback context should be cancelled correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1591: ZkClient async callback waitForSuccess() is stuck if session mismatched
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1591:
URL: https://github.com/apache/helix/issues/1591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org