[GitHub] [airflow] potiuk commented on a change in pull request #17410: Improve diagnostics message when users have secret_key misconfigured

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #17410:
URL: https://github.com/apache/airflow/pull/17410#discussion_r682528405



##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -190,6 +191,15 @@ def _read(self, ti, try_number, metadata=None):
                 response.raise_for_status()
 
                 log += '\n' + response.text
+            except HTTPStatusError as e:
+                if e.response.status_code == 403:
+                    log += f"*** Failed to fetch log file from worker With 403, Forbidden error. {str(e)}\n"

Review comment:
       I put it a bit differently actually - before raising the status to make it simpler. I think it's still worth to add the str(err) in next line anyway as it might contain potentially some more diagnostics messages (for example if the forbidden is returned rather by a proxy than worker - it might contain extra message).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org