You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/30 08:21:53 UTC
[GitHub] [superset] ofekisr opened a new pull request #16917: refactor: sql lab command: separate concerns into small pieces
ofekisr opened a new pull request #16917:
URL: https://github.com/apache/superset/pull/16917
SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the sixteenth PR in the sequence of future PRs ([previous PR](https://github.com/apache/superset/pull/16852)) try to solve it by refactoring the code.
The PR focus on separating sqlJsonCommand concerns into dependencies (interfaces)
actually, there are no logic changes so it implies on the current tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98ca456) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.21%`.
> The diff coverage is `82.70%`.
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.82% -0.22%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42256 +6
- Misses 12349 12502 +153
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `81.98% <82.70%> (-0.44%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724682563
##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=arguments-renamed
Review comment:
Hi @john-bodley as you notice this is the only change that was done to the file.
It was done bc all of a sudden pylint required it in the CI
The recent series of pylint rules changes that was done has awaken wiered behaviour and the CI and require us to work for the pylint instead of it working for us
We should focus on writing gold clean code instead of sharpening minor lint rules that will almost provide no real value
My opinion is that the reality in the field (superset backend) is much concerning around code maintenance ability and readability of the code rather then linting rules.
linting all of sudden became a disturbance we need hop over on every PR
Try to develop a real feature your self and experience how linting is more in your way then helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on a change in pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724682563
##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=arguments-renamed
Review comment:
Hi @john-bodley as you notice this is the only change that was done to the file.
It was done bc all of a sudden pylint required it in the CI
The recent series of pylint rules changes that was done has awaken wiered behaviour and the CI and require us to work for the pylint instead of it working for us
linting all of sudden became a disturbance we need hop over on every PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724329925
##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=arguments-renamed
Review comment:
@ofekisr could we move these to the lines where the issue occurs? There was an effort in https://github.com/apache/superset/pull/16589 to remove top-level Pylint disable checks as it's i) unclear to the reader where these violations are occurring, and ii) potentially masks issues in future changes.
I realize that this wasn't clear and so adding it to the `CONTRIBUTING.md` in https://github.com/apache/superset/pull/17016.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724329925
##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=arguments-renamed
Review comment:
@ofekisr could we move these to the lines where the issue occurs? There was an effort in https://github.com/apache/superset/pull/16589 to remove top-level Pylint disable checks as it's i) unclear to the reader where these violations are occurring, and ii) potentially masks issues in future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98ca456) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.21%`.
> The diff coverage is `82.70%`.
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.82% -0.22%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42256 +6
- Misses 12349 12502 +153
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `81.98% <82.70%> (-0.44%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcf24fb) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.07%`.
> The diff coverage is `82.70%`.
> :exclamation: Current head dcf24fb differs from pull request most recent head 98ca456. Consider uploading reports for the commit 98ca456 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.96% -0.08%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42333 +83
- Misses 12349 12425 +76
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.44% <82.70%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `82.25% <82.70%> (-0.17%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98ca456) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **increase** coverage by `0.00%`.
> The diff coverage is `82.70%`.
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
========================================
Coverage 77.03% 77.03%
========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
========================================
+ Hits 42250 42375 +125
- Misses 12349 12383 +34
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.44% <82.70%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `81.77% <82.70%> (-0.02%)` | :arrow_down: |
| python | `82.39% <82.70%> (-0.03%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98ca456) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.07%`.
> The diff coverage is `82.70%`.
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.96% -0.08%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42333 +83
- Misses 12349 12425 +76
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.44% <82.70%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `82.25% <82.70%> (-0.17%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #16917:
URL: https://github.com/apache/superset/pull/16917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724329925
##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=arguments-renamed
Review comment:
@ofekisr could we move these to the lines where the issue occurs? There was an effort in https://github.com/apache/superset/pull/16589 to remove top-level Pylint disable checks as it's i) unclear to the reader where these violations are occurring, and ii) potentially masks issues in future changes.
##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=arguments-renamed
Review comment:
@ofekisr could we move these to the lines where the issue occurs? There was an effort in https://github.com/apache/superset/pull/16589 to remove top-level Pylint disable checks as it's i) unclear to the reader where these violations are occurring, and ii) potentially masks issues in future changes.
I realize that this wasn't clear and so adding it to the `CONTRIBUTING.md` in https://github.com/apache/superset/pull/17016.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98ca456) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.07%`.
> The diff coverage is `82.70%`.
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.96% -0.08%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42333 +83
- Misses 12349 12425 +76
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.44% <82.70%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `82.25% <82.70%> (-0.17%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcf24fb) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.21%`.
> The diff coverage is `82.70%`.
> :exclamation: Current head dcf24fb differs from pull request most recent head 98ca456. Consider uploading reports for the commit 98ca456 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.82% -0.22%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42256 +6
- Misses 12349 12502 +153
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `81.98% <82.70%> (-0.44%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcf24fb) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.21%`.
> The diff coverage is `82.70%`.
> :exclamation: Current head dcf24fb differs from pull request most recent head 98ca456. Consider uploading reports for the commit 98ca456 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.82% -0.22%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42256 +6
- Misses 12349 12502 +153
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `81.98% <82.70%> (-0.44%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcf24fb) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **increase** coverage by `0.00%`.
> The diff coverage is `82.70%`.
> :exclamation: Current head dcf24fb differs from pull request most recent head 98ca456. Consider uploading reports for the commit 98ca456 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
========================================
Coverage 77.03% 77.03%
========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
========================================
+ Hits 42250 42375 +125
- Misses 12349 12383 +34
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.44% <82.70%> (-0.01%)` | :arrow_down: |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `81.77% <82.70%> (-0.02%)` | :arrow_down: |
| python | `82.39% <82.70%> (-0.03%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org