You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2025/10/01 01:01:25 UTC

Re: [PR] Close receiving mailbox when an error block is received [pinot]

Jackie-Jiang commented on code in PR #16919:
URL: https://github.com/apache/pinot/pull/16919#discussion_r2393166629


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemorySendingMailbox.java:
##########
@@ -95,6 +95,7 @@ private void sendPrivate(MseBlock block, List<DataBuffer> serializedStats)
         throw new QueryException(QueryErrorCode.EXECUTION_TIMEOUT,
             String.format("Timed out adding block into mailbox: %s with timeout: %dms", _id, timeoutMs));
       case EARLY_TERMINATED:
+      case FIRST_ERROR:

Review Comment:
   In-memory one should never receive this status



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java:
##########
@@ -84,6 +84,9 @@ public void onNext(MailboxContent mailboxContent) {
           cancelStream();
           break;
         case FIRST_ERROR:
+          _responseObserver.onNext(MailboxStatus.newBuilder().setMailboxId(mailboxId)

Review Comment:
   I'm also not able to follow this early termination flag. Given we are cancelling the stream anyway, this shouldn't be required



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org