You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/01/28 22:03:43 UTC

[GitHub] [hudi] yihua opened a new pull request, #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

yihua opened a new pull request, #7784:
URL: https://github.com/apache/hudi/pull/7784

   ### Change Logs
   
   This PR adds the mvn build profiles for `hudi-utilities-slim-bundle` to `deploy_staging_jars.sh` as currently it does not generate `hudi-utilities-slim-bundle_2.11`.
   
   Also improves the mvn clean commands to properly clean all relevant modules before installation and deployment.
   
   This is validated by running it for 0.13.0 RC1.
   
   ### Impact
   
   Fixes `deploy_staging_jars.sh` to generate all `hudi-utilities-slim-bundle`.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #7784:
URL: https://github.com/apache/hudi/pull/7784#discussion_r1089830373


##########
scripts/release/deploy_staging_jars.sh:
##########
@@ -100,15 +104,17 @@ fi
 COMMON_OPTIONS="-DdeployArtifacts=true -DskipTests -DretryFailedDeploymentCount=10"
 for v in "${ALL_VERSION_OPTS[@]}"
 do
-  # clean everything before any round of depoyment
-  $MVN clean $COMMON_OPTIONS

Review Comment:
   We have to clean every module to give a clean start for each profile.  `mvn install` below has already built everything and we don't want the artifacts from previous round to interfere with this round. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on a diff in pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #7784:
URL: https://github.com/apache/hudi/pull/7784#discussion_r1089824641


##########
scripts/release/deploy_staging_jars.sh:
##########
@@ -100,15 +104,17 @@ fi
 COMMON_OPTIONS="-DdeployArtifacts=true -DskipTests -DretryFailedDeploymentCount=10"
 for v in "${ALL_VERSION_OPTS[@]}"
 do
-  # clean everything before any round of depoyment
-  $MVN clean $COMMON_OPTIONS

Review Comment:
   wouldn't this clean everything? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7784:
URL: https://github.com/apache/hudi/pull/7784#issuecomment-1407538347

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f4caf15a381feeda6f300a29d053b28dce8fa5a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14731",
       "triggerID" : "3f4caf15a381feeda6f300a29d053b28dce8fa5a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f4caf15a381feeda6f300a29d053b28dce8fa5a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14731) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on a diff in pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #7784:
URL: https://github.com/apache/hudi/pull/7784#discussion_r1089855666


##########
scripts/release/deploy_staging_jars.sh:
##########
@@ -100,15 +104,17 @@ fi
 COMMON_OPTIONS="-DdeployArtifacts=true -DskipTests -DretryFailedDeploymentCount=10"
 for v in "${ALL_VERSION_OPTS[@]}"
 do
-  # clean everything before any round of depoyment
-  $MVN clean $COMMON_OPTIONS
   if [[ "$v" == *"$BUNDLE_MODULES_EXCLUDED"* ]]; then

Review Comment:
   /nit you want to omit the trailing `*` as it's to check suffix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #7784:
URL: https://github.com/apache/hudi/pull/7784#discussion_r1089876033


##########
scripts/release/deploy_staging_jars.sh:
##########
@@ -100,15 +104,17 @@ fi
 COMMON_OPTIONS="-DdeployArtifacts=true -DskipTests -DretryFailedDeploymentCount=10"
 for v in "${ALL_VERSION_OPTS[@]}"
 do
-  # clean everything before any round of depoyment
-  $MVN clean $COMMON_OPTIONS
   if [[ "$v" == *"$BUNDLE_MODULES_EXCLUDED"* ]]; then

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7784:
URL: https://github.com/apache/hudi/pull/7784#issuecomment-1407509092

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f4caf15a381feeda6f300a29d053b28dce8fa5a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3f4caf15a381feeda6f300a29d053b28dce8fa5a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f4caf15a381feeda6f300a29d053b28dce8fa5a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #7784:
URL: https://github.com/apache/hudi/pull/7784


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7784: [HUDI-5640] Add missing profiles in `deploy_staging_jars.sh`

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7784:
URL: https://github.com/apache/hudi/pull/7784#issuecomment-1407510089

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f4caf15a381feeda6f300a29d053b28dce8fa5a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14731",
       "triggerID" : "3f4caf15a381feeda6f300a29d053b28dce8fa5a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f4caf15a381feeda6f300a29d053b28dce8fa5a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14731) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org