You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/17 10:55:02 UTC
[GitHub] [airflow] alexott opened a new pull request, #25115: Improved telemetry for Databricks provider
alexott opened a new pull request, #25115:
URL: https://github.com/apache/airflow/pull/25115
This change adds to Databricks provider more details about version of Airflow & provider itself, so we can understand what Airflow & provider versions are used and plan backports, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25115:
URL: https://github.com/apache/airflow/pull/25115#issuecomment-1187899486
We **just** upgraded mypy and it's a bit more picky https://github.com/apache/airflow/pull/25088.
Working on Airlfow's main is very much "living on the edge" :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a diff in pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on code in PR #25115:
URL: https://github.com/apache/airflow/pull/25115#discussion_r922815846
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -129,6 +130,21 @@ def databricks_conn(self) -> Connection:
def get_conn(self) -> Connection:
return self.databricks_conn
+ @cached_property
+ def user_agent_header(self) -> Dict[str, str]:
+ return {'user-agent': self.user_agent_str}
+
+ @cached_property
+ def user_agent_str(self) -> str:
Review Comment:
```suggestion
def user_agent_value(self) -> str:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25115:
URL: https://github.com/apache/airflow/pull/25115#issuecomment-1188069110
(the rebase to fix only applies to README markdown :). MyPy still needs fixing @alexott :grin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25115:
URL: https://github.com/apache/airflow/pull/25115#issuecomment-1194115912
Yeah. Turned out to be nasty "werkzeug" problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25115:
URL: https://github.com/apache/airflow/pull/25115#issuecomment-1187904120
(same for static check on markdown - new markdown-lint is a bit more picky too - but I fixed this this morning - so rebasing should help).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
alexott commented on PR #25115:
URL: https://github.com/apache/airflow/pull/25115#issuecomment-1187806547
Hmmm, doesn’t understand why mypy started to fail - that part didn’t change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a diff in pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
alexott commented on code in PR #25115:
URL: https://github.com/apache/airflow/pull/25115#discussion_r922869234
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -129,6 +130,21 @@ def databricks_conn(self) -> Connection:
def get_conn(self) -> Connection:
return self.databricks_conn
+ @cached_property
+ def user_agent_header(self) -> Dict[str, str]:
+ return {'user-agent': self.user_agent_str}
+
+ @cached_property
+ def user_agent_str(self) -> str:
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
alexott commented on PR #25115:
URL: https://github.com/apache/airflow/pull/25115#issuecomment-1193312666
Ok, I've fixed mypy errors in Databricks operator. But it's still failing in `airflow/utils/context.py:235:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25115:
URL: https://github.com/apache/airflow/pull/25115#issuecomment-1194116620
Rebased to see if it is all green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25115: Improved telemetry for Databricks provider
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25115:
URL: https://github.com/apache/airflow/pull/25115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org