[GitHub] [skywalking] kezhenxu94 commented on issue #7845: Add “.exe” suffix to the Windows compiled executable program for skywalking-eyes and skywalking-infra-e2e

[GitBox <gi...@apache.org>]

kezhenxu94 commented on issue #7845:
URL: https://github.com/apache/skywalking/issues/7845#issuecomment-930922449


   > If this has `.exe` suffix, then we need to be careful about dealing with `skywalking-eyes` checking or others in ASF doing check for our release. This could be identified as binary file, which is not allowed in the ASF source release. Meanwhile, according to your description, this should have a very clear document about what this exe is.
   
   `.exe` is definitely binary file, and it is only distributed in binary tar, not source tar.
   
   This issue is just to add a suffix `.exe` to the binary files, which were already distributed but not work because of lack of `.exe`.
   
   > And for more importantly, does this enough for Windows? We have swtcl(having Windows binary, but set up Linux's binary only) and many other scripts, are they working too?
   
   > The reason I asked about is that, once we say something in the doc, these a/b/c are for Windows, we actually are saying, we are going to support infra-e2e in Windows, and users even expect the consistent setting for Windows and MacOS/Linux.
   
   For `license-eye` it should be supported in Windows, but for `infra-e2e` it depends on how the users compose the control file, I'll just remove the label `infra-e2e`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org