[jira] [Commented] (MYFACES-3944) Calls to fcc.startComponentUniqueIdSection(...) and fcc.endComponentUniqueIdSection(...) should be surrounded in a try finally block

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223449#comment-14223449 ] 

Leonardo Uribe commented on MYFACES-3944:
-----------------------------------------

On the review it was found that in UserTagHandler there is a missing call to fcc.endComponentUniqueIdSection(); . That means all custom facelet tags will have the problem, but it will only be found when you use nested combinations of custom facelet tags and c:forEach tags.

So this issue should be classified as a bug.

> Calls to fcc.startComponentUniqueIdSection(...) and fcc.endComponentUniqueIdSection(...) should be surrounded in a try finally block
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3944
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3944
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-344
>    Affects Versions: 2.2.6
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>            Priority: Critical
>
> In some situations where an exception could be raised inside a component like c:forEach, and on the same time fcc.startComponentUniqueIdSection(...) and fcc.endComponentUniqueIdSection(...) are used, the section is not closed, affecting theoretically the ids generated.
> The probability of something like this is very low, but as a good practice it would be better to ensure  fcc.startComponentUniqueIdSection(...) and fcc.endComponentUniqueIdSection(...)  are called inside a try{...} finally block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)