You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2015/07/24 20:11:05 UTC
[jira] [Comment Edited] (SOLR-7825) Use slf4j consistently
[ https://issues.apache.org/jira/browse/SOLR-7825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640844#comment-14640844 ]
Uwe Schindler edited comment on SOLR-7825 at 7/24/15 6:10 PM:
--------------------------------------------------------------
Some comments:
- MapReduceIndexertool still imports the log4j class (leftover), it also imports SuppressForbidden but does not use it -> cleanup
- In the solr.txt sigatures file i would truncate with {{\*\*}} instead of {{\*}}. {{\*\*}} is like Ant/Maven's fileset includes and spawn several packages. So {{org.apache.log4j.\*\*}} would also match possible sub-packages.
was (Author: thetaphi):
Some comments:
- MapReduceIndexertool still imports the log4j class (leftover), it also imports SuppressForbidden but does not use it -> cleanup
- In the solr.txt sigatures file i would truncate with {{**}} instead of {{*}}. ** is like Ant/Maven's fileset includes and spawn several packages. So {{org.apache.log4j.**}} would also match possible sub-packages.
> Use slf4j consistently
> ----------------------
>
> Key: SOLR-7825
> URL: https://issues.apache.org/jira/browse/SOLR-7825
> Project: Solr
> Issue Type: Improvement
> Components: Server
> Affects Versions: 5.2.1
> Reporter: Oliver Schrenk
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Attachments: SOLR-7825.patch, slf4j.patch
>
>
> There are a few classes that directly rely on log4j to be on the classpath instead and don't use the slf4j logging facade. This creates problems when trying to switch the logging implementation.
> 1. org.apache.solr.core.ZkContainer
> https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/core/ZkContainer.java#L218
> I don't know the impact of this change, but shouldn't this call `org.apache.solr.logging.MDCLoggingContext.clear()` ?
> 2. org.apache.solr.handler.component.RangeFacetProcessor and org.apache.solr.handler.component.RangeFacetRequest
> should use slf4j instead of log4j
> I had a stab at it at
> https://github.com/oschrenk/lucene-solr/commit/025b4802caf0360c63a3554af82e9ed4c94ff5a3#diff-7d822e8ff8ff21d88437652bbc894739R28
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org