You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/13 18:47:56 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

lhotari opened a new pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216


   ### Motivation
   
   PR #7078 introduced preciseTopicPublishRateLimiterEnable setting, but this setting is missing from `broker.conf`. The impact of this is that it is required to use `PULSAR_PREFIX_preciseTopicPublishRateLimiterEnable: "true"` in `values.yaml` to enable the setting. It would be more consistent with other settings if `preciseTopicPublishRateLimiterEnable: "true"` could be used.
   
   ### Modifications
   
   Add `preciseTopicPublishRateLimiterEnable=false` to `broker.conf`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819258128


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820026006


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819949170


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819909274


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820664360


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819454021






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820026006


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819837630


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819683458


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819683458


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820736020


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819198064


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820883168


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819883263


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819198064


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819837630


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820736020






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819929893


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819258128






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819509276


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819224726


   > Can you check if we also need to add it to standalone.conf?
   
   @sijie I checked now. It would be needed. I'll add it.
   
   There's a lot of other configuration parameters missing from standalone.conf . Would it be necessary to create a separate issue to sync all missing parameters?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819130654


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819130654


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819767468


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819471843


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820664360


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819883263


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819767468






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819909274


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819454021


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819288324


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819326331


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-820818881


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819767634


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10216:
URL: https://github.com/apache/pulsar/pull/10216#issuecomment-819929893






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org