You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/21 14:31:55 UTC

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #425: Update KafkaManager.java

gengyuanzhe commented on pull request #425:
URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623


   In my opition, `org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close the kafka producer when `reconfigure()`. The `close()` should not be invoked in`startup ()`, it is confused.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org