You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/30 13:32:29 UTC
[GitHub] [airflow] potiuk opened a new pull request #22618: Final fix for image caching
potiuk opened a new pull request #22618:
URL: https://github.com/apache/airflow/pull/22618
This is - I hope - final fix for our image caching. I fought with
it for quite a while and it turned out that I was fighting with
buidkit bug when preparing a multiplatform image.
I think I finally got it under control, the main problem was that
when we prepared multi-platform image, seems like the image that
was prepared "last" was overriding the cache that was prepared
by the other platform build. This cause numerous problems with
investigating it, because sometimes it looked like it worked,
when the "other" platform was faster to build and someties it
did not when it was slower. It almost drove me mad.
It looks like however, that the inline cache works better in
this case (and I got it repetetively working) so finally we might
go back to faster builds on CI and fast pull for ./breeze.
I also opened an issue at buildkit, hoping that they will be able
to fix it:
https://github.com/moby/buildkit/issues/2758
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22618: Final fix for image caching
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22618:
URL: https://github.com/apache/airflow/pull/22618#issuecomment-1083149262
BTW. @mik-laj - this MIGHT MEAN that we can get the `--link` back - but I want to make it one-thing-at-a-time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22618: Final fix for image caching
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22618:
URL: https://github.com/apache/airflow/pull/22618#issuecomment-1083147589
I think I have FINALLY got the caching working.
CC: @Bowrna - this might slightly modify the https://github.com/apache/airflow/pull/22344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22618: Final fix for image caching
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22618:
URL: https://github.com/apache/airflow/pull/22618#issuecomment-1083154838
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22618: Final fix for image caching
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22618:
URL: https://github.com/apache/airflow/pull/22618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org