[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2059: [KYUUBI #1936] Send credentials when opening session and wait for completion

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #2059:
URL: https://github.com/apache/incubator-kyuubi/pull/2059#discussion_r822299986



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/credentials/HadoopCredentialsManager.scala
##########
@@ -219,13 +233,23 @@ class HadoopCredentialsManager private (name: String) extends AbstractService(na
                 s" $renewalRetryWait ms",
               e)
             scheduleRenewal(userRef, renewalRetryWait)
+            // throw exception when one-time execution fails,
+            // so that client side can be aware of this
+            if (waitCompletion) {
+              throw new KyuubiException(s"One-time execution failed for token update task " +

Review comment:
       @zhouyifan279 @ulysses-you, IMO, `waitCompletion` doesn't make sense to me. If this param is used to throw the exception, the `waitCompletion` is unncessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org