You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martijn Dashorst <ma...@gmail.com> on 2014/02/12 09:51:23 UTC
[VOTE] Release wicket 6.14.0
This is a vote to release Apache Wicket 6.14.0
Please download the source distributions found in our staging area
linked below.
I have included the signatures for both the source archives. This vote
lasts for 72 hours minimum.
[ ] Yes, release Apache Wicket 6.14.0
[ ] No, don't release Apache Wicket 6.14.0, because ...
Distributions, changelog, keys and signatures can be found at:
https://dist.apache.org/repos/dist/dev/wicket/6.14.0
Staging repository:
https://repository.apache.org/content/repositories/orgapachewicket-1004/
The binaries are available in the above link, as are a staging
repository for Maven. Typically the vote is on the source, but should
you find a problem with one of the binaries, please let me know, I can
re-roll them some way or the other.
========================================================================
The signatures for the source release artefacts:
apache-wicket-6.14.0.zip.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org
iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
=4QkG
-----END PGP SIGNATURE-----
apache-wicket-6.14.0.tar.gz.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org
iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
=3DVp
-----END PGP SIGNATURE-----
========================================================================
Release Notes - Wicket - Version 6.14.0
** Bug
* [WICKET-4697] - Autolinking not working as soon as component gets
a wicket:id
* [WICKET-5043] - Page not mounted with WebApplication#mountPackage
* [WICKET-5449] - Missing chapter 2 is causing off-by-one page names
in the guides URL links
* [WICKET-5460] - onBeforeRender called too early on stateless page
* [WICKET-5462] - Ajax form-component-label repainting fails when
setResponsePage() is used to navigate away from
the page that has previously failed form
validaiton
* [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
combination with Wizards
* [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
ComponentNotFoundException as a side-effect
* [WICKET-5467] - NumberTextField should support "any" as valid step
attribute value
* [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially appends
"/" after query parameters
* [WICKET-5469] - ModalWindow unload warning always displayed (even
if window is closed)
* [WICKET-5472] - PackageResource#internalGetResourceStream() should
return ProcessingResourceStream only when the
resource is existing
* [WICKET-5473] - Wicket does not handle non in-memory Httpsessions
correctly
* [WICKET-5477] - CSS class is not applied to <TD> for data filter
* [WICKET-5478] - Wrong JavaDoc for WicketTester
* [WICKET-5480] - AutoLabelResolver creates null pointer exception
in 6.13
* [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
annotations
* [WICKET-5484] - WebPageRenderer must not render full page in Ajax
requests
* [WICKET-5486] - WebPageRenderer should honor
RedirectPolicy.ALWAYS_REDIRECT more consistently
* [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
undefined on IE8, positions calendar out of
viewport
* [WICKET-5492] - WebApplication ignores a SecurityException when
reading the configuration type
* [WICKET-5496] - Wrong translation of RangeValidator.minimum and
RangeValidator.maximum
* [WICKET-5497] - NPE in JsonUtils when the value is null
* [WICKET-5499] - Page is not touched during initialization
* [WICKET-5500] - Ignore the path parameters when reading the page
class
* [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
** Improvement
* [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
add Child-Components
* [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior without
updating its hosting component
* [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest request)
Resilience against unsupported Charsets in Request
* [WICKET-5470] - Remove 'final' from org.apache.wicket.markup.html.
form.EnumChoiceRenderer#getDisplayValue
* [WICKET-5471] - Store the page if it is known that it will be used
in a following request
* [WICKET-5493] - Disable jar indexing
** New Feature
* [WICKET-3491] - Introduce IComponentOnConfigureListener
** Task
* [WICKET-5488] - Promote experimental modules to become stable
* [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and 2.1.0
Re: [VOTE] Release wicket 6.14.0
Posted by Martijn Dashorst <ma...@gmail.com>.
This vote failed. I have re-rolled the release, see the new vote thread...
Martijn
On Thu, Feb 13, 2014 at 4:11 PM, Martin Grigorov <mg...@apache.org>wrote:
> This vote is negative anyway because of the problem with the bound session
> after submitting statelessform.
>
> Now the question is whether to improve these problems before the next vote
> or leave it for 6.15.0.
> Our app has a problem that two different components have the same sequence
> number, so same markup id ("id"+sequence).
> I think the problem is WICKET-5473, so it should be fixed.
>
> The rest of the suggested improvements from 5508 are obvious problems but
> since no one complained about them I think they can wait for 6.15.0.
>
> Martin Grigorov
> Wicket Training and Consulting
>
>
> On Thu, Feb 13, 2014 at 4:02 PM, Emond Papegaaij <
> emond.papegaaij@topicus.nl
> > wrote:
>
> > These fields have been like this for ages, right? Something that does not
> > pose any problems for most users and is not a security risk, is not a
> > blocking issue IMHO. We can't postpone wicket releases until all issues
> are
> > solved, else we will never release. If something broke since 6.12 or 6.13
> > and affects many users, that would be a showstopper for the 6.14 release
> > for me.
> >
> > On Thursday 13 February 2014 15:55:54 Martin Grigorov wrote:
> > > The issues are listed at
> > https://issues.apache.org/jira/browse/WICKET-5508
> > >
> > > I am not 100% sure these improvements are really blockers for the
> > release.
> > >
> > > - #sequence and #pageId => AtomicInteger is an improvement
> > > - #locale and #style => AtomicReference is a bug but no one so far
> > > complained about such problem
> > > - #dirty and #sessionInvalidated => volatile is again bug without
> > complains
> > > so far
> > > - #dirty() to change the #dirty boolean flag for bound sessions. Maybe
> I
> > > should remove this from the suggested patch. Having a temporary
> > session and
> > > calling #setStyle("...") should bind the session, otherwise next
> request
> > > won't have the style. Same for locale and metadata, and attributes
> > > But #pageid and #sequence should not bind the session because they
> > are
> > > needed even for stateless pages
> > > (WICKET-5473<https://issues.apache.org/jira/browse/WICKET-5473>
> > > )
> > >
> > > Martin Grigorov
> > > Wicket Training and Consulting
> > >
> > > On Thu, Feb 13, 2014 at 3:33 PM, Michael Haitz
> > <mi...@1und1.de>wrote:
> > > > [X] No, don't release Apache Wicket 6.14.0, because ...
> > > >
> > > > of https://issues.apache.org/jira/browse/WICKET-5473 and other
> > related
> > > >
> > > > issues to Session class.
> > > >
> > > > Am 13.02.2014 um 14:14 schrieb Martin Grigorov
> > <mg...@apache.org>:
> > > > > I've tested:
> > > > > - our main app
> > > > > - WicketStuff (mvn clean test)
> > > > > - Wicket-Bootstrap
> > > > > - random Wicket-examples
> > > > >
> > > > > No other issues found
> > > > >
> > > > > Martin Grigorov
> > > > > Wicket Training and Consulting
> > > > >
> > > > >
> > > > > On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov
> > <mgrigorov@apache.org
> > > > >
> > > > >wrote:
> > > > >> This is fixed.
> > > > >> I still have to check our main application with 6.14.0
> > > > >>
> > > > >> Martin Grigorov
> > > > >> Wicket Training and Consulting
> > > > >>
> > > > >>
> > > > >> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov
> > <mgrigorov@apache.org
> > > > >
> > > > >wrote:
> > > > >>> I'll move setStatelessHint(false) back to
> > > >
> > > > RequestCycle.setResponsePage()
> > > >
> > > > >>> Martin Grigorov
> > > > >>> Wicket Training and Consulting
> > > > >>>
> > > > >>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier
> > <sv...@meiers.net> wrote:
> > > > >>>> Damn, not every page passed to PageProvider is stateless:
> > > > >>>>
> > > > >>>> + if (pageProvider.hasPageInstance())
> > > > >>>> + {
> > > > >>>> + IRequestablePage page =
> > > > >>>> pageProvider.getPageInstance();
> > > > >>>> + if (page instanceof Page)
> > > > >>>> + {
> > > > >>>> + ((Page)
> > > > >>>> page).setStatelessHint(false);
> > > > >>>>
> > > > >>>> :(
> > > > >>>>
> > > > >>>> Sven
> > > > >>>>
> > > > >>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
> > > > >>>>> [ X ] No, don't release Apache Wicket 6.14.0, because
> > submitting
> > > > >>>>> stateless
> > > > >>>>> form binds a session
> > > > >>>>>
> > > > >>>>> Martin Grigorov
> > > > >>>>> Wicket Training and Consulting
> > > > >>>>>
> > > > >>>>>
> > > > >>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
> > > > >>>>> martijn.dashorst@gmail.com> wrote:
> > > > >>>>>
> > > > >>>>> This is a vote to release Apache Wicket 6.14.0
> > > > >>>>>
> > > > >>>>>> Please download the source distributions found in our
> > staging area
> > > > >>>>>> linked below.
> > > > >>>>>>
> > > > >>>>>> I have included the signatures for both the source archives.
> > This
> > > >
> > > > vote
> > > >
> > > > >>>>>> lasts for 72 hours minimum.
> > > > >>>>>>
> > > > >>>>>> [ ] Yes, release Apache Wicket 6.14.0
> > > > >>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
> > > > >>>>>>
> > > > >>>>>> Distributions, changelog, keys and signatures can be found
> > at:
> > > > >>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
> > > > >>>>>>
> > > > >>>>>> Staging repository:
> > > > >>>>>>
> > > > >>>>>>
> > > > >>>>>> https://repository.apache.org/content/repositories/
> > > > >>>>>> orgapachewicket-1004/
> >
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [VOTE] Release wicket 6.14.0
Posted by Martin Grigorov <mg...@apache.org>.
This vote is negative anyway because of the problem with the bound session
after submitting statelessform.
Now the question is whether to improve these problems before the next vote
or leave it for 6.15.0.
Our app has a problem that two different components have the same sequence
number, so same markup id ("id"+sequence).
I think the problem is WICKET-5473, so it should be fixed.
The rest of the suggested improvements from 5508 are obvious problems but
since no one complained about them I think they can wait for 6.15.0.
Martin Grigorov
Wicket Training and Consulting
On Thu, Feb 13, 2014 at 4:02 PM, Emond Papegaaij <emond.papegaaij@topicus.nl
> wrote:
> These fields have been like this for ages, right? Something that does not
> pose any problems for most users and is not a security risk, is not a
> blocking issue IMHO. We can't postpone wicket releases until all issues are
> solved, else we will never release. If something broke since 6.12 or 6.13
> and affects many users, that would be a showstopper for the 6.14 release
> for me.
>
> On Thursday 13 February 2014 15:55:54 Martin Grigorov wrote:
> > The issues are listed at
> https://issues.apache.org/jira/browse/WICKET-5508
> >
> > I am not 100% sure these improvements are really blockers for the
> release.
> >
> > - #sequence and #pageId => AtomicInteger is an improvement
> > - #locale and #style => AtomicReference is a bug but no one so far
> > complained about such problem
> > - #dirty and #sessionInvalidated => volatile is again bug without
> complains
> > so far
> > - #dirty() to change the #dirty boolean flag for bound sessions. Maybe I
> > should remove this from the suggested patch. Having a temporary
> session and
> > calling #setStyle("...") should bind the session, otherwise next request
> > won't have the style. Same for locale and metadata, and attributes
> > But #pageid and #sequence should not bind the session because they
> are
> > needed even for stateless pages
> > (WICKET-5473<https://issues.apache.org/jira/browse/WICKET-5473>
> > )
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> >
> > On Thu, Feb 13, 2014 at 3:33 PM, Michael Haitz
> <mi...@1und1.de>wrote:
> > > [X] No, don't release Apache Wicket 6.14.0, because …
> > >
> > > of https://issues.apache.org/jira/browse/WICKET-5473 and other
> related
> > >
> > > issues to Session class.
> > >
> > > Am 13.02.2014 um 14:14 schrieb Martin Grigorov
> <mg...@apache.org>:
> > > > I've tested:
> > > > - our main app
> > > > - WicketStuff (mvn clean test)
> > > > - Wicket-Bootstrap
> > > > - random Wicket-examples
> > > >
> > > > No other issues found
> > > >
> > > > Martin Grigorov
> > > > Wicket Training and Consulting
> > > >
> > > >
> > > > On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov
> <mgrigorov@apache.org
> > > >
> > > >wrote:
> > > >> This is fixed.
> > > >> I still have to check our main application with 6.14.0
> > > >>
> > > >> Martin Grigorov
> > > >> Wicket Training and Consulting
> > > >>
> > > >>
> > > >> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov
> <mgrigorov@apache.org
> > > >
> > > >wrote:
> > > >>> I'll move setStatelessHint(false) back to
> > >
> > > RequestCycle.setResponsePage()
> > >
> > > >>> Martin Grigorov
> > > >>> Wicket Training and Consulting
> > > >>>
> > > >>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier
> <sv...@meiers.net> wrote:
> > > >>>> Damn, not every page passed to PageProvider is stateless:
> > > >>>>
> > > >>>> + if (pageProvider.hasPageInstance())
> > > >>>> + {
> > > >>>> + IRequestablePage page =
> > > >>>> pageProvider.getPageInstance();
> > > >>>> + if (page instanceof Page)
> > > >>>> + {
> > > >>>> + ((Page)
> > > >>>> page).setStatelessHint(false);
> > > >>>>
> > > >>>> :(
> > > >>>>
> > > >>>> Sven
> > > >>>>
> > > >>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
> > > >>>>> [ X ] No, don't release Apache Wicket 6.14.0, because
> submitting
> > > >>>>> stateless
> > > >>>>> form binds a session
> > > >>>>>
> > > >>>>> Martin Grigorov
> > > >>>>> Wicket Training and Consulting
> > > >>>>>
> > > >>>>>
> > > >>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
> > > >>>>> martijn.dashorst@gmail.com> wrote:
> > > >>>>>
> > > >>>>> This is a vote to release Apache Wicket 6.14.0
> > > >>>>>
> > > >>>>>> Please download the source distributions found in our
> staging area
> > > >>>>>> linked below.
> > > >>>>>>
> > > >>>>>> I have included the signatures for both the source archives.
> This
> > >
> > > vote
> > >
> > > >>>>>> lasts for 72 hours minimum.
> > > >>>>>>
> > > >>>>>> [ ] Yes, release Apache Wicket 6.14.0
> > > >>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
> > > >>>>>>
> > > >>>>>> Distributions, changelog, keys and signatures can be found
> at:
> > > >>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
> > > >>>>>>
> > > >>>>>> Staging repository:
> > > >>>>>>
> > > >>>>>>
> > > >>>>>> https://repository.apache.org/content/repositories/
> > > >>>>>> orgapachewicket-1004/
>
Re: [VOTE] Release wicket 6.14.0
Posted by Emond Papegaaij <em...@topicus.nl>.
These fields have been like this for ages, right? Something that does not
pose any problems for most users and is not a security risk, is not a
blocking issue IMHO. We can't postpone wicket releases until all issues are
solved, else we will never release. If something broke since 6.12 or 6.13
and affects many users, that would be a showstopper for the 6.14 release
for me.
On Thursday 13 February 2014 15:55:54 Martin Grigorov wrote:
> The issues are listed at
https://issues.apache.org/jira/browse/WICKET-5508
>
> I am not 100% sure these improvements are really blockers for the
release.
>
> - #sequence and #pageId => AtomicInteger is an improvement
> - #locale and #style => AtomicReference is a bug but no one so far
> complained about such problem
> - #dirty and #sessionInvalidated => volatile is again bug without
complains
> so far
> - #dirty() to change the #dirty boolean flag for bound sessions. Maybe I
> should remove this from the suggested patch. Having a temporary
session and
> calling #setStyle("...") should bind the session, otherwise next request
> won't have the style. Same for locale and metadata, and attributes
> But #pageid and #sequence should not bind the session because they
are
> needed even for stateless pages
> (WICKET-5473<https://issues.apache.org/jira/browse/WICKET-5473>
> )
>
> Martin Grigorov
> Wicket Training and Consulting
>
> On Thu, Feb 13, 2014 at 3:33 PM, Michael Haitz
<mi...@1und1.de>wrote:
> > [X] No, don't release Apache Wicket 6.14.0, because …
> >
> > of https://issues.apache.org/jira/browse/WICKET-5473 and other
related
> >
> > issues to Session class.
> >
> > Am 13.02.2014 um 14:14 schrieb Martin Grigorov
<mg...@apache.org>:
> > > I've tested:
> > > - our main app
> > > - WicketStuff (mvn clean test)
> > > - Wicket-Bootstrap
> > > - random Wicket-examples
> > >
> > > No other issues found
> > >
> > > Martin Grigorov
> > > Wicket Training and Consulting
> > >
> > >
> > > On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov
<mgrigorov@apache.org
> > >
> > >wrote:
> > >> This is fixed.
> > >> I still have to check our main application with 6.14.0
> > >>
> > >> Martin Grigorov
> > >> Wicket Training and Consulting
> > >>
> > >>
> > >> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov
<mgrigorov@apache.org
> > >
> > >wrote:
> > >>> I'll move setStatelessHint(false) back to
> >
> > RequestCycle.setResponsePage()
> >
> > >>> Martin Grigorov
> > >>> Wicket Training and Consulting
> > >>>
> > >>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier
<sv...@meiers.net> wrote:
> > >>>> Damn, not every page passed to PageProvider is stateless:
> > >>>>
> > >>>> + if (pageProvider.hasPageInstance())
> > >>>> + {
> > >>>> + IRequestablePage page =
> > >>>> pageProvider.getPageInstance();
> > >>>> + if (page instanceof Page)
> > >>>> + {
> > >>>> + ((Page)
> > >>>> page).setStatelessHint(false);
> > >>>>
> > >>>> :(
> > >>>>
> > >>>> Sven
> > >>>>
> > >>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
> > >>>>> [ X ] No, don't release Apache Wicket 6.14.0, because
submitting
> > >>>>> stateless
> > >>>>> form binds a session
> > >>>>>
> > >>>>> Martin Grigorov
> > >>>>> Wicket Training and Consulting
> > >>>>>
> > >>>>>
> > >>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
> > >>>>> martijn.dashorst@gmail.com> wrote:
> > >>>>>
> > >>>>> This is a vote to release Apache Wicket 6.14.0
> > >>>>>
> > >>>>>> Please download the source distributions found in our
staging area
> > >>>>>> linked below.
> > >>>>>>
> > >>>>>> I have included the signatures for both the source archives.
This
> >
> > vote
> >
> > >>>>>> lasts for 72 hours minimum.
> > >>>>>>
> > >>>>>> [ ] Yes, release Apache Wicket 6.14.0
> > >>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
> > >>>>>>
> > >>>>>> Distributions, changelog, keys and signatures can be found
at:
> > >>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
> > >>>>>>
> > >>>>>> Staging repository:
> > >>>>>>
> > >>>>>>
> > >>>>>> https://repository.apache.org/content/repositories/
> > >>>>>> orgapachewicket-1004/
Re: [VOTE] Release wicket 6.14.0
Posted by Emond Papegaaij <em...@gmail.com>.
The issue you are referring to is fixed in 6.14.0, according to JIRA, so
why not release? What does 6.14.0 break that did work in 6.13.0?
On Thu, Feb 13, 2014 at 3:33 PM, Michael Haitz <mi...@1und1.de>wrote:
> [X] No, don't release Apache Wicket 6.14.0, because ...
>
> of https://issues.apache.org/jira/browse/WICKET-5473 and other related
> issues to Session class.
>
> Am 13.02.2014 um 14:14 schrieb Martin Grigorov <mg...@apache.org>:
>
> > I've tested:
> > - our main app
> > - WicketStuff (mvn clean test)
> > - Wicket-Bootstrap
> > - random Wicket-examples
> >
> > No other issues found
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> >
> >
> > On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
> >
> >> This is fixed.
> >> I still have to check our main application with 6.14.0
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >>
> >>
> >> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
> >>
> >>> I'll move setStatelessHint(false) back to
> RequestCycle.setResponsePage()
> >>>
> >>> Martin Grigorov
> >>> Wicket Training and Consulting
> >>>
> >>>
> >>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier <sv...@meiers.net> wrote:
> >>>
> >>>> Damn, not every page passed to PageProvider is stateless:
> >>>>
> >>>> + if (pageProvider.hasPageInstance())
> >>>> + {
> >>>> + IRequestablePage page =
> >>>> pageProvider.getPageInstance();
> >>>> + if (page instanceof Page)
> >>>> + {
> >>>> + ((Page) page).setStatelessHint(false);
> >>>>
> >>>> :(
> >>>>
> >>>> Sven
> >>>>
> >>>>
> >>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
> >>>>
> >>>>> [ X ] No, don't release Apache Wicket 6.14.0, because submitting
> >>>>> stateless
> >>>>> form binds a session
> >>>>>
> >>>>> Martin Grigorov
> >>>>> Wicket Training and Consulting
> >>>>>
> >>>>>
> >>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
> >>>>> martijn.dashorst@gmail.com> wrote:
> >>>>>
> >>>>> This is a vote to release Apache Wicket 6.14.0
> >>>>>>
> >>>>>> Please download the source distributions found in our staging area
> >>>>>> linked below.
> >>>>>>
> >>>>>> I have included the signatures for both the source archives. This
> vote
> >>>>>> lasts for 72 hours minimum.
> >>>>>>
> >>>>>> [ ] Yes, release Apache Wicket 6.14.0
> >>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
> >>>>>>
> >>>>>> Distributions, changelog, keys and signatures can be found at:
> >>>>>>
> >>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
> >>>>>>
> >>>>>> Staging repository:
> >>>>>>
> >>>>>>
> >>>>>> https://repository.apache.org/content/repositories/
> >>>>>> orgapachewicket-1004/
> >>>>>>
> >>>>>> The binaries are available in the above link, as are a staging
> >>>>>> repository for Maven. Typically the vote is on the source, but
> should
> >>>>>> you find a problem with one of the binaries, please let me know, I
> can
> >>>>>> re-roll them some way or the other.
> >>>>>>
> >>>>>> ============================================================
> >>>>>> ============
> >>>>>>
> >>>>>> The signatures for the source release artefacts:
> >>>>>>
> >>>>>> apache-wicket-6.14.0.zip.asc
> >>>>>>
> >>>>>> -----BEGIN PGP SIGNATURE-----
> >>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> >>>>>> Comment: GPGTools - https://gpgtools.org
> >>>>>>
> >>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
> >>>>>> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
> >>>>>> =4QkG
> >>>>>> -----END PGP SIGNATURE-----
> >>>>>>
> >>>>>> apache-wicket-6.14.0.tar.gz.asc
> >>>>>>
> >>>>>> -----BEGIN PGP SIGNATURE-----
> >>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> >>>>>> Comment: GPGTools - https://gpgtools.org
> >>>>>>
> >>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
> >>>>>> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
> >>>>>> =3DVp
> >>>>>> -----END PGP SIGNATURE-----
> >>>>>>
> >>>>>> ============================================================
> >>>>>> ============
> >>>>>>
> >>>>>> Release Notes - Wicket - Version 6.14.0
> >>>>>>
> >>>>>> ** Bug
> >>>>>>
> >>>>>> * [WICKET-4697] - Autolinking not working as soon as component
> >>>>>> gets
> >>>>>> a wicket:id
> >>>>>>
> >>>>>> * [WICKET-5043] - Page not mounted with
> >>>>>> WebApplication#mountPackage
> >>>>>>
> >>>>>> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page
> >>>>>> names
> >>>>>> in the guides URL links
> >>>>>>
> >>>>>> * [WICKET-5460] - onBeforeRender called too early on stateless
> >>>>>> page
> >>>>>>
> >>>>>> * [WICKET-5462] - Ajax form-component-label repainting fails
> when
> >>>>>> setResponsePage() is used to navigate away from
> >>>>>> the page that has previously failed form
> >>>>>> validaiton
> >>>>>>
> >>>>>> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
> >>>>>> combination with Wizards
> >>>>>>
> >>>>>> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
> >>>>>> ComponentNotFoundException as a side-effect
> >>>>>>
> >>>>>> * [WICKET-5467] - NumberTextField should support "any" as valid
> >>>>>> step
> >>>>>> attribute value
> >>>>>>
> >>>>>> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially
> >>>>>> appends
> >>>>>> "/" after query parameters
> >>>>>>
> >>>>>> * [WICKET-5469] - ModalWindow unload warning always displayed
> >>>>>> (even
> >>>>>> if window is closed)
> >>>>>>
> >>>>>> * [WICKET-5472] - PackageResource#internalGetResourceStream()
> >>>>>> should
> >>>>>> return ProcessingResourceStream only when the
> >>>>>> resource is existing
> >>>>>>
> >>>>>> * [WICKET-5473] - Wicket does not handle non in-memory
> >>>>>> Httpsessions
> >>>>>> correctly
> >>>>>>
> >>>>>> * [WICKET-5477] - CSS class is not applied to <TD> for data
> filter
> >>>>>>
> >>>>>> * [WICKET-5478] - Wrong JavaDoc for WicketTester
> >>>>>>
> >>>>>> * [WICKET-5480] - AutoLabelResolver creates null pointer
> exception
> >>>>>> in 6.13
> >>>>>>
> >>>>>> * [WICKET-5482] - Wicket-guice doesn't support
> @javax.inject.Named
> >>>>>> annotations
> >>>>>>
> >>>>>> * [WICKET-5484] - WebPageRenderer must not render full page in
> >>>>>> Ajax
> >>>>>> requests
> >>>>>>
> >>>>>> * [WICKET-5486] - WebPageRenderer should honor
> >>>>>> RedirectPolicy.ALWAYS_REDIRECT more consistently
> >>>>>>
> >>>>>> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
> >>>>>> undefined on IE8, positions calendar out of
> >>>>>> viewport
> >>>>>>
> >>>>>> * [WICKET-5492] - WebApplication ignores a SecurityException
> when
> >>>>>> reading the configuration type
> >>>>>>
> >>>>>> * [WICKET-5496] - Wrong translation of RangeValidator.minimum
> and
> >>>>>> RangeValidator.maximum
> >>>>>>
> >>>>>> * [WICKET-5497] - NPE in JsonUtils when the value is null
> >>>>>>
> >>>>>> * [WICKET-5499] - Page is not touched during initialization
> >>>>>>
> >>>>>> * [WICKET-5500] - Ignore the path parameters when reading the
> page
> >>>>>> class
> >>>>>>
> >>>>>> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
> >>>>>>
> >>>>>> ** Improvement
> >>>>>>
> >>>>>> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer
> to
> >>>>>> add Child-Components
> >>>>>>
> >>>>>> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior
> >>>>>> without
> >>>>>> updating its hosting component
> >>>>>>
> >>>>>> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest
> >>>>>> request)
> >>>>>> Resilience against unsupported Charsets in Request
> >>>>>>
> >>>>>> * [WICKET-5470] - Remove 'final' from
> >>>>>> org.apache.wicket.markup.html.
> >>>>>> form.EnumChoiceRenderer#getDisplayValue
> >>>>>>
> >>>>>> * [WICKET-5471] - Store the page if it is known that it will be
> >>>>>> used
> >>>>>> in a following request
> >>>>>>
> >>>>>> * [WICKET-5493] - Disable jar indexing
> >>>>>>
> >>>>>> ** New Feature
> >>>>>>
> >>>>>> * [WICKET-3491] - Introduce IComponentOnConfigureListener
> >>>>>>
> >>>>>> ** Task
> >>>>>>
> >>>>>> * [WICKET-5488] - Promote experimental modules to become stable
> >>>>>>
> >>>>>> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and
> >>>>>> 2.1.0
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
>
>
Re: [VOTE] Release wicket 6.14.0
Posted by Martin Grigorov <mg...@apache.org>.
The issues are listed at https://issues.apache.org/jira/browse/WICKET-5508
I am not 100% sure these improvements are really blockers for the release.
- #sequence and #pageId => AtomicInteger is an improvement
- #locale and #style => AtomicReference is a bug but no one so far
complained about such problem
- #dirty and #sessionInvalidated => volatile is again bug without complains
so far
- #dirty() to change the #dirty boolean flag for bound sessions. Maybe I
should remove this from the suggested patch. Having a temporary session and
calling #setStyle("...") should bind the session, otherwise next request
won't have the style. Same for locale and metadata, and attributes
But #pageid and #sequence should not bind the session because they are
needed even for stateless pages
(WICKET-5473<https://issues.apache.org/jira/browse/WICKET-5473>
)
Martin Grigorov
Wicket Training and Consulting
On Thu, Feb 13, 2014 at 3:33 PM, Michael Haitz <mi...@1und1.de>wrote:
> [X] No, don't release Apache Wicket 6.14.0, because …
>
> of https://issues.apache.org/jira/browse/WICKET-5473 and other related
> issues to Session class.
>
> Am 13.02.2014 um 14:14 schrieb Martin Grigorov <mg...@apache.org>:
>
> > I've tested:
> > - our main app
> > - WicketStuff (mvn clean test)
> > - Wicket-Bootstrap
> > - random Wicket-examples
> >
> > No other issues found
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> >
> >
> > On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
> >
> >> This is fixed.
> >> I still have to check our main application with 6.14.0
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >>
> >>
> >> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
> >>
> >>> I'll move setStatelessHint(false) back to
> RequestCycle.setResponsePage()
> >>>
> >>> Martin Grigorov
> >>> Wicket Training and Consulting
> >>>
> >>>
> >>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier <sv...@meiers.net> wrote:
> >>>
> >>>> Damn, not every page passed to PageProvider is stateless:
> >>>>
> >>>> + if (pageProvider.hasPageInstance())
> >>>> + {
> >>>> + IRequestablePage page =
> >>>> pageProvider.getPageInstance();
> >>>> + if (page instanceof Page)
> >>>> + {
> >>>> + ((Page) page).setStatelessHint(false);
> >>>>
> >>>> :(
> >>>>
> >>>> Sven
> >>>>
> >>>>
> >>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
> >>>>
> >>>>> [ X ] No, don't release Apache Wicket 6.14.0, because submitting
> >>>>> stateless
> >>>>> form binds a session
> >>>>>
> >>>>> Martin Grigorov
> >>>>> Wicket Training and Consulting
> >>>>>
> >>>>>
> >>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
> >>>>> martijn.dashorst@gmail.com> wrote:
> >>>>>
> >>>>> This is a vote to release Apache Wicket 6.14.0
> >>>>>>
> >>>>>> Please download the source distributions found in our staging area
> >>>>>> linked below.
> >>>>>>
> >>>>>> I have included the signatures for both the source archives. This
> vote
> >>>>>> lasts for 72 hours minimum.
> >>>>>>
> >>>>>> [ ] Yes, release Apache Wicket 6.14.0
> >>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
> >>>>>>
> >>>>>> Distributions, changelog, keys and signatures can be found at:
> >>>>>>
> >>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
> >>>>>>
> >>>>>> Staging repository:
> >>>>>>
> >>>>>>
> >>>>>> https://repository.apache.org/content/repositories/
> >>>>>> orgapachewicket-1004/
> >>>>>>
> >>>>>> The binaries are available in the above link, as are a staging
> >>>>>> repository for Maven. Typically the vote is on the source, but
> should
> >>>>>> you find a problem with one of the binaries, please let me know, I
> can
> >>>>>> re-roll them some way or the other.
> >>>>>>
> >>>>>> ============================================================
> >>>>>> ============
> >>>>>>
> >>>>>> The signatures for the source release artefacts:
> >>>>>>
> >>>>>> apache-wicket-6.14.0.zip.asc
> >>>>>>
> >>>>>> -----BEGIN PGP SIGNATURE-----
> >>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> >>>>>> Comment: GPGTools - https://gpgtools.org
> >>>>>>
> >>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
> >>>>>> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
> >>>>>> =4QkG
> >>>>>> -----END PGP SIGNATURE-----
> >>>>>>
> >>>>>> apache-wicket-6.14.0.tar.gz.asc
> >>>>>>
> >>>>>> -----BEGIN PGP SIGNATURE-----
> >>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> >>>>>> Comment: GPGTools - https://gpgtools.org
> >>>>>>
> >>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
> >>>>>> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
> >>>>>> =3DVp
> >>>>>> -----END PGP SIGNATURE-----
> >>>>>>
> >>>>>> ============================================================
> >>>>>> ============
> >>>>>>
> >>>>>> Release Notes - Wicket - Version 6.14.0
> >>>>>>
> >>>>>> ** Bug
> >>>>>>
> >>>>>> * [WICKET-4697] - Autolinking not working as soon as component
> >>>>>> gets
> >>>>>> a wicket:id
> >>>>>>
> >>>>>> * [WICKET-5043] - Page not mounted with
> >>>>>> WebApplication#mountPackage
> >>>>>>
> >>>>>> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page
> >>>>>> names
> >>>>>> in the guides URL links
> >>>>>>
> >>>>>> * [WICKET-5460] - onBeforeRender called too early on stateless
> >>>>>> page
> >>>>>>
> >>>>>> * [WICKET-5462] - Ajax form-component-label repainting fails
> when
> >>>>>> setResponsePage() is used to navigate away from
> >>>>>> the page that has previously failed form
> >>>>>> validaiton
> >>>>>>
> >>>>>> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
> >>>>>> combination with Wizards
> >>>>>>
> >>>>>> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
> >>>>>> ComponentNotFoundException as a side-effect
> >>>>>>
> >>>>>> * [WICKET-5467] - NumberTextField should support "any" as valid
> >>>>>> step
> >>>>>> attribute value
> >>>>>>
> >>>>>> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially
> >>>>>> appends
> >>>>>> "/" after query parameters
> >>>>>>
> >>>>>> * [WICKET-5469] - ModalWindow unload warning always displayed
> >>>>>> (even
> >>>>>> if window is closed)
> >>>>>>
> >>>>>> * [WICKET-5472] - PackageResource#internalGetResourceStream()
> >>>>>> should
> >>>>>> return ProcessingResourceStream only when the
> >>>>>> resource is existing
> >>>>>>
> >>>>>> * [WICKET-5473] - Wicket does not handle non in-memory
> >>>>>> Httpsessions
> >>>>>> correctly
> >>>>>>
> >>>>>> * [WICKET-5477] - CSS class is not applied to <TD> for data
> filter
> >>>>>>
> >>>>>> * [WICKET-5478] - Wrong JavaDoc for WicketTester
> >>>>>>
> >>>>>> * [WICKET-5480] - AutoLabelResolver creates null pointer
> exception
> >>>>>> in 6.13
> >>>>>>
> >>>>>> * [WICKET-5482] - Wicket-guice doesn't support
> @javax.inject.Named
> >>>>>> annotations
> >>>>>>
> >>>>>> * [WICKET-5484] - WebPageRenderer must not render full page in
> >>>>>> Ajax
> >>>>>> requests
> >>>>>>
> >>>>>> * [WICKET-5486] - WebPageRenderer should honor
> >>>>>> RedirectPolicy.ALWAYS_REDIRECT more consistently
> >>>>>>
> >>>>>> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
> >>>>>> undefined on IE8, positions calendar out of
> >>>>>> viewport
> >>>>>>
> >>>>>> * [WICKET-5492] - WebApplication ignores a SecurityException
> when
> >>>>>> reading the configuration type
> >>>>>>
> >>>>>> * [WICKET-5496] - Wrong translation of RangeValidator.minimum
> and
> >>>>>> RangeValidator.maximum
> >>>>>>
> >>>>>> * [WICKET-5497] - NPE in JsonUtils when the value is null
> >>>>>>
> >>>>>> * [WICKET-5499] - Page is not touched during initialization
> >>>>>>
> >>>>>> * [WICKET-5500] - Ignore the path parameters when reading the
> page
> >>>>>> class
> >>>>>>
> >>>>>> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
> >>>>>>
> >>>>>> ** Improvement
> >>>>>>
> >>>>>> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer
> to
> >>>>>> add Child-Components
> >>>>>>
> >>>>>> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior
> >>>>>> without
> >>>>>> updating its hosting component
> >>>>>>
> >>>>>> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest
> >>>>>> request)
> >>>>>> Resilience against unsupported Charsets in Request
> >>>>>>
> >>>>>> * [WICKET-5470] - Remove 'final' from
> >>>>>> org.apache.wicket.markup.html.
> >>>>>> form.EnumChoiceRenderer#getDisplayValue
> >>>>>>
> >>>>>> * [WICKET-5471] - Store the page if it is known that it will be
> >>>>>> used
> >>>>>> in a following request
> >>>>>>
> >>>>>> * [WICKET-5493] - Disable jar indexing
> >>>>>>
> >>>>>> ** New Feature
> >>>>>>
> >>>>>> * [WICKET-3491] - Introduce IComponentOnConfigureListener
> >>>>>>
> >>>>>> ** Task
> >>>>>>
> >>>>>> * [WICKET-5488] - Promote experimental modules to become stable
> >>>>>>
> >>>>>> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and
> >>>>>> 2.1.0
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
>
>
Re: [VOTE] Release wicket 6.14.0
Posted by Michael Haitz <mi...@1und1.de>.
[X] No, don't release Apache Wicket 6.14.0, because …
of https://issues.apache.org/jira/browse/WICKET-5473 and other related issues to Session class.
Am 13.02.2014 um 14:14 schrieb Martin Grigorov <mg...@apache.org>:
> I've tested:
> - our main app
> - WicketStuff (mvn clean test)
> - Wicket-Bootstrap
> - random Wicket-examples
>
> No other issues found
>
> Martin Grigorov
> Wicket Training and Consulting
>
>
> On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov <mg...@apache.org>wrote:
>
>> This is fixed.
>> I still have to check our main application with 6.14.0
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>>
>>
>> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov <mg...@apache.org>wrote:
>>
>>> I'll move setStatelessHint(false) back to RequestCycle.setResponsePage()
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>>
>>>
>>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier <sv...@meiers.net> wrote:
>>>
>>>> Damn, not every page passed to PageProvider is stateless:
>>>>
>>>> + if (pageProvider.hasPageInstance())
>>>> + {
>>>> + IRequestablePage page =
>>>> pageProvider.getPageInstance();
>>>> + if (page instanceof Page)
>>>> + {
>>>> + ((Page) page).setStatelessHint(false);
>>>>
>>>> :(
>>>>
>>>> Sven
>>>>
>>>>
>>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
>>>>
>>>>> [ X ] No, don't release Apache Wicket 6.14.0, because submitting
>>>>> stateless
>>>>> form binds a session
>>>>>
>>>>> Martin Grigorov
>>>>> Wicket Training and Consulting
>>>>>
>>>>>
>>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
>>>>> martijn.dashorst@gmail.com> wrote:
>>>>>
>>>>> This is a vote to release Apache Wicket 6.14.0
>>>>>>
>>>>>> Please download the source distributions found in our staging area
>>>>>> linked below.
>>>>>>
>>>>>> I have included the signatures for both the source archives. This vote
>>>>>> lasts for 72 hours minimum.
>>>>>>
>>>>>> [ ] Yes, release Apache Wicket 6.14.0
>>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
>>>>>>
>>>>>> Distributions, changelog, keys and signatures can be found at:
>>>>>>
>>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
>>>>>>
>>>>>> Staging repository:
>>>>>>
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/
>>>>>> orgapachewicket-1004/
>>>>>>
>>>>>> The binaries are available in the above link, as are a staging
>>>>>> repository for Maven. Typically the vote is on the source, but should
>>>>>> you find a problem with one of the binaries, please let me know, I can
>>>>>> re-roll them some way or the other.
>>>>>>
>>>>>> ============================================================
>>>>>> ============
>>>>>>
>>>>>> The signatures for the source release artefacts:
>>>>>>
>>>>>> apache-wicket-6.14.0.zip.asc
>>>>>>
>>>>>> -----BEGIN PGP SIGNATURE-----
>>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>>>>> Comment: GPGTools - https://gpgtools.org
>>>>>>
>>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
>>>>>> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
>>>>>> =4QkG
>>>>>> -----END PGP SIGNATURE-----
>>>>>>
>>>>>> apache-wicket-6.14.0.tar.gz.asc
>>>>>>
>>>>>> -----BEGIN PGP SIGNATURE-----
>>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>>>>> Comment: GPGTools - https://gpgtools.org
>>>>>>
>>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
>>>>>> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
>>>>>> =3DVp
>>>>>> -----END PGP SIGNATURE-----
>>>>>>
>>>>>> ============================================================
>>>>>> ============
>>>>>>
>>>>>> Release Notes - Wicket - Version 6.14.0
>>>>>>
>>>>>> ** Bug
>>>>>>
>>>>>> * [WICKET-4697] - Autolinking not working as soon as component
>>>>>> gets
>>>>>> a wicket:id
>>>>>>
>>>>>> * [WICKET-5043] - Page not mounted with
>>>>>> WebApplication#mountPackage
>>>>>>
>>>>>> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page
>>>>>> names
>>>>>> in the guides URL links
>>>>>>
>>>>>> * [WICKET-5460] - onBeforeRender called too early on stateless
>>>>>> page
>>>>>>
>>>>>> * [WICKET-5462] - Ajax form-component-label repainting fails when
>>>>>> setResponsePage() is used to navigate away from
>>>>>> the page that has previously failed form
>>>>>> validaiton
>>>>>>
>>>>>> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
>>>>>> combination with Wizards
>>>>>>
>>>>>> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
>>>>>> ComponentNotFoundException as a side-effect
>>>>>>
>>>>>> * [WICKET-5467] - NumberTextField should support "any" as valid
>>>>>> step
>>>>>> attribute value
>>>>>>
>>>>>> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially
>>>>>> appends
>>>>>> "/" after query parameters
>>>>>>
>>>>>> * [WICKET-5469] - ModalWindow unload warning always displayed
>>>>>> (even
>>>>>> if window is closed)
>>>>>>
>>>>>> * [WICKET-5472] - PackageResource#internalGetResourceStream()
>>>>>> should
>>>>>> return ProcessingResourceStream only when the
>>>>>> resource is existing
>>>>>>
>>>>>> * [WICKET-5473] - Wicket does not handle non in-memory
>>>>>> Httpsessions
>>>>>> correctly
>>>>>>
>>>>>> * [WICKET-5477] - CSS class is not applied to <TD> for data filter
>>>>>>
>>>>>> * [WICKET-5478] - Wrong JavaDoc for WicketTester
>>>>>>
>>>>>> * [WICKET-5480] - AutoLabelResolver creates null pointer exception
>>>>>> in 6.13
>>>>>>
>>>>>> * [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
>>>>>> annotations
>>>>>>
>>>>>> * [WICKET-5484] - WebPageRenderer must not render full page in
>>>>>> Ajax
>>>>>> requests
>>>>>>
>>>>>> * [WICKET-5486] - WebPageRenderer should honor
>>>>>> RedirectPolicy.ALWAYS_REDIRECT more consistently
>>>>>>
>>>>>> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
>>>>>> undefined on IE8, positions calendar out of
>>>>>> viewport
>>>>>>
>>>>>> * [WICKET-5492] - WebApplication ignores a SecurityException when
>>>>>> reading the configuration type
>>>>>>
>>>>>> * [WICKET-5496] - Wrong translation of RangeValidator.minimum and
>>>>>> RangeValidator.maximum
>>>>>>
>>>>>> * [WICKET-5497] - NPE in JsonUtils when the value is null
>>>>>>
>>>>>> * [WICKET-5499] - Page is not touched during initialization
>>>>>>
>>>>>> * [WICKET-5500] - Ignore the path parameters when reading the page
>>>>>> class
>>>>>>
>>>>>> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
>>>>>>
>>>>>> ** Improvement
>>>>>>
>>>>>> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
>>>>>> add Child-Components
>>>>>>
>>>>>> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior
>>>>>> without
>>>>>> updating its hosting component
>>>>>>
>>>>>> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest
>>>>>> request)
>>>>>> Resilience against unsupported Charsets in Request
>>>>>>
>>>>>> * [WICKET-5470] - Remove 'final' from
>>>>>> org.apache.wicket.markup.html.
>>>>>> form.EnumChoiceRenderer#getDisplayValue
>>>>>>
>>>>>> * [WICKET-5471] - Store the page if it is known that it will be
>>>>>> used
>>>>>> in a following request
>>>>>>
>>>>>> * [WICKET-5493] - Disable jar indexing
>>>>>>
>>>>>> ** New Feature
>>>>>>
>>>>>> * [WICKET-3491] - Introduce IComponentOnConfigureListener
>>>>>>
>>>>>> ** Task
>>>>>>
>>>>>> * [WICKET-5488] - Promote experimental modules to become stable
>>>>>>
>>>>>> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and
>>>>>> 2.1.0
>>>>>>
>>>>>>
>>>>
>>>
>>
Re: [VOTE] Release wicket 6.14.0
Posted by Martin Grigorov <mg...@apache.org>.
I've tested:
- our main app
- WicketStuff (mvn clean test)
- Wicket-Bootstrap
- random Wicket-examples
No other issues found
Martin Grigorov
Wicket Training and Consulting
On Wed, Feb 12, 2014 at 2:57 PM, Martin Grigorov <mg...@apache.org>wrote:
> This is fixed.
> I still have to check our main application with 6.14.0
>
> Martin Grigorov
> Wicket Training and Consulting
>
>
> On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov <mg...@apache.org>wrote:
>
>> I'll move setStatelessHint(false) back to RequestCycle.setResponsePage()
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>>
>>
>> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier <sv...@meiers.net> wrote:
>>
>>> Damn, not every page passed to PageProvider is stateless:
>>>
>>> + if (pageProvider.hasPageInstance())
>>> + {
>>> + IRequestablePage page =
>>> pageProvider.getPageInstance();
>>> + if (page instanceof Page)
>>> + {
>>> + ((Page) page).setStatelessHint(false);
>>>
>>> :(
>>>
>>> Sven
>>>
>>>
>>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
>>>
>>>> [ X ] No, don't release Apache Wicket 6.14.0, because submitting
>>>> stateless
>>>> form binds a session
>>>>
>>>> Martin Grigorov
>>>> Wicket Training and Consulting
>>>>
>>>>
>>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
>>>> martijn.dashorst@gmail.com> wrote:
>>>>
>>>> This is a vote to release Apache Wicket 6.14.0
>>>>>
>>>>> Please download the source distributions found in our staging area
>>>>> linked below.
>>>>>
>>>>> I have included the signatures for both the source archives. This vote
>>>>> lasts for 72 hours minimum.
>>>>>
>>>>> [ ] Yes, release Apache Wicket 6.14.0
>>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
>>>>>
>>>>> Distributions, changelog, keys and signatures can be found at:
>>>>>
>>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
>>>>>
>>>>> Staging repository:
>>>>>
>>>>>
>>>>> https://repository.apache.org/content/repositories/
>>>>> orgapachewicket-1004/
>>>>>
>>>>> The binaries are available in the above link, as are a staging
>>>>> repository for Maven. Typically the vote is on the source, but should
>>>>> you find a problem with one of the binaries, please let me know, I can
>>>>> re-roll them some way or the other.
>>>>>
>>>>> ============================================================
>>>>> ============
>>>>>
>>>>> The signatures for the source release artefacts:
>>>>>
>>>>> apache-wicket-6.14.0.zip.asc
>>>>>
>>>>> -----BEGIN PGP SIGNATURE-----
>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>>>> Comment: GPGTools - https://gpgtools.org
>>>>>
>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
>>>>> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
>>>>> =4QkG
>>>>> -----END PGP SIGNATURE-----
>>>>>
>>>>> apache-wicket-6.14.0.tar.gz.asc
>>>>>
>>>>> -----BEGIN PGP SIGNATURE-----
>>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>>>> Comment: GPGTools - https://gpgtools.org
>>>>>
>>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
>>>>> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
>>>>> =3DVp
>>>>> -----END PGP SIGNATURE-----
>>>>>
>>>>> ============================================================
>>>>> ============
>>>>>
>>>>> Release Notes - Wicket - Version 6.14.0
>>>>>
>>>>> ** Bug
>>>>>
>>>>> * [WICKET-4697] - Autolinking not working as soon as component
>>>>> gets
>>>>> a wicket:id
>>>>>
>>>>> * [WICKET-5043] - Page not mounted with
>>>>> WebApplication#mountPackage
>>>>>
>>>>> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page
>>>>> names
>>>>> in the guides URL links
>>>>>
>>>>> * [WICKET-5460] - onBeforeRender called too early on stateless
>>>>> page
>>>>>
>>>>> * [WICKET-5462] - Ajax form-component-label repainting fails when
>>>>> setResponsePage() is used to navigate away from
>>>>> the page that has previously failed form
>>>>> validaiton
>>>>>
>>>>> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
>>>>> combination with Wizards
>>>>>
>>>>> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
>>>>> ComponentNotFoundException as a side-effect
>>>>>
>>>>> * [WICKET-5467] - NumberTextField should support "any" as valid
>>>>> step
>>>>> attribute value
>>>>>
>>>>> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially
>>>>> appends
>>>>> "/" after query parameters
>>>>>
>>>>> * [WICKET-5469] - ModalWindow unload warning always displayed
>>>>> (even
>>>>> if window is closed)
>>>>>
>>>>> * [WICKET-5472] - PackageResource#internalGetResourceStream()
>>>>> should
>>>>> return ProcessingResourceStream only when the
>>>>> resource is existing
>>>>>
>>>>> * [WICKET-5473] - Wicket does not handle non in-memory
>>>>> Httpsessions
>>>>> correctly
>>>>>
>>>>> * [WICKET-5477] - CSS class is not applied to <TD> for data filter
>>>>>
>>>>> * [WICKET-5478] - Wrong JavaDoc for WicketTester
>>>>>
>>>>> * [WICKET-5480] - AutoLabelResolver creates null pointer exception
>>>>> in 6.13
>>>>>
>>>>> * [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
>>>>> annotations
>>>>>
>>>>> * [WICKET-5484] - WebPageRenderer must not render full page in
>>>>> Ajax
>>>>> requests
>>>>>
>>>>> * [WICKET-5486] - WebPageRenderer should honor
>>>>> RedirectPolicy.ALWAYS_REDIRECT more consistently
>>>>>
>>>>> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
>>>>> undefined on IE8, positions calendar out of
>>>>> viewport
>>>>>
>>>>> * [WICKET-5492] - WebApplication ignores a SecurityException when
>>>>> reading the configuration type
>>>>>
>>>>> * [WICKET-5496] - Wrong translation of RangeValidator.minimum and
>>>>> RangeValidator.maximum
>>>>>
>>>>> * [WICKET-5497] - NPE in JsonUtils when the value is null
>>>>>
>>>>> * [WICKET-5499] - Page is not touched during initialization
>>>>>
>>>>> * [WICKET-5500] - Ignore the path parameters when reading the page
>>>>> class
>>>>>
>>>>> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
>>>>>
>>>>> ** Improvement
>>>>>
>>>>> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
>>>>> add Child-Components
>>>>>
>>>>> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior
>>>>> without
>>>>> updating its hosting component
>>>>>
>>>>> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest
>>>>> request)
>>>>> Resilience against unsupported Charsets in Request
>>>>>
>>>>> * [WICKET-5470] - Remove 'final' from
>>>>> org.apache.wicket.markup.html.
>>>>> form.EnumChoiceRenderer#getDisplayValue
>>>>>
>>>>> * [WICKET-5471] - Store the page if it is known that it will be
>>>>> used
>>>>> in a following request
>>>>>
>>>>> * [WICKET-5493] - Disable jar indexing
>>>>>
>>>>> ** New Feature
>>>>>
>>>>> * [WICKET-3491] - Introduce IComponentOnConfigureListener
>>>>>
>>>>> ** Task
>>>>>
>>>>> * [WICKET-5488] - Promote experimental modules to become stable
>>>>>
>>>>> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and
>>>>> 2.1.0
>>>>>
>>>>>
>>>
>>
>
Re: [VOTE] Release wicket 6.14.0
Posted by Martin Grigorov <mg...@apache.org>.
This is fixed.
I still have to check our main application with 6.14.0
Martin Grigorov
Wicket Training and Consulting
On Wed, Feb 12, 2014 at 2:47 PM, Martin Grigorov <mg...@apache.org>wrote:
> I'll move setStatelessHint(false) back to RequestCycle.setResponsePage()
>
> Martin Grigorov
> Wicket Training and Consulting
>
>
> On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier <sv...@meiers.net> wrote:
>
>> Damn, not every page passed to PageProvider is stateless:
>>
>> + if (pageProvider.hasPageInstance())
>> + {
>> + IRequestablePage page =
>> pageProvider.getPageInstance();
>> + if (page instanceof Page)
>> + {
>> + ((Page) page).setStatelessHint(false);
>>
>> :(
>>
>> Sven
>>
>>
>> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
>>
>>> [ X ] No, don't release Apache Wicket 6.14.0, because submitting
>>> stateless
>>> form binds a session
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>>
>>>
>>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
>>> martijn.dashorst@gmail.com> wrote:
>>>
>>> This is a vote to release Apache Wicket 6.14.0
>>>>
>>>> Please download the source distributions found in our staging area
>>>> linked below.
>>>>
>>>> I have included the signatures for both the source archives. This vote
>>>> lasts for 72 hours minimum.
>>>>
>>>> [ ] Yes, release Apache Wicket 6.14.0
>>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
>>>>
>>>> Distributions, changelog, keys and signatures can be found at:
>>>>
>>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
>>>>
>>>> Staging repository:
>>>>
>>>>
>>>> https://repository.apache.org/content/repositories/
>>>> orgapachewicket-1004/
>>>>
>>>> The binaries are available in the above link, as are a staging
>>>> repository for Maven. Typically the vote is on the source, but should
>>>> you find a problem with one of the binaries, please let me know, I can
>>>> re-roll them some way or the other.
>>>>
>>>> ============================================================
>>>> ============
>>>>
>>>> The signatures for the source release artefacts:
>>>>
>>>> apache-wicket-6.14.0.zip.asc
>>>>
>>>> -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>>> Comment: GPGTools - https://gpgtools.org
>>>>
>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
>>>> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
>>>> =4QkG
>>>> -----END PGP SIGNATURE-----
>>>>
>>>> apache-wicket-6.14.0.tar.gz.asc
>>>>
>>>> -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>>> Comment: GPGTools - https://gpgtools.org
>>>>
>>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
>>>> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
>>>> =3DVp
>>>> -----END PGP SIGNATURE-----
>>>>
>>>> ============================================================
>>>> ============
>>>>
>>>> Release Notes - Wicket - Version 6.14.0
>>>>
>>>> ** Bug
>>>>
>>>> * [WICKET-4697] - Autolinking not working as soon as component gets
>>>> a wicket:id
>>>>
>>>> * [WICKET-5043] - Page not mounted with WebApplication#mountPackage
>>>>
>>>> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page
>>>> names
>>>> in the guides URL links
>>>>
>>>> * [WICKET-5460] - onBeforeRender called too early on stateless page
>>>>
>>>> * [WICKET-5462] - Ajax form-component-label repainting fails when
>>>> setResponsePage() is used to navigate away from
>>>> the page that has previously failed form
>>>> validaiton
>>>>
>>>> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
>>>> combination with Wizards
>>>>
>>>> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
>>>> ComponentNotFoundException as a side-effect
>>>>
>>>> * [WICKET-5467] - NumberTextField should support "any" as valid
>>>> step
>>>> attribute value
>>>>
>>>> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially appends
>>>> "/" after query parameters
>>>>
>>>> * [WICKET-5469] - ModalWindow unload warning always displayed (even
>>>> if window is closed)
>>>>
>>>> * [WICKET-5472] - PackageResource#internalGetResourceStream()
>>>> should
>>>> return ProcessingResourceStream only when the
>>>> resource is existing
>>>>
>>>> * [WICKET-5473] - Wicket does not handle non in-memory Httpsessions
>>>> correctly
>>>>
>>>> * [WICKET-5477] - CSS class is not applied to <TD> for data filter
>>>>
>>>> * [WICKET-5478] - Wrong JavaDoc for WicketTester
>>>>
>>>> * [WICKET-5480] - AutoLabelResolver creates null pointer exception
>>>> in 6.13
>>>>
>>>> * [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
>>>> annotations
>>>>
>>>> * [WICKET-5484] - WebPageRenderer must not render full page in Ajax
>>>> requests
>>>>
>>>> * [WICKET-5486] - WebPageRenderer should honor
>>>> RedirectPolicy.ALWAYS_REDIRECT more consistently
>>>>
>>>> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
>>>> undefined on IE8, positions calendar out of
>>>> viewport
>>>>
>>>> * [WICKET-5492] - WebApplication ignores a SecurityException when
>>>> reading the configuration type
>>>>
>>>> * [WICKET-5496] - Wrong translation of RangeValidator.minimum and
>>>> RangeValidator.maximum
>>>>
>>>> * [WICKET-5497] - NPE in JsonUtils when the value is null
>>>>
>>>> * [WICKET-5499] - Page is not touched during initialization
>>>>
>>>> * [WICKET-5500] - Ignore the path parameters when reading the page
>>>> class
>>>>
>>>> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
>>>>
>>>> ** Improvement
>>>>
>>>> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
>>>> add Child-Components
>>>>
>>>> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior
>>>> without
>>>> updating its hosting component
>>>>
>>>> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest
>>>> request)
>>>> Resilience against unsupported Charsets in Request
>>>>
>>>> * [WICKET-5470] - Remove 'final' from
>>>> org.apache.wicket.markup.html.
>>>> form.EnumChoiceRenderer#getDisplayValue
>>>>
>>>> * [WICKET-5471] - Store the page if it is known that it will be
>>>> used
>>>> in a following request
>>>>
>>>> * [WICKET-5493] - Disable jar indexing
>>>>
>>>> ** New Feature
>>>>
>>>> * [WICKET-3491] - Introduce IComponentOnConfigureListener
>>>>
>>>> ** Task
>>>>
>>>> * [WICKET-5488] - Promote experimental modules to become stable
>>>>
>>>> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and
>>>> 2.1.0
>>>>
>>>>
>>
>
Re: [VOTE] Release wicket 6.14.0
Posted by Martin Grigorov <mg...@apache.org>.
I'll move setStatelessHint(false) back to RequestCycle.setResponsePage()
Martin Grigorov
Wicket Training and Consulting
On Wed, Feb 12, 2014 at 2:22 PM, Sven Meier <sv...@meiers.net> wrote:
> Damn, not every page passed to PageProvider is stateless:
>
> + if (pageProvider.hasPageInstance())
> + {
> + IRequestablePage page =
> pageProvider.getPageInstance();
> + if (page instanceof Page)
> + {
> + ((Page) page).setStatelessHint(false);
>
> :(
>
> Sven
>
>
> On 02/12/2014 02:10 PM, Martin Grigorov wrote:
>
>> [ X ] No, don't release Apache Wicket 6.14.0, because submitting stateless
>> form binds a session
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>>
>>
>> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
>> martijn.dashorst@gmail.com> wrote:
>>
>> This is a vote to release Apache Wicket 6.14.0
>>>
>>> Please download the source distributions found in our staging area
>>> linked below.
>>>
>>> I have included the signatures for both the source archives. This vote
>>> lasts for 72 hours minimum.
>>>
>>> [ ] Yes, release Apache Wicket 6.14.0
>>> [ ] No, don't release Apache Wicket 6.14.0, because ...
>>>
>>> Distributions, changelog, keys and signatures can be found at:
>>>
>>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
>>>
>>> Staging repository:
>>>
>>>
>>> https://repository.apache.org/content/repositories/orgapachewicket-1004/
>>>
>>> The binaries are available in the above link, as are a staging
>>> repository for Maven. Typically the vote is on the source, but should
>>> you find a problem with one of the binaries, please let me know, I can
>>> re-roll them some way or the other.
>>>
>>> ========================================================================
>>>
>>> The signatures for the source release artefacts:
>>>
>>> apache-wicket-6.14.0.zip.asc
>>>
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>> Comment: GPGTools - https://gpgtools.org
>>>
>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
>>> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
>>> =4QkG
>>> -----END PGP SIGNATURE-----
>>>
>>> apache-wicket-6.14.0.tar.gz.asc
>>>
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>>> Comment: GPGTools - https://gpgtools.org
>>>
>>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
>>> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
>>> =3DVp
>>> -----END PGP SIGNATURE-----
>>>
>>> ========================================================================
>>>
>>> Release Notes - Wicket - Version 6.14.0
>>>
>>> ** Bug
>>>
>>> * [WICKET-4697] - Autolinking not working as soon as component gets
>>> a wicket:id
>>>
>>> * [WICKET-5043] - Page not mounted with WebApplication#mountPackage
>>>
>>> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page names
>>> in the guides URL links
>>>
>>> * [WICKET-5460] - onBeforeRender called too early on stateless page
>>>
>>> * [WICKET-5462] - Ajax form-component-label repainting fails when
>>> setResponsePage() is used to navigate away from
>>> the page that has previously failed form
>>> validaiton
>>>
>>> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
>>> combination with Wizards
>>>
>>> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
>>> ComponentNotFoundException as a side-effect
>>>
>>> * [WICKET-5467] - NumberTextField should support "any" as valid step
>>> attribute value
>>>
>>> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially appends
>>> "/" after query parameters
>>>
>>> * [WICKET-5469] - ModalWindow unload warning always displayed (even
>>> if window is closed)
>>>
>>> * [WICKET-5472] - PackageResource#internalGetResourceStream()
>>> should
>>> return ProcessingResourceStream only when the
>>> resource is existing
>>>
>>> * [WICKET-5473] - Wicket does not handle non in-memory Httpsessions
>>> correctly
>>>
>>> * [WICKET-5477] - CSS class is not applied to <TD> for data filter
>>>
>>> * [WICKET-5478] - Wrong JavaDoc for WicketTester
>>>
>>> * [WICKET-5480] - AutoLabelResolver creates null pointer exception
>>> in 6.13
>>>
>>> * [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
>>> annotations
>>>
>>> * [WICKET-5484] - WebPageRenderer must not render full page in Ajax
>>> requests
>>>
>>> * [WICKET-5486] - WebPageRenderer should honor
>>> RedirectPolicy.ALWAYS_REDIRECT more consistently
>>>
>>> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
>>> undefined on IE8, positions calendar out of
>>> viewport
>>>
>>> * [WICKET-5492] - WebApplication ignores a SecurityException when
>>> reading the configuration type
>>>
>>> * [WICKET-5496] - Wrong translation of RangeValidator.minimum and
>>> RangeValidator.maximum
>>>
>>> * [WICKET-5497] - NPE in JsonUtils when the value is null
>>>
>>> * [WICKET-5499] - Page is not touched during initialization
>>>
>>> * [WICKET-5500] - Ignore the path parameters when reading the page
>>> class
>>>
>>> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
>>>
>>> ** Improvement
>>>
>>> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
>>> add Child-Components
>>>
>>> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior without
>>> updating its hosting component
>>>
>>> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest
>>> request)
>>> Resilience against unsupported Charsets in Request
>>>
>>> * [WICKET-5470] - Remove 'final' from org.apache.wicket.markup.html.
>>> form.EnumChoiceRenderer#getDisplayValue
>>>
>>> * [WICKET-5471] - Store the page if it is known that it will be used
>>> in a following request
>>>
>>> * [WICKET-5493] - Disable jar indexing
>>>
>>> ** New Feature
>>>
>>> * [WICKET-3491] - Introduce IComponentOnConfigureListener
>>>
>>> ** Task
>>>
>>> * [WICKET-5488] - Promote experimental modules to become stable
>>>
>>> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and 2.1.0
>>>
>>>
>
Re: [VOTE] Release wicket 6.14.0
Posted by Sven Meier <sv...@meiers.net>.
Damn, not every page passed to PageProvider is stateless:
+ if (pageProvider.hasPageInstance())
+ {
+ IRequestablePage page =
pageProvider.getPageInstance();
+ if (page instanceof Page)
+ {
+ ((Page) page).setStatelessHint(false);
:(
Sven
On 02/12/2014 02:10 PM, Martin Grigorov wrote:
> [ X ] No, don't release Apache Wicket 6.14.0, because submitting stateless
> form binds a session
>
> Martin Grigorov
> Wicket Training and Consulting
>
>
> On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
> martijn.dashorst@gmail.com> wrote:
>
>> This is a vote to release Apache Wicket 6.14.0
>>
>> Please download the source distributions found in our staging area
>> linked below.
>>
>> I have included the signatures for both the source archives. This vote
>> lasts for 72 hours minimum.
>>
>> [ ] Yes, release Apache Wicket 6.14.0
>> [ ] No, don't release Apache Wicket 6.14.0, because ...
>>
>> Distributions, changelog, keys and signatures can be found at:
>>
>> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
>>
>> Staging repository:
>>
>>
>> https://repository.apache.org/content/repositories/orgapachewicket-1004/
>>
>> The binaries are available in the above link, as are a staging
>> repository for Maven. Typically the vote is on the source, but should
>> you find a problem with one of the binaries, please let me know, I can
>> re-roll them some way or the other.
>>
>> ========================================================================
>>
>> The signatures for the source release artefacts:
>>
>> apache-wicket-6.14.0.zip.asc
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>> Comment: GPGTools - https://gpgtools.org
>>
>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
>> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
>> =4QkG
>> -----END PGP SIGNATURE-----
>>
>> apache-wicket-6.14.0.tar.gz.asc
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>> Comment: GPGTools - https://gpgtools.org
>>
>> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
>> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
>> =3DVp
>> -----END PGP SIGNATURE-----
>>
>> ========================================================================
>>
>> Release Notes - Wicket - Version 6.14.0
>>
>> ** Bug
>>
>> * [WICKET-4697] - Autolinking not working as soon as component gets
>> a wicket:id
>>
>> * [WICKET-5043] - Page not mounted with WebApplication#mountPackage
>>
>> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page names
>> in the guides URL links
>>
>> * [WICKET-5460] - onBeforeRender called too early on stateless page
>>
>> * [WICKET-5462] - Ajax form-component-label repainting fails when
>> setResponsePage() is used to navigate away from
>> the page that has previously failed form
>> validaiton
>>
>> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
>> combination with Wizards
>>
>> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
>> ComponentNotFoundException as a side-effect
>>
>> * [WICKET-5467] - NumberTextField should support "any" as valid step
>> attribute value
>>
>> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially appends
>> "/" after query parameters
>>
>> * [WICKET-5469] - ModalWindow unload warning always displayed (even
>> if window is closed)
>>
>> * [WICKET-5472] - PackageResource#internalGetResourceStream() should
>> return ProcessingResourceStream only when the
>> resource is existing
>>
>> * [WICKET-5473] - Wicket does not handle non in-memory Httpsessions
>> correctly
>>
>> * [WICKET-5477] - CSS class is not applied to <TD> for data filter
>>
>> * [WICKET-5478] - Wrong JavaDoc for WicketTester
>>
>> * [WICKET-5480] - AutoLabelResolver creates null pointer exception
>> in 6.13
>>
>> * [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
>> annotations
>>
>> * [WICKET-5484] - WebPageRenderer must not render full page in Ajax
>> requests
>>
>> * [WICKET-5486] - WebPageRenderer should honor
>> RedirectPolicy.ALWAYS_REDIRECT more consistently
>>
>> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
>> undefined on IE8, positions calendar out of
>> viewport
>>
>> * [WICKET-5492] - WebApplication ignores a SecurityException when
>> reading the configuration type
>>
>> * [WICKET-5496] - Wrong translation of RangeValidator.minimum and
>> RangeValidator.maximum
>>
>> * [WICKET-5497] - NPE in JsonUtils when the value is null
>>
>> * [WICKET-5499] - Page is not touched during initialization
>>
>> * [WICKET-5500] - Ignore the path parameters when reading the page
>> class
>>
>> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
>>
>> ** Improvement
>>
>> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
>> add Child-Components
>>
>> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior without
>> updating its hosting component
>>
>> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest request)
>> Resilience against unsupported Charsets in Request
>>
>> * [WICKET-5470] - Remove 'final' from org.apache.wicket.markup.html.
>> form.EnumChoiceRenderer#getDisplayValue
>>
>> * [WICKET-5471] - Store the page if it is known that it will be used
>> in a following request
>>
>> * [WICKET-5493] - Disable jar indexing
>>
>> ** New Feature
>>
>> * [WICKET-3491] - Introduce IComponentOnConfigureListener
>>
>> ** Task
>>
>> * [WICKET-5488] - Promote experimental modules to become stable
>>
>> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and 2.1.0
>>
Re: [VOTE] Release wicket 6.14.0
Posted by Martin Grigorov <mg...@apache.org>.
[ X ] No, don't release Apache Wicket 6.14.0, because submitting stateless
form binds a session
Martin Grigorov
Wicket Training and Consulting
On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
martijn.dashorst@gmail.com> wrote:
> This is a vote to release Apache Wicket 6.14.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 6.14.0
> [ ] No, don't release Apache Wicket 6.14.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
>
> Staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapachewicket-1004/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> ========================================================================
>
> The signatures for the source release artefacts:
>
> apache-wicket-6.14.0.zip.asc
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> Comment: GPGTools - https://gpgtools.org
>
> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
> =4QkG
> -----END PGP SIGNATURE-----
>
> apache-wicket-6.14.0.tar.gz.asc
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> Comment: GPGTools - https://gpgtools.org
>
> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
> =3DVp
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
> Release Notes - Wicket - Version 6.14.0
>
> ** Bug
>
> * [WICKET-4697] - Autolinking not working as soon as component gets
> a wicket:id
>
> * [WICKET-5043] - Page not mounted with WebApplication#mountPackage
>
> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page names
> in the guides URL links
>
> * [WICKET-5460] - onBeforeRender called too early on stateless page
>
> * [WICKET-5462] - Ajax form-component-label repainting fails when
> setResponsePage() is used to navigate away from
> the page that has previously failed form
> validaiton
>
> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
> combination with Wizards
>
> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
> ComponentNotFoundException as a side-effect
>
> * [WICKET-5467] - NumberTextField should support "any" as valid step
> attribute value
>
> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially appends
> "/" after query parameters
>
> * [WICKET-5469] - ModalWindow unload warning always displayed (even
> if window is closed)
>
> * [WICKET-5472] - PackageResource#internalGetResourceStream() should
> return ProcessingResourceStream only when the
> resource is existing
>
> * [WICKET-5473] - Wicket does not handle non in-memory Httpsessions
> correctly
>
> * [WICKET-5477] - CSS class is not applied to <TD> for data filter
>
> * [WICKET-5478] - Wrong JavaDoc for WicketTester
>
> * [WICKET-5480] - AutoLabelResolver creates null pointer exception
> in 6.13
>
> * [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
> annotations
>
> * [WICKET-5484] - WebPageRenderer must not render full page in Ajax
> requests
>
> * [WICKET-5486] - WebPageRenderer should honor
> RedirectPolicy.ALWAYS_REDIRECT more consistently
>
> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
> undefined on IE8, positions calendar out of
> viewport
>
> * [WICKET-5492] - WebApplication ignores a SecurityException when
> reading the configuration type
>
> * [WICKET-5496] - Wrong translation of RangeValidator.minimum and
> RangeValidator.maximum
>
> * [WICKET-5497] - NPE in JsonUtils when the value is null
>
> * [WICKET-5499] - Page is not touched during initialization
>
> * [WICKET-5500] - Ignore the path parameters when reading the page
> class
>
> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
>
> ** Improvement
>
> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
> add Child-Components
>
> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior without
> updating its hosting component
>
> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest request)
> Resilience against unsupported Charsets in Request
>
> * [WICKET-5470] - Remove 'final' from org.apache.wicket.markup.html.
> form.EnumChoiceRenderer#getDisplayValue
>
> * [WICKET-5471] - Store the page if it is known that it will be used
> in a following request
>
> * [WICKET-5493] - Disable jar indexing
>
> ** New Feature
>
> * [WICKET-3491] - Introduce IComponentOnConfigureListener
>
> ** Task
>
> * [WICKET-5488] - Promote experimental modules to become stable
>
> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and 2.1.0
>
Re: [VOTE] Release wicket 6.14.0
Posted by Jonas <ba...@gmail.com>.
[X] Yes, release Apache Wicket 6.14.0
(non binding)
Tested our main webapp, plus verified the jira tracks I've filed
(WICKET-5469, WICKET-5493)
cheers,
Jonas
On Wed, Feb 12, 2014 at 9:51 AM, Martijn Dashorst <
martijn.dashorst@gmail.com> wrote:
> This is a vote to release Apache Wicket 6.14.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 6.14.0
> [ ] No, don't release Apache Wicket 6.14.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/6.14.0
>
> Staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapachewicket-1004/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> ========================================================================
>
> The signatures for the source release artefacts:
>
> apache-wicket-6.14.0.zip.asc
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> Comment: GPGTools - https://gpgtools.org
>
> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVtWgCfU65+p9WqfeRJSvCGHNZRrCX8
> zx0An3SsVk+/mxKCLYQYgbq23RRZMpFE
> =4QkG
> -----END PGP SIGNATURE-----
>
> apache-wicket-6.14.0.tar.gz.asc
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
> Comment: GPGTools - https://gpgtools.org
>
> iEYEABECAAYFAlL6qx8ACgkQJBX8W/xy/UVnPQCggvOBE7HT/YeryU+6V/PgwmEM
> KCkAoIBVa6vkeRtz9ZsesunI6+eHgiYc
> =3DVp
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
> Release Notes - Wicket - Version 6.14.0
>
> ** Bug
>
> * [WICKET-4697] - Autolinking not working as soon as component gets
> a wicket:id
>
> * [WICKET-5043] - Page not mounted with WebApplication#mountPackage
>
> * [WICKET-5449] - Missing chapter 2 is causing off-by-one page names
> in the guides URL links
>
> * [WICKET-5460] - onBeforeRender called too early on stateless page
>
> * [WICKET-5462] - Ajax form-component-label repainting fails when
> setResponsePage() is used to navigate away from
> the page that has previously failed form
> validaiton
>
> * [WICKET-5464] - AbstractAjaxTimerBehavior does not work in
> combination with Wizards
>
> * [WICKET-5466] - ListenerInterfaceRequestHandler#respond throws
> ComponentNotFoundException as a side-effect
>
> * [WICKET-5467] - NumberTextField should support "any" as valid step
> attribute value
>
> * [WICKET-5468] - UrlRenderer#renderRelativeUrl potentially appends
> "/" after query parameters
>
> * [WICKET-5469] - ModalWindow unload warning always displayed (even
> if window is closed)
>
> * [WICKET-5472] - PackageResource#internalGetResourceStream() should
> return ProcessingResourceStream only when the
> resource is existing
>
> * [WICKET-5473] - Wicket does not handle non in-memory Httpsessions
> correctly
>
> * [WICKET-5477] - CSS class is not applied to <TD> for data filter
>
> * [WICKET-5478] - Wrong JavaDoc for WicketTester
>
> * [WICKET-5480] - AutoLabelResolver creates null pointer exception
> in 6.13
>
> * [WICKET-5482] - Wicket-guice doesn't support @javax.inject.Named
> annotations
>
> * [WICKET-5484] - WebPageRenderer must not render full page in Ajax
> requests
>
> * [WICKET-5486] - WebPageRenderer should honor
> RedirectPolicy.ALWAYS_REDIRECT more consistently
>
> * [WICKET-5491] - Wicket.DateTime.getViewportHeight() returning
> undefined on IE8, positions calendar out of
> viewport
>
> * [WICKET-5492] - WebApplication ignores a SecurityException when
> reading the configuration type
>
> * [WICKET-5496] - Wrong translation of RangeValidator.minimum and
> RangeValidator.maximum
>
> * [WICKET-5497] - NPE in JsonUtils when the value is null
>
> * [WICKET-5499] - Page is not touched during initialization
>
> * [WICKET-5500] - Ignore the path parameters when reading the page
> class
>
> * [WICKET-5502] - Patch FileUploadBase to fix CVE-2014-0050
>
> ** Improvement
>
> * [WICKET-5288] - Allow <script>-Tags act as WebMarkUpContainer to
> add Child-Components
>
> * [WICKET-5439] - Allow restarting AbstractAjaxTimerBehavior without
> updating its hosting component
>
> * [WICKET-5463] - RequestUtil.getCharset(HttpServletRequest request)
> Resilience against unsupported Charsets in Request
>
> * [WICKET-5470] - Remove 'final' from org.apache.wicket.markup.html.
> form.EnumChoiceRenderer#getDisplayValue
>
> * [WICKET-5471] - Store the page if it is known that it will be used
> in a following request
>
> * [WICKET-5493] - Disable jar indexing
>
> ** New Feature
>
> * [WICKET-3491] - Introduce IComponentOnConfigureListener
>
> ** Task
>
> * [WICKET-5488] - Promote experimental modules to become stable
>
> * [WICKET-5494] - Upgrade JQuery to latest stable - 1.11.0 and 2.1.0
>