[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #22679: Expand mapped tasks at DagRun.Veriy_integrity

[GitBox <gi...@apache.org>]

ephraimbuddy commented on code in PR #22679:
URL: https://github.com/apache/airflow/pull/22679#discussion_r841917384


##########
airflow/models/dagrun.py:
##########
@@ -839,25 +839,43 @@ def task_filter(task: "Operator") -> bool:
 
         if hook_is_noop:
 
-            def create_ti_mapping(task: "Operator") -> dict:
-                created_counts[task.task_type] += 1
-                return TI.insert_mapping(self.run_id, task, map_index=-1)
+            def create_ti_mapping(task: "Operator") -> List[dict]:
+                if isinstance(task, MappedOperator):

Review Comment:
   Should I move `is_mapped` to BaseOperator because mypy complains(on the code you gave me too @ashb which is same as the review above)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org