You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "John Patterson (JIRA)" <ji...@apache.org> on 2007/10/10 02:55:50 UTC
[jira] Created: (WICKET-1057) Remove final from
WebRequestCodingStrategy. urlCodingStrategyForPath
Remove final from WebRequestCodingStrategy. urlCodingStrategyForPath
--------------------------------------------------------------------
Key: WICKET-1057
URL: https://issues.apache.org/jira/browse/WICKET-1057
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta3
Reporter: John Patterson
I am trying to use my own encoding that does not depend on mounted paths. I want normal mounted paths and the default wicket paths to work as usual and for my strategy to be used after they have been tried.
For encoding URLs with my strategy I can override WebRequestCodingStrategy .getMountEncoder(IRequestTarget) which allows the normal mounts to be tried first and then return my strategy if non are found.
The default decoding works OK but WebRequestCycleProcessor will call WebRequestCodingStrategy .targetForRequest() after the default handling fails and I cannot return my own strategy because I cannot override urlCodingStrategyForPath() because it is final.
I have removed this locally and it works as I expected.
It seems like the only option at the moment is to use a subclass or WebRequestCodingStrategy AND create an adaptor (wrapper) for WebRequestCodingStrategy which detects when targetForRequest() returns null and returns my own strategy.
If the final is removed from rlCodingStrategyForPath(String path) life would be a lot easier!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1057) Remove final from
WebRequestCodingStrategy. urlCodingStrategyForPath
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-1057.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta5
> Remove final from WebRequestCodingStrategy. urlCodingStrategyForPath
> --------------------------------------------------------------------
>
> Key: WICKET-1057
> URL: https://issues.apache.org/jira/browse/WICKET-1057
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: John Patterson
> Fix For: 1.3.0-beta5
>
>
> I am trying to use my own encoding that does not depend on mounted paths. I want normal mounted paths and the default wicket paths to work as usual and for my strategy to be used after they have been tried.
> For encoding URLs with my strategy I can override WebRequestCodingStrategy .getMountEncoder(IRequestTarget) which allows the normal mounts to be tried first and then return my strategy if non are found.
> The default decoding works OK but WebRequestCycleProcessor will call WebRequestCodingStrategy .targetForRequest() after the default handling fails and I cannot return my own strategy because I cannot override urlCodingStrategyForPath() because it is final.
> I have removed this locally and it works as I expected.
> It seems like the only option at the moment is to use a subclass or WebRequestCodingStrategy AND create an adaptor (wrapper) for WebRequestCodingStrategy which detects when targetForRequest() returns null and returns my own strategy.
> If the final is removed from rlCodingStrategyForPath(String path) life would be a lot easier!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.