You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Todd Lipcon <to...@cloudera.com> on 2010/06/03 21:39:08 UTC
Review Request: HBASE-2651 allow specifying non-tab separators in ImportTSV
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/
-----------------------------------------------------------
Review request for hbase and Jonathan Gray.
Summary
-------
Pretty self explanatory.
This addresses bug HBASE-2651.
http://issues.apache.org/jira/browse/HBASE-2651
Diffs
-----
src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java 32ba01d
src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java 612b00a
Diff: http://review.hbase.org/r/116/diff
Testing
-------
Thanks,
Todd
Re: Review Request: HBASE-2651 allow specifying non-tab separators in
ImportTSV
Posted by Todd Lipcon <to...@cloudera.com>.
> On 2010-06-03 12:53:48, stack wrote:
> > +1 I reviewed this already but seems like review board lost my review.
really? cuz I just posted it a minute ago :)
- Todd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/#review126
-----------------------------------------------------------
On 2010-06-03 12:39:07, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/116/
> -----------------------------------------------------------
>
> (Updated 2010-06-03 12:39:07)
>
>
> Review request for hbase and Jonathan Gray.
>
>
> Summary
> -------
>
> Pretty self explanatory.
>
>
> This addresses bug HBASE-2651.
> http://issues.apache.org/jira/browse/HBASE-2651
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java 32ba01d
> src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java 612b00a
>
> Diff: http://review.hbase.org/r/116/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: HBASE-2651 allow specifying non-tab separators in
ImportTSV
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/#review126
-----------------------------------------------------------
Ship it!
+1 I reviewed this already but seems like review board lost my review.
- stack
On 2010-06-03 12:39:07, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/116/
> -----------------------------------------------------------
>
> (Updated 2010-06-03 12:39:07)
>
>
> Review request for hbase and Jonathan Gray.
>
>
> Summary
> -------
>
> Pretty self explanatory.
>
>
> This addresses bug HBASE-2651.
> http://issues.apache.org/jira/browse/HBASE-2651
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java 32ba01d
> src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java 612b00a
>
> Diff: http://review.hbase.org/r/116/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: HBASE-2651 allow specifying non-tab separators in
ImportTSV
Posted by Ryan Rawson <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/#review128
-----------------------------------------------------------
Ship it!
- Ryan
On 2010-06-03 12:39:07, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/116/
> -----------------------------------------------------------
>
> (Updated 2010-06-03 12:39:07)
>
>
> Review request for hbase and Jonathan Gray.
>
>
> Summary
> -------
>
> Pretty self explanatory.
>
>
> This addresses bug HBASE-2651.
> http://issues.apache.org/jira/browse/HBASE-2651
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java 32ba01d
> src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java 612b00a
>
> Diff: http://review.hbase.org/r/116/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Todd
>
>