[GitHub] [libcloud] Kami commented on a change in pull request #1400: Implemented chunked upload for Azure Blobs storage driver

[GitBox <gi...@apache.org>]

Kami commented on a change in pull request #1400: Implemented chunked upload for Azure Blobs storage driver
URL: https://github.com/apache/libcloud/pull/1400#discussion_r364073143
 
 

 ##########
 File path: libcloud/storage/base.py
 ##########
 @@ -584,7 +584,6 @@ def _save_object(self, response, obj, destination_path,
     def _upload_object(self, object_name, content_type, request_path,
                        request_method='PUT',
                        headers=None, file_path=None, stream=None,
-                       upload_func=None, upload_func_kwargs=None,
 
 Review comment:
   Yep, I assume those arguments became unused when libcloud switched to the requests library (that change also seemed to have introduced a lot of unintentional regressions related to streaming uploads and downloading).
   
   Sadly it's not trivial to write good unit / integration tests for that. In the past we mostly had unit tests which mocked some of that functionality for tests so real life issues and regressions introduced as part of the requests migration were not caught.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services