You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/01/31 11:25:53 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1191: [CELEBORN-171][FOLLOWUP] Auto activate jdk-8 profile
pan3793 opened a new pull request, #1191:
URL: https://github.com/apache/incubator-celeborn/pull/1191
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Auto activate `jdk-8` maven profile when using JDK 8.
### Why are the changes needed?
The `jdk-*` profile should be activate based on the JDK version automatically.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 merged pull request #1191: [CELEBORN-171][FOLLOWUP] Auto activate jdk-8 profile
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #1191:
URL: https://github.com/apache/incubator-celeborn/pull/1191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1191: [CELEBORN-171][FOLLOWUP] Auto activate jdk-8 profile
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1191:
URL: https://github.com/apache/incubator-celeborn/pull/1191#issuecomment-1410217432
Merged to main/branch-0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1191: [CELEBORN-171][FOLLOWUP] Auto activate jdk-8 profile
Posted by codecov.
codecov[bot] commented on PR #1191:
URL: https://github.com/apache/incubator-celeborn/pull/1191#issuecomment-1410199048
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1191?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1191](https://codecov.io/gh/apache/incubator-celeborn/pull/1191?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ba2527) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/7162be2fae752a90edb21bbb4c04d9bfb8d391b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7162be2) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1191 +/- ##
============================================
+ Coverage 26.86% 26.89% +0.04%
- Complexity 772 776 +4
============================================
Files 205 205
Lines 17399 17399
Branches 1895 1895
============================================
+ Hits 4672 4678 +6
+ Misses 12403 12401 -2
+ Partials 324 320 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.73% <0.00%> (+2.46%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org