You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <e....@gmx.net> on 2004/12/06 20:21:33 UTC

Re: svn commit: r12180 - trunk/subversion/libsvn_subr

http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_subr/cmdline.c?view=diff&rev=12180&p1=trunk/subversion/libsvn_subr/cmdline.c&r1=12179&p2=trunk/subversion/libsvn_subr/cmdline.c&r2=12180
>
==============================================================================
> --- trunk/subversion/libsvn_subr/cmdline.c	(original)
> +++ trunk/subversion/libsvn_subr/cmdline.c	Mon Dec  6 05:26:58 2004
> @@ -199,7 +199,12 @@
>      if (!apr_err && (inwords > 0 || outbytes == 0))
>        apr_err = APR_INCOMPLETE;
>      if (apr_err)
> -      goto utf8_error;
> +      {
> +       utf8_error:
> +        if (error_stream)
> +          fprintf (error_stream, "Can't convert module path to UTF-8");
> +        return EXIT_FAILURE;
> +      }

So, do you still need the label without the goto?


bye,


Erik.

-- 
NEU +++ DSL Komplett von GMX +++ http://www.gmx.net/de/go/dsl
GMX DSL-Netzanschluss + Tarif zum superg�nstigen Komplett-Preis!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12180 - trunk/subversion/libsvn_subr

Posted by John Szakmeister <jo...@szakmeister.net>.
On Monday 06 December 2004 15:21, Erik Huelsmann wrote:
> http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_subr/cmdline.
>c?view=diff&rev=12180&p1=trunk/subversion/libsvn_subr/cmdline.c&r1=12179
>&p2=trunk/subversion/libsvn_subr/cmdline.c&r2=12180
>
> =======================================================================
>=======
>
> > --- trunk/subversion/libsvn_subr/cmdline.c	(original)
> > +++ trunk/subversion/libsvn_subr/cmdline.c	Mon Dec  6 05:26:58 2004
> > @@ -199,7 +199,12 @@
> >      if (!apr_err && (inwords > 0 || outbytes == 0))
> >        apr_err = APR_INCOMPLETE;
> >      if (apr_err)
> > -      goto utf8_error;
> > +      {
> > +       utf8_error:
> > +        if (error_stream)
> > +          fprintf (error_stream, "Can't convert module path to
> > UTF-8"); +        return EXIT_FAILURE;
> > +      }
>
> So, do you still need the label without the goto?

There are two other goto's above this. :-)

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org