You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/07/03 06:40:14 UTC
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3425:
[WIP DO NOT MERGE] Better tracking host maintanence success and failure
rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r299796886
##########
File path: api/src/main/java/com/cloud/resource/ResourceState.java
##########
@@ -22,17 +22,26 @@
import com.cloud.utils.fsm.StateMachine;
public enum ResourceState {
- Creating, Enabled, Disabled, PrepareForMaintenance, ErrorInMaintenance, Maintenance, Error;
+ Creating,
+ Enabled,
+ Disabled,
+ PrepareForMaintenance,
+ ErrorInMaintenance,
+ Maintenance,
+ Error,
+ PrepareForMaintenanceErrorsPresent;
Review comment:
Can you rename `PrepareForMaintenanceErrorsPresent` to `ErrorInPrepareForMaintenance` to be uniform with other names such as `ErrorInMaintenance`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services