You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Andrus Adamchik (JIRA)" <ji...@apache.org> on 2009/08/13 13:16:14 UTC

[jira] Commented: (CAY-1256) [PATCH] Easily subclassable ExtendedEnumType for reusing an existing Enum

    [ https://issues.apache.org/jira/browse/CAY-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742797#action_12742797 ] 

Andrus Adamchik commented on CAY-1256:
--------------------------------------

I don't understand the value of this approach. Writing a custom ExtendedType for a known enum is rather trivial as it is. Subclassing ExtendedEnumType doesn't seem to buy you much.

> [PATCH] Easily subclassable ExtendedEnumType for reusing an existing Enum
> -------------------------------------------------------------------------
>
>                 Key: CAY-1256
>                 URL: https://issues.apache.org/jira/browse/CAY-1256
>             Project: Cayenne
>          Issue Type: Improvement
>          Components: Cayenne Core Library
>            Reporter: Jeremias Maerki
>         Attachments: EasilySubclassableExtendedEnumType.diff
>
>
> I've had this enum class that has character codes that I use in a CHAR(1) field.
> public enum Status {
>     NEW('N'), PENDING('P'), CANCELLED('X'), CLOSED('C');
> [..]
> I didn't want that enum class to introduce a dependency on Cayenne (through the ExtendedEnumeration interface. So I changed ExtendedEnumType a bit so you can support that enum class with just a few lines of code and without using ExtendedEnumeration.
> Please see the patch for an example. I've written a test case for this although this just covers the materialization.
> In the application code I can now simply do this to register the type:
>         node.getAdapter().getExtendedTypes().registerType(new StatusExtendedEnumType());
> (my StatusExtendedEnumType is basically the same as the MockEnumWithCodeEnumType in the patch)
> I hope you find this useful, too. Patch is against Cayenne Trunk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.