You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/11 12:29:10 UTC

[GitHub] [ignite] Mmuzaf opened a new pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Mmuzaf opened a new pull request #8642:
URL: https://github.com/apache/ignite/pull/8642


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8642:
URL: https://github.com/apache/ignite/pull/8642#discussion_r556046715



##########
File path: docs/_docs/events/events.adoc
##########
@@ -325,6 +325,22 @@ They allow you to get notification about different stages of transaction executi
 | EVT_TX_RESUMED | A transaction is resumed. |The node where the transaction was started.
 |===
 
+== Snapshot Events
+
+All snapshot events are instances of the link:{events_url}/SnapshotEvent.html[SnapshotEvent] class. The snapshot events
+always triggered at the node initiated a snapshot operation and associate with the particular snapshot operation name.
+These events allow you to be notified about the states and result of the cluster snapshot operation for further processing
+your custom procedures.
+
+
+[cols="2,5,3",opts="header"]
+|===
+| Event Type | Event Description | Where Event Is Fired
+| EVT_CLUSTER_SNAPSHOT_STARTED | A cluster snapshot operation is started. | The node where the snapshot operation was initiated.
+| EVT_CLUSTER_SNAPSHOT_FINISHED | A cluster snapshot operation is finished. The event fired when the snapshot operation finished on all the cluster nodes. |  The node where the snapshot operation was finished.
+| EVT_CLUSTER_SNAPSHOT_FAILED | A cluster snapshot operation is failed. | The node where the snapshot operation was initiated. Note that message will contain the short reason of the failure from another node. You may check the logs for details.

Review comment:
       ```suggestion
   | EVT_CLUSTER_SNAPSHOT_FAILED | A cluster snapshot operation is failed. | The node where the snapshot operation was initiated. Note that the message will contain a failure description from another node. You may check the logs for details.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf commented on pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on pull request #8642:
URL: https://github.com/apache/ignite/pull/8642#issuecomment-759338868


   @Nikita-tech-writer 
   
   Thank you for the review. I've applied all your suggestions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8642:
URL: https://github.com/apache/ignite/pull/8642#discussion_r556045587



##########
File path: docs/_docs/events/events.adoc
##########
@@ -325,6 +325,22 @@ They allow you to get notification about different stages of transaction executi
 | EVT_TX_RESUMED | A transaction is resumed. |The node where the transaction was started.
 |===
 
+== Snapshot Events
+
+All snapshot events are instances of the link:{events_url}/SnapshotEvent.html[SnapshotEvent] class. The snapshot events
+always triggered at the node initiated a snapshot operation and associate with the particular snapshot operation name.
+These events allow you to be notified about the states and result of the cluster snapshot operation for further processing
+your custom procedures.
+
+
+[cols="2,5,3",opts="header"]
+|===
+| Event Type | Event Description | Where Event Is Fired
+| EVT_CLUSTER_SNAPSHOT_STARTED | A cluster snapshot operation is started. | The node where the snapshot operation was initiated.
+| EVT_CLUSTER_SNAPSHOT_FINISHED | A cluster snapshot operation is finished. The event fired when the snapshot operation finished on all the cluster nodes. |  The node where the snapshot operation was finished.

Review comment:
       ```suggestion
   | EVT_CLUSTER_SNAPSHOT_FINISHED | A cluster snapshot operation is finished. The event is fired when the snapshot operation is finished on all the cluster nodes. |  The node where the snapshot operation was finished.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8642:
URL: https://github.com/apache/ignite/pull/8642#discussion_r556043686



##########
File path: docs/_docs/events/events.adoc
##########
@@ -325,6 +325,22 @@ They allow you to get notification about different stages of transaction executi
 | EVT_TX_RESUMED | A transaction is resumed. |The node where the transaction was started.
 |===
 
+== Snapshot Events
+
+All snapshot events are instances of the link:{events_url}/SnapshotEvent.html[SnapshotEvent] class. The snapshot events
+always triggered at the node initiated a snapshot operation and associate with the particular snapshot operation name.
+These events allow you to be notified about the states and result of the cluster snapshot operation for further processing
+your custom procedures.
+
+
+[cols="2,5,3",opts="header"]
+|===
+| Event Type | Event Description | Where Event Is Fired

Review comment:
       ```suggestion
   | Event Type | Event Description | Where Event is Fired
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8642:
URL: https://github.com/apache/ignite/pull/8642#discussion_r556041786



##########
File path: docs/_docs/events/events.adoc
##########
@@ -325,6 +325,22 @@ They allow you to get notification about different stages of transaction executi
 | EVT_TX_RESUMED | A transaction is resumed. |The node where the transaction was started.
 |===
 
+== Snapshot Events
+
+All snapshot events are instances of the link:{events_url}/SnapshotEvent.html[SnapshotEvent] class. The snapshot events
+always triggered at the node initiated a snapshot operation and associate with the particular snapshot operation name.
+These events allow you to be notified about the states and result of the cluster snapshot operation for further processing

Review comment:
       ```suggestion
   These events can notify you about the states and the result of the cluster snapshot operation, which can be used for further processing in
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8642:
URL: https://github.com/apache/ignite/pull/8642#discussion_r556040317



##########
File path: docs/_docs/events/events.adoc
##########
@@ -325,6 +325,22 @@ They allow you to get notification about different stages of transaction executi
 | EVT_TX_RESUMED | A transaction is resumed. |The node where the transaction was started.
 |===
 
+== Snapshot Events
+
+All snapshot events are instances of the link:{events_url}/SnapshotEvent.html[SnapshotEvent] class. The snapshot events
+always triggered at the node initiated a snapshot operation and associate with the particular snapshot operation name.

Review comment:
       ```suggestion
   are always triggered at the node initiated a snapshot operation. They are also associated with the particular snapshot operation name.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf merged pull request #8642: IGNITE-13968 Add snapshot events documentation pages

Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #8642:
URL: https://github.com/apache/ignite/pull/8642


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org