You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/11/18 18:54:05 UTC
[GitHub] [drill] vvysotskyi commented on a change in pull request #1901:
DRILL-7388: Kafka improvements
vvysotskyi commented on a change in pull request #1901: DRILL-7388: Kafka improvements
URL: https://github.com/apache/drill/pull/1901#discussion_r347534328
##########
File path: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaPartitionScanSpecBuilder.java
##########
@@ -31,30 +31,30 @@
import org.apache.kafka.clients.consumer.OffsetAndTimestamp;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.serialization.ByteArrayDeserializer;
+
import java.util.List;
import java.util.Map;
import java.util.Set;
-import java.util.concurrent.TimeUnit;
-public class KafkaPartitionScanSpecBuilder extends
- AbstractExprVisitor<List<KafkaPartitionScanSpec>,Void,RuntimeException> {
- static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(KafkaPartitionScanSpecBuilder.class);
+public class KafkaPartitionScanSpecBuilder
+ extends AbstractExprVisitor<List<KafkaPartitionScanSpec>,Void,RuntimeException>
Review comment:
```suggestion
extends AbstractExprVisitor<List<KafkaPartitionScanSpec>, Void, RuntimeException>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services