You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/28 09:38:14 UTC
[GitHub] [spark] sigmod opened a new pull request #35677: [SPARK-38347] Fix nullability propagation in transformUpWithNewOutput
sigmod opened a new pull request #35677:
URL: https://github.com/apache/spark/pull/35677
### What changes were proposed in this pull request?
In `updateAttr`, let the new Attribute have the same nullability as the Attribute to be replaced.
### Why are the changes needed?
`attrMap` can possibly be populated below an outer join and the outer join changes nullability.
### How was this patch tested?
New unit test - verified that it fails without the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #35677: [SPARK-38347] Fix nullability propagation in transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
sigmod commented on pull request #35677:
URL: https://github.com/apache/spark/pull/35677#issuecomment-1054067036
cc @gengliangwang @cloud-fan @allisonwang-db @YannisSismanis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #35677: [SPARK-38347][SQL] Fix nullability propagation in transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #35677:
URL: https://github.com/apache/spark/pull/35677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #35677: [SPARK-38347][SQL] Fix nullability propagation in transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
sigmod commented on pull request #35677:
URL: https://github.com/apache/spark/pull/35677#issuecomment-1054519814
> @sigmod the code changes can't apply on branch-3.2 directly. Could you open a new PR for branch-3.2?
Here you go: https://github.com/apache/spark/pull/35685.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35677: [SPARK-38347][SQL] Fix nullability propagation in transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35677:
URL: https://github.com/apache/spark/pull/35677#issuecomment-1054246283
@sigmod the code changes can't apply on branch-3.2 directly. Could you open a new PR for branch-3.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35677: [SPARK-38347][SQL] Fix nullability propagation in transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35677:
URL: https://github.com/apache/spark/pull/35677#issuecomment-1054244787
Thanks, merging to master/3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org