[GitHub] [kafka] dajac commented on a diff in pull request #13812: KAFKA-14462; [18/N] Add GroupCoordinatorService

["dajac (via GitHub)" <gi...@apache.org>]

dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1229221067


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.coordinator.group;
+
+import org.apache.kafka.coordinator.group.assignor.PartitionAssignor;
+
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * The group coordinator configurations.
+ */
+public class GroupCoordinatorConfig {
+    public static class Builder {
+        private int numThreads = 1;

Review Comment:
   Interesting pattern used in RemoteLogManagerConfig. As we define the properties in the `ConfigDef` in that class and not in the `ConfigDef` used in `KafkaConfig`, all the remote storage properties are not documented in the documentation. The documentation is generated based on the `ConfigDef` in `KafkaConfig`. I suppose that we missed this... We use a similar pattern for `RaftConfig` but in this case we defined the properties in two places. I am not a fan of this because it is error prone. It would be better if we could somehow add a `ConfigDef` to another `ConfigDef` to make this automatic and transparent. I will play a bit with this...
   
   In this case, all the properties of the group coordinator and their default values are already defined in KafkaConfig and I just wanted to have a container to move them around in the java module.
   
   However, I agree with the constants part of your comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org