You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/12 16:19:31 UTC

[GitHub] larroy commented on a change in pull request #9397: Remove incorrect link flags when using OPENCV. Add additional library?

larroy commented on a change in pull request #9397: Remove incorrect link flags when using OPENCV. Add additional library?
URL: https://github.com/apache/incubator-mxnet/pull/9397#discussion_r161264195
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -87,7 +87,7 @@ else(MSVC)
   check_cxx_compiler_flag("-std=c++11"   SUPPORT_CXX11)
   check_cxx_compiler_flag("-std=c++0x"   SUPPORT_CXX0X)
   check_cxx_compiler_flag("-msse2"       SUPPORT_MSSE2)
-  set(CMAKE_C_FLAGS "-Wall -Wno-unknown-pragmas -fPIC -Wno-sign-compare")
+  set(CMAKE_C_FLAGS "-Wall -Werror -Wno-unknown-pragmas -fPIC -Wno-sign-compare")
 
 Review comment:
   I can put it in the other one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services