You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/13 05:55:32 UTC
[GitHub] [kafka] abbccdda commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing
abbccdda commented on a change in pull request #9174:
URL: https://github.com/apache/kafka/pull/9174#discussion_r469713175
##########
File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -805,10 +805,10 @@ public void advanceWallClockTime(final Duration advance) {
private Queue<ProducerRecord<byte[], byte[]>> getRecordsQueue(final String topicName) {
final Queue<ProducerRecord<byte[], byte[]>> outputRecords = outputRecordsByTopic.get(topicName);
- if (outputRecords == null) {
- if (!processorTopology.sinkTopics().contains(topicName)) {
- throw new IllegalArgumentException("Unknown topic: " + topicName);
- }
+ if (outputRecords == null && !processorTopology.sinkTopics().contains(topicName)) {
Review comment:
Seems good enough as a bug fix, but I was wondering whether we could detect the dynamic topic is configured or not to make sure we are not actually allowing some other bugs to catch in TTD
##########
File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -805,10 +805,10 @@ public void advanceWallClockTime(final Duration advance) {
private Queue<ProducerRecord<byte[], byte[]>> getRecordsQueue(final String topicName) {
final Queue<ProducerRecord<byte[], byte[]>> outputRecords = outputRecordsByTopic.get(topicName);
- if (outputRecords == null) {
- if (!processorTopology.sinkTopics().contains(topicName)) {
- throw new IllegalArgumentException("Unknown topic: " + topicName);
- }
+ if (outputRecords == null && !processorTopology.sinkTopics().contains(topicName)) {
+ log.warn("Unrecognized topic: {}, this can occur if dynamic routing is used and no output has been "
+ + "sent to this topic yet. If not using a TopicNameExtractor, check that the output topic "
+ + "is correct. ", topicName);
Review comment:
nit: could avoid the last space after `is correct.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org