You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2015/09/03 11:42:57 UTC
Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-12931
https://issues.apache.org/jira/browse/AMBARI-12931
Repository: ambari
Description
-------
Problem:
- Corrupted Block metric on the UI means corrupted replicas.
Solution:
- In fact this metric comes from hadoop:
FSNamesystem.java:
@Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
public long getCorruptReplicaBlocks() {
return blockManager.getCorruptReplicaBlocksCount();
}
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json e47d431
ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
ambari-web/app/messages.js 7912937
Diff: https://reviews.apache.org/r/38095/diff/
Testing
-------
Manually tested on local VM.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:14 h
[INFO] Finished at: 2015-09-03T01:06:58+00:00
[INFO] Final Memory: 50M/619M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Oliver Szabo <os...@hortonworks.com>.
> On Sept. 3, 2015, 7:49 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json, line 250
> > <https://reviews.apache.org/r/38095/diff/1/?file=1063190#file1063190line250>
> >
> > widget_name_widget_layout_name acts as primary id for a widget. if widget_name is changed then on upgrade scenario backend will create the new widget and keep the existing widget and we will end up with 2 instances of the widget with different names.
> >
> >
> > Lets not change the name for the widget and just change the description.
ok. its still a bit misleading but much better than the actual solution. it would be good if Ambari UI would show a different field on the widget as a text, but it should be an another issue/story
- Oliver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/#review97670
-----------------------------------------------------------
On Sept. 3, 2015, 9:42 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38095/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2015, 9:42 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-12931
> https://issues.apache.org/jira/browse/AMBARI-12931
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
>
> - Corrupted Block metric on the UI means corrupted replicas.
>
> Solution:
>
> - In fact this metric comes from hadoop:
>
> FSNamesystem.java:
>
> @Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
> public long getCorruptReplicaBlocks() {
> return blockManager.getCorruptReplicaBlocksCount();
> }
> - Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json e47d431
> ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
> ambari-web/app/messages.js 7912937
>
> Diff: https://reviews.apache.org/r/38095/diff/
>
>
> Testing
> -------
>
> Manually tested on local VM.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:14 h
> [INFO] Finished at: 2015-09-03T01:06:58+00:00
> [INFO] Final Memory: 50M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/#review97670
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json (line 250)
<https://reviews.apache.org/r/38095/#comment153687>
widget_name_widget_layout_name acts as primary id for a widget. if widget_name is changed then on upgrade scenario backend will create the new widget and keep the existing widget and we will end up with 2 instances of the widget with different names.
Lets not change the name for the widget and just change the description.
- Jaimin Jetly
On Sept. 3, 2015, 9:42 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38095/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2015, 9:42 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-12931
> https://issues.apache.org/jira/browse/AMBARI-12931
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
>
> - Corrupted Block metric on the UI means corrupted replicas.
>
> Solution:
>
> - In fact this metric comes from hadoop:
>
> FSNamesystem.java:
>
> @Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
> public long getCorruptReplicaBlocks() {
> return blockManager.getCorruptReplicaBlocksCount();
> }
> - Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json e47d431
> ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
> ambari-web/app/messages.js 7912937
>
> Diff: https://reviews.apache.org/r/38095/diff/
>
>
> Testing
> -------
>
> Manually tested on local VM.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:14 h
> [INFO] Finished at: 2015-09-03T01:06:58+00:00
> [INFO] Final Memory: 50M/619M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------
(Updated March 11, 2016, 5:17 p.m.)
Review request for Ambari, Daniel Gergely, Jaimin Jetly, Laszlo Puskas, and Yusaku Sako.
Changes
-------
added branch-2.2 & fix issues during manual testing
Bugs: AMBARI-12931
https://issues.apache.org/jira/browse/AMBARI-12931
Repository: ambari
Description
-------
Problem:
- Corrupted Block metric on the UI means corrupted replicas.
Solution:
- In fact this metric comes from hadoop:
FSNamesystem.java:
@Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
public long getCorruptReplicaBlocks() {
return blockManager.getCorruptReplicaBlocksCount();
}
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 78cf8bd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 89aab13
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json ee745d9
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java f6dcb18
ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
ambari-web/app/messages.js 6b8317b
Diff: https://reviews.apache.org/r/38095/diff/
Testing
-------
Unit testing done.
Thanks,
Oliver Szabo
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/#review121669
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Feb. 16, 2016, 11:54 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38095/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 11:54 a.m.)
>
>
> Review request for Ambari, Daniel Gergely, Jaimin Jetly, Laszlo Puskas, and Yusaku Sako.
>
>
> Bugs: AMBARI-12931
> https://issues.apache.org/jira/browse/AMBARI-12931
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
>
> - Corrupted Block metric on the UI means corrupted replicas.
>
> Solution:
>
> - In fact this metric comes from hadoop:
>
> FSNamesystem.java:
>
> @Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
> public long getCorruptReplicaBlocks() {
> return blockManager.getCorruptReplicaBlocksCount();
> }
> - Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 2ea326a
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 1010128
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 608a348
> ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
> ambari-web/app/messages.js 08ff073
>
> Diff: https://reviews.apache.org/r/38095/diff/
>
>
> Testing
> -------
>
> Unit testing done.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------
(Updated Feb. 16, 2016, 11:54 a.m.)
Review request for Ambari, Daniel Gergely, Jaimin Jetly, Laszlo Puskas, and Yusaku Sako.
Bugs: AMBARI-12931
https://issues.apache.org/jira/browse/AMBARI-12931
Repository: ambari
Description
-------
Problem:
- Corrupted Block metric on the UI means corrupted replicas.
Solution:
- In fact this metric comes from hadoop:
FSNamesystem.java:
@Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
public long getCorruptReplicaBlocks() {
return blockManager.getCorruptReplicaBlocksCount();
}
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 2ea326a
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 1010128
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 608a348
ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
ambari-web/app/messages.js 08ff073
Diff: https://reviews.apache.org/r/38095/diff/
Testing (updated)
-------
Unit testing done.
Thanks,
Oliver Szabo
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------
(Updated Feb. 15, 2016, 2:25 p.m.)
Review request for Ambari, Daniel Gergely, Jaimin Jetly, Laszlo Puskas, and Yusaku Sako.
Changes
-------
added widget updates
Bugs: AMBARI-12931
https://issues.apache.org/jira/browse/AMBARI-12931
Repository: ambari
Description
-------
Problem:
- Corrupted Block metric on the UI means corrupted replicas.
Solution:
- In fact this metric comes from hadoop:
FSNamesystem.java:
@Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
public long getCorruptReplicaBlocks() {
return blockManager.getCorruptReplicaBlocksCount();
}
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 2ea326a
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 1010128
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 608a348
ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
ambari-web/app/messages.js 08ff073
Diff: https://reviews.apache.org/r/38095/diff/
Testing (updated)
-------
Testing is in progress ...
Thanks,
Oliver Szabo
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 3:41 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-12931
https://issues.apache.org/jira/browse/AMBARI-12931
Repository: ambari
Description
-------
Problem:
- Corrupted Block metric on the UI means corrupted replicas.
Solution:
- In fact this metric comes from hadoop:
FSNamesystem.java:
@Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
public long getCorruptReplicaBlocks() {
return blockManager.getCorruptReplicaBlocksCount();
}
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json e47d431
ambari-web/app/messages.js 7912937
Diff: https://reviews.apache.org/r/38095/diff/
Testing
-------
Manually tested on local VM.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:14 h
[INFO] Finished at: 2015-09-03T01:06:58+00:00
[INFO] Final Memory: 50M/619M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is
"Corrupted replica"
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 2:49 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-12931
https://issues.apache.org/jira/browse/AMBARI-12931
Repository: ambari
Description
-------
Problem:
- Corrupted Block metric on the UI means corrupted replicas.
Solution:
- In fact this metric comes from hadoop:
FSNamesystem.java:
@Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
public long getCorruptReplicaBlocks() {
return blockManager.getCorruptReplicaBlocksCount();
}
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only UI change, what clarifies the definition.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json e47d431
ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5
ambari-web/app/messages.js 7912937
Diff: https://reviews.apache.org/r/38095/diff/
Testing
-------
Manually tested on local VM.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:14 h
[INFO] Finished at: 2015-09-03T01:06:58+00:00
[INFO] Final Memory: 50M/619M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo