You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 19:26:43 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #20298: Fix mypy issues in airflow/jobs
ephraimbuddy opened a new pull request #20298:
URL: https://github.com/apache/airflow/pull/20298
With the exception of triggerer_job, this PR fixes MyPy issues in airflow/jobs.
Also correct use of State, TaskInstanceState, and DagRunState was applied even
though mypy did not warn of those usages
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20298: Fix mypy issues in airflow/jobs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20298:
URL: https://github.com/apache/airflow/pull/20298#issuecomment-994145208
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20298: Fix mypy issues in airflow/jobs
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20298:
URL: https://github.com/apache/airflow/pull/20298#issuecomment-994302273
I like how Mypy is finally forcing us to stop using `State`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #20298: Fix mypy issues in airflow/jobs
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #20298:
URL: https://github.com/apache/airflow/pull/20298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org