You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/04/09 02:30:12 UTC
[GitHub] [thrift] unfetteredwind commented on a change in pull request #2369: Abnormal Branch Memory Leak
unfetteredwind commented on a change in pull request #2369:
URL: https://github.com/apache/thrift/pull/2369#discussion_r610294733
##########
File path: compiler/cpp/src/thrift/generate/t_c_glib_generator.cc
##########
@@ -4061,8 +4061,17 @@ void t_c_glib_generator::generate_deserialize_field(ostream& out,
throw "compiler error: no C reader for base type " + t_base_type::t_base_name(tbase) + name;
}
out << ", error)) < 0)" << endl;
- out << indent() << " return " << error_ret << ";" << endl << indent() << "xfer += ret;"
- << endl;
+ if ((tbase != t_base_type::TYPE_STRING) && allocate) {
Review comment:
4022 is :
If it's not equal t_base_type::TYPE_STRING , I've increased the processing。The two are different,and I think it's an omission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org