You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "shinyaaa (via GitHub)" <gi...@apache.org> on 2024/08/05 10:19:45 UTC
[PR] Refactor Dockerfile to use multi-stage builds [age]
shinyaaa opened a new pull request, #2004:
URL: https://github.com/apache/age/pull/2004
Refactored Dockerfile to use multi-stage builds for reduction image size.
The installation of the packages required for the build and the build process are carried out at the build stage. The built binaries are then placed in the final image.
This changes has reduces the image size about 1/3.
```
$ docker image ls apache/age
REPOSITORY TAG IMAGE ID CREATED SIZE
apache/age tmp 5ffd0b539a88 22 minutes ago 458MB <-- New image
apache/age latest fb44b5789198 2 months ago 1.5GB <-- Original image
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2293863130
> @MuhammadTahaNaveed I don't know what Dockerfile.dev is used for, but I didn't change it because I thought that if it is for development use, it should contain development packages.
>
> Should I modify Dockerfile.dev as well?
Yeah you are right, lets leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2271496575
@shinyaaa You will need to rebase and force update your PR. Please see PR #2007 for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "shinyaaa (via GitHub)" <gi...@apache.org>.
shinyaaa commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2277629843
I found a similar [issue](https://github.com/apache/age/issues/362) and refer to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "shinyaaa (via GitHub)" <gi...@apache.org>.
shinyaaa commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2272449890
@jrgemignani
> @shinyaaa You will need to rebase and force update your PR. Please see PR #2007 for more information.
Thanks, rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "shinyaaa (via GitHub)" <gi...@apache.org>.
shinyaaa commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2276959940
@MuhammadTahaNaveed
I don't know what Dockerfile.dev is used for, but I didn't change it because I thought that if it is for development use, it should contain development packages.
Should I modify Dockerfile.dev as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "shinyaaa (via GitHub)" <gi...@apache.org>.
shinyaaa commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2294834955
@MuhammadTahaNaveed
Created PR for each branch. I also verified that the images created in each Dockerfile worked properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed merged PR #2004:
URL: https://github.com/apache/age/pull/2004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2293866293
@shinyaaa Please create PRs for branches PG11, PG12, PG13, PG14, PG15 and PG16 as well. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Dockerfile to use multi-stage builds [age]
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #2004:
URL: https://github.com/apache/age/pull/2004#issuecomment-2275095526
@shinyaaa Nice work. Could you please add these changes to Dockerfile.dev as well. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org