[jira] [Commented] (ARROW-13448) [R] Bindings for strftime

["Rok Mihevc (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387386#comment-17387386 ] 

Rok Mihevc commented on ARROW-13448:
------------------------------------

I'd suggest the following binding for StrftimeOptions in compute.cpp:
{code:cpp}
  if (func_name == "strftime") {
    using Options = arrow::compute::StrftimeOptions;
    std::string format = "%Y-%m-%dT%H:%M:%SZ";
    std::string locale = "C";
    if (!Rf_isNull(options["format"])) {
      format = cpp11::as_cpp<std::string>(options["format"]);
    }
    if (!Rf_isNull(options["locale"])) {
      locale = cpp11::as_cpp<std::string>(options["locale"]);
    }
    return std::make_shared<Options>(Options(format, locale));
  }
{code}

> [R] Bindings for strftime
> -------------------------
>
>                 Key: ARROW-13448
>                 URL: https://issues.apache.org/jira/browse/ARROW-13448
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: R
>            Reporter: Neal Richardson
>            Priority: Major
>             Fix For: 6.0.0
>
>
> Following ARROW-13174



--
This message was sent by Atlassian Jira
(v8.3.4#803005)