You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/28 03:21:58 UTC

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3405: [Profile] Make running profile clearer and more intuitive to improve usability

HappenLee commented on a change in pull request #3405:
URL: https://github.com/apache/incubator-doris/pull/3405#discussion_r416297516



##########
File path: be/src/exec/exec_node.cpp
##########
@@ -339,7 +337,7 @@ Status ExecNode::create_tree_helper(
     }
 
     if (!node->_children.empty()) {
-        node->runtime_profile()->add_child(node->_children[0]->runtime_profile(), false, NULL);

Review comment:
       after change the ```true```, we can eaily know olap_scan_node is child of aggregation_node. 
   ![image](https://user-images.githubusercontent.com/10553413/80442620-e7048700-893f-11ea-84fa-6d590b48f99f.png)
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org