You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by rahulforallp <gi...@git.apache.org> on 2017/12/05 15:41:37 UTC
[GitHub] carbondata pull request #1618: [CARBONDATA-1853] [WIP] Add support for UDF p...
GitHub user rahulforallp opened a pull request:
https://github.com/apache/carbondata/pull/1618
[CARBONDATA-1853] [WIP] Add support for UDF positionID
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulforallp/incubator-carbondata support_positionIdUdf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1618.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1618
----
----
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1618
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/475/
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1618
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1749/
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1618
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2122/
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1618
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/485/
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/1618
retest this please
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1618
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/474/
---
[GitHub] carbondata pull request #1618: [CARBONDATA-1853] [WIP] Add support for UDF p...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1618#discussion_r155165332
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
@@ -54,6 +54,7 @@ class CarbonEnv {
def init(sparkSession: SparkSession): Unit = {
sparkSession.udf.register("getTupleId", () => "")
+ sparkSession.udf.register("getPositionId", () => "")
--- End diff --
it is not a good idea to add here, better add in CarbonEnvPreListner to register
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1618
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1733/
---
[GitHub] carbondata issue #1618: [CARBONDATA-1853] [WIP] Add support for UDF position...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1618
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2124/
---
[GitHub] carbondata pull request #1618: [CARBONDATA-1853] [WIP] Add support for UDF p...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp closed the pull request at:
https://github.com/apache/carbondata/pull/1618
---