[jira] [Commented] (HBASE-10185) HBaseClient retries even though a DoNotRetryException was thrown

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126568#comment-14126568 ] 

Enis Soztutar commented on HBASE-10185:
---------------------------------------

It seems that this issue has been recycled as a 0.94 backport. [~lhofhansl] feel free to push forward or resolve as won't fix. 

> HBaseClient retries even though a DoNotRetryException was thrown
> ----------------------------------------------------------------
>
>                 Key: HBASE-10185
>                 URL: https://issues.apache.org/jira/browse/HBASE-10185
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC
>    Affects Versions: 0.94.12, 0.99.0
>            Reporter: Samarth Jain
>             Fix For: 0.94.23
>
>         Attachments: 10185.v1.patch, 10185.v2.patch
>
>
> Throwing a DoNotRetryIOException inside  Writable.write(Dataoutput) method doesn't prevent HBase from retrying. Debugging the code locally, I figured that the bug lies in the way HBaseClient simply throws an IOException when it sees that a connection has been closed unexpectedly.  
> Method:
> public Writable call(Writable param, InetSocketAddress addr,
>                        Class<? extends VersionedProtocol> protocol,
>                        User ticket, int rpcTimeout)
> Excerpt of code where the bug is present:
> while (!call.done) {
>         if (connection.shouldCloseConnection.get()) {
>           throw new IOException("Unexpected closed connection");
>         }
> Throwing this IOException causes the ServerCallable.translateException(t) to be a no-op resulting in HBase retrying. 
> From my limited view and understanding of the code, one way I could think of handling this is by looking at the closeConnection member variable of a connection to determine what kind of exception should be thrown. 
> Specifically, when a connection is closed, the current code does this: 
>     protected synchronized void markClosed(IOException e) {
>       if (shouldCloseConnection.compareAndSet(false, true)) {
>         closeException = e;
>         notifyAll();
>       }
>     }
> Within HBaseClient's call method, the code could possibly be modified to:
> while (!call.done) {
>         if (connection.shouldCloseConnection.get() ) {
>                  if(connection.closeException instanceof                   DoNotRetryIOException) {
> throw closeException;
> }
>           throw new IOException("Unexpected closed connection");
>         }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)