You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "Asuka-star (via GitHub)" <gi...@apache.org> on 2025/09/16 13:14:26 UTC
[PR] optimize: unify Jackson/fastjson serialization [incubator-seata]
Asuka-star opened a new pull request, #7639:
URL: https://github.com/apache/incubator-seata/pull/7639
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Unify JSON serializer to Jackson in saga, tcc, at and seata-server modules
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #7554
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: unify Jackson/fastjson serialization [incubator-seata]
Posted by "Asuka-star (via GitHub)" <gi...@apache.org>.
Asuka-star commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3298863118
> I think you misunderstood the purpose of this issue. We need to unify Jackson and FastJSON—the JSON serialization libraries—under a single configuration option and provide a factory that returns the corresponding abstract implementation based on that configuration. First, define an interface that abstracts the JSON-related functionality Seata depends on. Then implement that interface twice: once using FastJSON and once using Jackson. Finally, replace all JSON serialization/deserialization code paths to go through a single JSON utility class; this utility class should perform serialization and deserialization and internally load the selected implementation via SPI according to the configuration.
Thanks for the detailed guidance! This is a much better approach. I now understand the plan is to create a common interface and use SPI to load different JSON implementations based on configuration. I will start working on it. I'll let you know if I have any questions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: unify Jackson/fastjson serialization [incubator-seata]
Posted by "Asuka-star (via GitHub)" <gi...@apache.org>.
Asuka-star commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3298982975
> > > I think you misunderstood the purpose of this issue. We need to unify Jackson and FastJSON—the JSON serialization libraries—under a single configuration option and provide a factory that returns the corresponding abstract implementation based on that configuration. First, define an interface that abstracts the JSON-related functionality Seata depends on. Then implement that interface twice: once using FastJSON and once using Jackson. Finally, replace all JSON serialization/deserialization code paths to go through a single JSON utility class; this utility class should perform serialization and deserialization and internally load the selected implementation via SPI according to the configuration.
> >
> >
> > Thanks for the detailed guidance! This is a much better approach. I now understand the plan is to create a common interface and use SPI to load different JSON implementations based on configuration. I will start working on it. I'll let you know if I have any questions
>
> I think you can refer to the 'discovery' module.
Thanks for the guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] featrue: unify Jackson/fastjson serialization [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3323600554
@Asuka-star Thank you very much for your contribution. Before we start coding, we can discuss it first. I saw that you submitted a lot of code, but it didn't match your intention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] featrue: unify Jackson/fastjson serialization [incubator-seata]
Posted by "Asuka-star (via GitHub)" <gi...@apache.org>.
Asuka-star closed pull request #7639: featrue: unify Jackson/fastjson serialization
URL: https://github.com/apache/incubator-seata/pull/7639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: unify Jackson/fastjson serialization [incubator-seata]
Posted by "Asuka-star (via GitHub)" <gi...@apache.org>.
Asuka-star commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3298980091
> > > I think you misunderstood the purpose of this issue. We need to unify Jackson and FastJSON—the JSON serialization libraries—under a single configuration option and provide a factory that returns the corresponding abstract implementation based on that configuration. First, define an interface that abstracts the JSON-related functionality Seata depends on. Then implement that interface twice: once using FastJSON and once using Jackson. Finally, replace all JSON serialization/deserialization code paths to go through a single JSON utility class; this utility class should perform serialization and deserialization and internally load the selected implementation via SPI according to the configuration.我认为您误解了这个问题的目的。我们需要将 Jackson 和 FastJSON(JSON 序列化库)统一到单个配置选项下,并提供一个工厂函数,根据该配置返回相应的抽象实现。首先,定义一个接口,抽象 Seata 所依赖的 JSON 相关功
能。然后,实现该接口两次:一次使用 FastJSON,一次使用 Jackson。最后,将所有 JSON 序列化/反序列化的代码路径替换为单个 JSON 实用程序类;该实用程序类应执行序列化和反序列化,并根据配置通过 SPI 在内部加载所选的实现。
> >
> >
> > Thanks for the detailed guidance! This is a much better approach. I now understand the plan is to create a common interface and use SPI to load different JSON implementations based on configuration. I will start working on it. I'll let you know if I have any questions感谢您的详细指导!这是一个好得多的方法。我现在明白了,计划是创建一个通用接口,并使用 SPI 根据配置加载不同的 JSON 实现。我会开始着手做这件事。如果我有任何问题,我会告诉你。
>
> I think you can refer to the 'discovery' module.我认为您可以参考“发现”模块。
Thanks for the guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] featrue: unify Jackson/fastjson serialization [incubator-seata]
Posted by "Asuka-star (via GitHub)" <gi...@apache.org>.
Asuka-star commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3332456423
> @Asuka-star Thank you very much for your contribution. Before we start coding, we can discuss it first. I saw that you submitted a lot of code, but it didn't match your intention.
Thank you for your guidance. I will organize my thoughts and then start a discussion on how to unify the JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] featrue: unify Jackson/fastjson serialization [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3320020923
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `52.00000%` with `24 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.04%. Comparing base ([`38f3bd2`](https://app.codecov.io/gh/apache/incubator-seata/commit/38f3bd2c81b61e84df208941f0c6b3a223f16e42?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0171d6a`](https://app.codecov.io/gh/apache/incubator-seata/commit/0171d6aba22ee08f00dede66b5098a5001cbf389?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on 2.x.
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../java/org/apache/seata/json/JsonParserFactory.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=json%2Fseata-json-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fjson%2FJsonParserFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-anNvbi9zZWF0YS1qc29uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlYXRhL2pzb24vSnNvblBhcnNlckZhY3RvcnkuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/seata/json/JsonParserType.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=json%2Fseata-json-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fjson%2FJsonParserType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-anNvbi9zZWF0YS1qc29uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlYXRhL2pzb24vSnNvblBhcnNlclR5cGUuamF2YQ==) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...m/datasource/sql/struct/TableMetaCacheFactory.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=rm-datasource%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Frm%2Fdatasource%2Fsql%2Fstruct%2FTableMetaCacheFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS9zcWwvc3RydWN0L1RhYmxlTWV0YUNhY2hlRmFjdG9yeS5qYXZh) | 83.33% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...a/engine/repo/impl/StateMachineRepositoryImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=saga%2Fseata-saga-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fsaga%2Fengine%2Frepo%2Fimpl%2FStateMachineRepositoryImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvcmVwby9pbXBsL1N0YXRlTWFjaGluZVJlcG9zaXRvcnlJbXBsLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../saga/engine/serializer/impl/ParamsSerializer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=saga%2Fseata-saga-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fsaga%2Fengine%2Fserializer%2Fimpl%2FParamsSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvc2VyaWFsaXplci9pbXBsL1BhcmFtc1NlcmlhbGl6ZXIuamF2YQ==) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/seata/json/fastjson/FastjsonParser.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=json%2Fseata-json-fastjson%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fjson%2Ffastjson%2FFastjsonParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-anNvbi9zZWF0YS1qc29uLWZhc3Rqc29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9qc29uL2Zhc3Rqc29uL0Zhc3Rqc29uUGFyc2VyLmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7639 +/- ##
============================================
- Coverage 61.04% 61.04% -0.01%
+ Complexity 666 664 -2
============================================
Files 1316 1317 +1
Lines 49804 49790 -14
Branches 5855 5854 -1
============================================
- Hits 30403 30392 -11
- Misses 16694 16698 +4
+ Partials 2707 2700 -7
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/seata/common/ConfigurationKeys.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcommon%2FConfigurationKeys.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vQ29uZmlndXJhdGlvbktleXMuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...in/java/org/apache/seata/common/DefaultValues.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcommon%2FDefaultValues.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vRGVmYXVsdFZhbHVlcy5qYXZh) | `100.00% <ø> (ø)` | |
| [...seata/saga/engine/config/DbStateMachineConfig.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=compatible%2Fsrc%2Fmain%2Fjava%2Fio%2Fseata%2Fsaga%2Fengine%2Fconfig%2FDbStateMachineConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2lvL3NlYXRhL3NhZ2EvZW5naW5lL2NvbmZpZy9EYlN0YXRlTWFjaGluZUNvbmZpZy5qYXZh) | `80.68% <100.00%> (+0.03%)` | :arrow_up: |
| [...ta/saga/engine/impl/DefaultStateMachineConfig.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=compatible%2Fsrc%2Fmain%2Fjava%2Fio%2Fseata%2Fsaga%2Fengine%2Fimpl%2FDefaultStateMachineConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2lvL3NlYXRhL3NhZ2EvZW5naW5lL2ltcGwvRGVmYXVsdFN0YXRlTWFjaGluZUNvbmZpZy5qYXZh) | `74.13% <ø> (-0.66%)` | :arrow_down: |
| [...g/apache/seata/json/jackson/JacksonJsonParser.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=json%2Fseata-json-jackson%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fjson%2Fjackson%2FJacksonJsonParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-anNvbi9zZWF0YS1qc29uLWphY2tzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlYXRhL2pzb24vamFja3Nvbi9KYWNrc29uSnNvblBhcnNlci5qYXZh) | `66.66% <100.00%> (ø)` | |
| [...rg/apache/seata/rm/datasource/DataSourceProxy.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=rm-datasource%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Frm%2Fdatasource%2FDataSourceProxy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS9EYXRhU291cmNlUHJveHkuamF2YQ==) | `67.87% <100.00%> (+0.33%)` | :arrow_up: |
| [...saga/engine/config/AbstractStateMachineConfig.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=saga%2Fseata-saga-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fsaga%2Fengine%2Fconfig%2FAbstractStateMachineConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvY29uZmlnL0Fic3RyYWN0U3RhdGVNYWNoaW5lQ29uZmlnLmphdmE=) | `83.60% <ø> (-0.44%)` | :arrow_down: |
| [...seata/saga/engine/config/DbStateMachineConfig.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=saga%2Fseata-saga-spring%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fsaga%2Fengine%2Fconfig%2FDbStateMachineConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvY29uZmlnL0RiU3RhdGVNYWNoaW5lQ29uZmlnLmphdmE=) | `69.73% <100.00%> (-0.64%)` | :arrow_down: |
| [...ta/saga/engine/impl/DefaultStateMachineConfig.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=saga%2Fseata-saga-spring%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fsaga%2Fengine%2Fimpl%2FDefaultStateMachineConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvaW1wbC9EZWZhdWx0U3RhdGVNYWNoaW5lQ29uZmlnLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../engine/invoker/impl/SpringBeanServiceInvoker.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&filepath=saga%2Fseata-saga-spring%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fsaga%2Fengine%2Finvoker%2Fimpl%2FSpringBeanServiceInvoker.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2FnYS9zZWF0YS1zYWdhLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc2FnYS9lbmdpbmUvaW52b2tlci9pbXBsL1NwcmluZ0JlYW5TZXJ2aWNlSW52b2tlci5qYXZh) | `68.20% <100.00%> (-0.34%)` | :arrow_down: |
| ... and [10 more](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] featrue: unify Jackson/fastjson serialization [incubator-seata]
Posted by "Asuka-star (via GitHub)" <gi...@apache.org>.
Asuka-star commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3332459902
> @Asuka-star Thank you very much for your contribution. Before we start coding, we can discuss it first. I saw that you submitted a lot of code, but it didn't match your intention.
Thank you for your guidance. I will organize my thoughts and then start a discussion on how to unify the JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] featrue: unify Jackson/fastjson serialization [incubator-seata]
Posted by "Asuka-star (via GitHub)" <gi...@apache.org>.
Asuka-star commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3319930273
Hi @funky-eyes ,I have already refactored the seata-saga module to use a new, centralized JSON module that I've built.
This is my first time contributing code changes to Seata, so I would really appreciate some guidance, especially on the configuration naming. For now, I'm using a temporary name jsonParser.type as a placeholder.
Could you please provide some suggestions for the proper configuration key names for this new feature, to ensure they align with the project's conventions? I'm happy to make any necessary changes.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: unify Jackson/fastjson serialization [incubator-seata]
Posted by "YoWuwuuuw (via GitHub)" <gi...@apache.org>.
YoWuwuuuw commented on PR #7639:
URL: https://github.com/apache/incubator-seata/pull/7639#issuecomment-3298900387
> > I think you misunderstood the purpose of this issue. We need to unify Jackson and FastJSON—the JSON serialization libraries—under a single configuration option and provide a factory that returns the corresponding abstract implementation based on that configuration. First, define an interface that abstracts the JSON-related functionality Seata depends on. Then implement that interface twice: once using FastJSON and once using Jackson. Finally, replace all JSON serialization/deserialization code paths to go through a single JSON utility class; this utility class should perform serialization and deserialization and internally load the selected implementation via SPI according to the configuration.
>
> Thanks for the detailed guidance! This is a much better approach. I now understand the plan is to create a common interface and use SPI to load different JSON implementations based on configuration. I will start working on it. I'll let you know if I have any questions
I think you can refer to the 'discovery' module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org