[GitHub] [incubator-superset] rusackas commented on pull request #11074: fix: Adding timeout to flaky cypress test, to wait for animation to complete

[GitBox <gi...@apache.org>]

rusackas commented on pull request #11074:
URL: https://github.com/apache/incubator-superset/pull/11074#issuecomment-699510697


   > The way Cypress `get` works is to constantly retry querying the DOM until the elements that match the selector are found or timeout. https://docs.cypress.io/guides/core-concepts/retry-ability.html
   > 
   > So waiting arbitrary duration wouldn't really help with test flakiness. In fact, there is an ESLint rule to discourage that: https://docs.cypress.io/guides/references/best-practices.html
   
   The problem seems to be though that it IS finding an element that matches the selector, but that element is not yet in a state where it's completely visible (animating) or clickable (with `pointer-events:none` applied to it). It _seems_ like it's just not waiting for that transition to finish before starting the `drag` step of the test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org