You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/15 12:26:42 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #3308: feat: authz-keycloak plugin - dynamic scope and resource mapping.

spacewander commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r558273736



##########
File path: apisix/plugins/authz-keycloak.lua
##########
@@ -42,7 +43,6 @@ local schema = {
             enum = {"urn:ietf:params:oauth:grant-type:uma-ticket"},
             minLength = 1, maxLength = 100
         },
-        audience = {type = "string", minLength = 1, maxLength = 100},

Review comment:
       Maybe we can keep the old field and add a deprecated check?
   https://github.com/apache/apisix/blob/bbbdf58d555ee89144b6923e751deabf7e0bbf15/apisix/init.lua#L463-L470




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org