[jira] [Commented] (RANGER-3897) RangerUserStore cache improvement

["Ramachandran (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603374#comment-17603374 ] 

Ramachandran commented on RANGER-3897:
--------------------------------------

The review is available here - https://reviews.apache.org/r/74111/

> RangerUserStore cache improvement
> ---------------------------------
>
>                 Key: RANGER-3897
>                 URL: https://issues.apache.org/jira/browse/RANGER-3897
>             Project: Ranger
>          Issue Type: Bug
>          Components: Ranger
>    Affects Versions: 3.0.0
>            Reporter: Ramachandran
>            Priority: Minor
>
>  
> It seems Apache Ranger open source contains a bug where else block in the below code will not be called at all 
> In the below code else block is a dead code
> {code:java}
> public RangerUserStore getLatestRangerUserStoreOrCached(XUserMgr xUserMgr, Long lastKnownUserStoreVersion, Long rangerUserStoreVersionInDB) throws Exception {
>    RangerUserStore ret = null;
>    if (lastKnownUserStoreVersion == null || !lastKnownUserStoreVersion.equals(rangerUserStoreVersionInDB)) {
>       ret = getLatestRangerUserStore(xUserMgr, lastKnownUserStoreVersion, rangerUserStoreVersionInDB);
>    } else if (lastKnownUserStoreVersion.equals(rangerUserStoreVersionInDB)) {
>       ret = null;
>    } else {
>       ret = getRangerUserStore();
>    }
>    return ret;
> } {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)