[GitHub] [pinot] egalpin commented on a diff in pull request #10092: Fixes filtered agg result column naming and filtered agg order-by compat

[GitBox <gi...@apache.org>]

egalpin commented on code in PR #10092:
URL: https://github.com/apache/pinot/pull/10092#discussion_r1066390177


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/AggregationResultsBlock.java:
##########
@@ -69,7 +84,14 @@ public DataSchema getDataSchema(QueryContext queryContext) {
     ColumnDataType[] columnDataTypes = new ColumnDataType[numColumns];
     for (int i = 0; i < numColumns; i++) {
       AggregationFunction aggregationFunction = _aggregationFunctions[i];
-      columnNames[i] = aggregationFunction.getColumnName();
+      String columnName = aggregationFunction.getResultColumnName();

Review Comment:
   I feel this is a very important change to call out, as I'm likely lacking context to understand all the implications.  I know that at least one unit test failed initially due to this change where the resulting columns were named `count_star` previously, vs `count(*)` now.  This may be an undesirable change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org